From: Manivannan Sadhasivam <mani@kernel.org>
To: Tyler Stachecki <stachecki.tyler@gmail.com>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: host: pci_generic: Add support for Sierra Wireless EM9291
Date: Mon, 6 Nov 2023 11:26:45 +0530 [thread overview]
Message-ID: <20231106055645.GF2474@thinkpad> (raw)
In-Reply-To: <ZUewrgy0acOUkSAk@luigi.stachecki.net>
On Sun, Nov 05, 2023 at 10:11:42AM -0500, Tyler Stachecki wrote:
> On Sun, Nov 05, 2023 at 10:05:10AM -0500, Tyler J. Stachecki wrote:
> > Add support for the Sierra Wireless EM9291 modem.
> > Empirically, it seems to use the same configuration as
> > EM9191.
> >
> > $ lspci -vv
> > 03:00.0 Unassigned class [ff00]: Qualcomm Device 0308
> > Subsystem: Device 18d7:0301
> >
> >
>
> Hi Mani,
>
> I just want to highlight "empirically" here. I do not have
> access to the IP which confirms proper MHI configuration
> here. Given that, not sure it is appropriate for submission
> to the kernel.
>
> However, without these changes, AT is not exposed and QMI
> submissions time out -- so better than nothing...?
>
Yes, and that's how some other modem support is added as well. So it is totally
fine.
Thanks for the patch!
- Mani
> Regards,
> Tyler
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-11-06 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 15:05 [PATCH] bus: mhi: host: pci_generic: Add support for Sierra Wireless EM9291 Tyler J. Stachecki
2023-11-05 15:11 ` Tyler Stachecki
2023-11-06 5:56 ` Manivannan Sadhasivam [this message]
2023-11-06 5:52 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106055645.GF2474@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=stachecki.tyler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox