* [PATCH 0/1] Switch on USB as a wakeup source on sm8250
@ 2023-11-09 0:43 Bryan O'Donoghue
2023-11-09 0:43 ` [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2 Bryan O'Donoghue
2023-12-08 2:57 ` (subset) [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2023-11-09 0:43 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, dmitry.baryshkov, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, bryan.odonoghue
Add in wakeup-source to both USB controllers on sm8250.
I tested that the rb5 gets into and stays in s2idle, subsequently resuming
when a key is pressed on an attached USB keyboard for both Type-A USB 3
ports and via the TCPM controlled Type-C port.
Bryan O'Donoghue (1):
arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++
1 file changed, 2 insertions(+)
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
2023-11-09 0:43 [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bryan O'Donoghue
@ 2023-11-09 0:43 ` Bryan O'Donoghue
2023-11-09 13:30 ` Konrad Dybcio
2023-12-08 2:57 ` (subset) [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Bryan O'Donoghue @ 2023-11-09 0:43 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, dmitry.baryshkov, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, bryan.odonoghue
To test out a different GDSC change I wanted to have a USB keypress resume
a system in suspend.
Adding wakeup-source to usb_1 and usb_2 "just works" for me on rb5.
Consistent with qcm2290 and sa8775p add wakeup-source to the dtsi for the
SoC.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index e43a16df4c7ec..c2d929e62c840 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3878,6 +3878,7 @@ usb_1: usb@a6f8800 {
"dp_hs_phy_irq";
power-domains = <&gcc USB30_PRIM_GDSC>;
+ wakeup-source;
resets = <&gcc GCC_USB30_PRIM_BCR>;
@@ -3942,6 +3943,7 @@ usb_2: usb@a8f8800 {
"dp_hs_phy_irq";
power-domains = <&gcc USB30_SEC_GDSC>;
+ wakeup-source;
resets = <&gcc GCC_USB30_SEC_BCR>;
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
2023-11-09 0:43 ` [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2 Bryan O'Donoghue
@ 2023-11-09 13:30 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-11-09 13:30 UTC (permalink / raw)
To: Bryan O'Donoghue, agross, andersson, dmitry.baryshkov,
robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel
On 11/9/23 01:43, Bryan O'Donoghue wrote:
> To test out a different GDSC change I wanted to have a USB keypress resume
> a system in suspend.
>
> Adding wakeup-source to usb_1 and usb_2 "just works" for me on rb5.
> Consistent with qcm2290 and sa8775p add wakeup-source to the dtsi for the
> SoC.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Maybe we could make it the default in qcom glue somehow..
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH 0/1] Switch on USB as a wakeup source on sm8250
2023-11-09 0:43 [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bryan O'Donoghue
2023-11-09 0:43 ` [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2 Bryan O'Donoghue
@ 2023-12-08 2:57 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: agross, konrad.dybcio, dmitry.baryshkov, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Bryan O'Donoghue
Cc: linux-arm-msm, devicetree, linux-kernel
On Thu, 09 Nov 2023 00:43:10 +0000, Bryan O'Donoghue wrote:
> Add in wakeup-source to both USB controllers on sm8250.
>
> I tested that the rb5 gets into and stays in s2idle, subsequently resuming
> when a key is pressed on an attached USB keyboard for both Type-A USB 3
> ports and via the TCPM controlled Type-C port.
>
> Bryan O'Donoghue (1):
> arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
commit: 48307d83c998db18db6890dccb569146eb12d313
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-08 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-09 0:43 [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bryan O'Donoghue
2023-11-09 0:43 ` [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2 Bryan O'Donoghue
2023-11-09 13:30 ` Konrad Dybcio
2023-12-08 2:57 ` (subset) [PATCH 0/1] Switch on USB as a wakeup source on sm8250 Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).