From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2575C19BAA for ; Fri, 17 Nov 2023 10:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d0PKcw7P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE3A5C433C9; Fri, 17 Nov 2023 10:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700217322; bh=DLM6836wYt4uvikX01TUYZVBmM4WKBU/bmWufq2YISA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d0PKcw7PWObtfG1yWocKN58tAziCxedm3mlHLGCDinBXNJhPPNyYggXYv0/q6SHH1 5cmhS2FbHPjcR2aBXf/Q5e6AUVhCrgSVsMWFLHgY6vYGm3NbHk4x7Ey/EpFHr2bmB3 WOnOL1EP+haLVmzDj7kooCKdNuXNe+VUdhsebZ5/4zCfXbNr6x2/+R6ef384I2sYLj L/EmaHnoMev3x37cc3Kak1AfLRTp1K3tTIiS0EyZpZyzTmzRebuHUwVzVP5C3GHvX5 bC/sJEK/MlN7igw5tJw01ANQvWlX1MfS2GTbvb6l7W4+Kw5S9mNJwQW9ez+BDRzKDs Psw3T/GQdZ5Sg== Date: Fri, 17 Nov 2023 16:05:14 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Nirmal Patel , Jonathan Derrick , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] PCI/ASPM: Clean up disable link state parameter Message-ID: <20231117103514.GN250770@thinkpad> References: <20231114135553.32301-1-johan+linaro@kernel.org> <20231114135553.32301-6-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231114135553.32301-6-johan+linaro@kernel.org> On Tue, Nov 14, 2023 at 02:55:52PM +0100, Johan Hovold wrote: > Replace the current 'sem' parameter to the __pci_disable_link_state() > helper with a more descriptive 'locked' parameter, which indicates > whether a pci_bus_sem read lock is already held. > > Signed-off-by: Johan Hovold > --- Reviewed-by: Manivannan Sadhasivam - Mani > drivers/pci/pcie/aspm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c > index 8cf8cc2d6bba..19b7256d2dc9 100644 > --- a/drivers/pci/pcie/aspm.c > +++ b/drivers/pci/pcie/aspm.c > @@ -1041,7 +1041,7 @@ static struct pcie_link_state *pcie_aspm_get_link(struct pci_dev *pdev) > return bridge->link_state; > } > > -static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > +static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool locked) > { > struct pcie_link_state *link = pcie_aspm_get_link(pdev); > > @@ -1060,7 +1060,7 @@ static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > return -EPERM; > } > > - if (sem) > + if (!locked) > down_read(&pci_bus_sem); > mutex_lock(&aspm_lock); > if (state & PCIE_LINK_STATE_L0S) > @@ -1082,7 +1082,7 @@ static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > link->clkpm_disable = 1; > pcie_set_clkpm(link, policy_to_clkpm_state(link)); > mutex_unlock(&aspm_lock); > - if (sem) > + if (!locked) > up_read(&pci_bus_sem); > > return 0; > @@ -1090,7 +1090,7 @@ static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > > int pci_disable_link_state_locked(struct pci_dev *pdev, int state) > { > - return __pci_disable_link_state(pdev, state, false); > + return __pci_disable_link_state(pdev, state, true); > } > EXPORT_SYMBOL(pci_disable_link_state_locked); > > @@ -1105,7 +1105,7 @@ EXPORT_SYMBOL(pci_disable_link_state_locked); > */ > int pci_disable_link_state(struct pci_dev *pdev, int state) > { > - return __pci_disable_link_state(pdev, state, true); > + return __pci_disable_link_state(pdev, state, false); > } > EXPORT_SYMBOL(pci_disable_link_state); > > -- > 2.41.0 > -- மணிவண்ணன் சதாசிவம்