From: Steven Rostedt <rostedt@goodmis.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Krishna chaitanya chundru <quic_krichai@quicinc.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
<linux-kernel@vger.kernel.org>, <mhi@lists.linux.dev>,
<linux-arm-msm@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
<quic_ramkri@quicinc.com>, <quic_nitegupt@quicinc.com>,
<quic_skananth@quicinc.com>, <quic_parass@quicinc.com>
Subject: Re: [PATCH v5] bus: mhi: host: Add tracing support
Date: Fri, 1 Dec 2023 12:06:48 -0500 [thread overview]
Message-ID: <20231201120648.795ea00c@gandalf.local.home> (raw)
In-Reply-To: <15c0130a-1a4b-c08b-714b-05166f48d23b@quicinc.com>
On Fri, 1 Dec 2023 10:01:33 -0700
Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:
> > +DECLARE_EVENT_CLASS(mhi_process_event_ring,
> > +
> > + TP_PROTO(const char *name, void *rp, __le64 ptr,
> > + __le32 dword0, __le32 dword1),
> > +
> > + TP_ARGS(name, rp, ptr, dword0, dword1),
> > +
> > + TP_STRUCT__entry(
> > + __string(name, name)
> > + __field(__le32, dword0)
> > + __field(__le32, dword1)
> > + __field(int, state)
> > + __field(__le64, ptr)
> > + __field(void *, rp)
> > + ),
> > +
> > + TP_fast_assign(
> > + __assign_str(name, name);
> > + __entry->rp = rp;
> > + __entry->ptr = ptr;
> > + __entry->dword0 = dword0;
> > + __entry->dword1 = dword1;
> > + __entry->state = MHI_TRE_GET_EV_STATE((struct mhi_ring_element *)entry->rp);
>
> "entry"?
> Also, you have the "rp" that was passed into the trace, why not just
> directly use that?
Agreed.
-- Steve
next prev parent reply other threads:[~2023-12-01 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 11:09 [PATCH v5] bus: mhi: host: Add tracing support Krishna chaitanya chundru
2023-12-01 17:01 ` Jeffrey Hugo
2023-12-01 17:06 ` Steven Rostedt [this message]
2023-12-04 9:32 ` Krishna Chaitanya Chundru
2023-12-04 10:57 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201120648.795ea00c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox