linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 0/5] arm64: dts: qcom: fix USB wakeup interrupts again
Date: Wed, 13 Dec 2023 18:33:58 +0100	[thread overview]
Message-ID: <20231213173403.29544-1-johan+linaro@kernel.org> (raw)

The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt
controller in order to be able to wake the system up from low-power
states and to be able to detect disconnect events, which requires
triggering on falling edges.

A recent commit updated the trigger type but failed to change the
interrupt provider as required. This leads to the current Linux driver
failing to probe instead of printing an error during suspend and USB
wakeup not working as intended.

While at it, fix also the SS PHY interrupt so that it too can be used to
wakeup the system up.

Thanks to Konrad for reporting the probe failure on sc8180x and
providing the corresponding PDC interrupts and to Krishna for providing
the remaining PDC interrupts. The exception is for the second controller
on sm8150 whose PDC vectors I inferred from sdm845.

Note sdm670 and sm6375 need similar fixes and I believe Bjorn is trying
to dig out the corresponding vectors. The SS PHY interrupt on sc8180x
should also be fixed.

Also note that these patches have only been compile tested.

Johan


Johan Hovold (5):
  arm64: dts: qcom: sc8180x: fix USB DP/DM HS PHY interrupts
  arm64: dts: qcom: sdm845: fix USB DP/DM HS PHY interrupts
  arm64: dts: qcom: sdm845: fix USB SS wakeup
  arm64: dts: qcom: sm8150: fix USB DP/DM HS PHY interrupts
  arm64: dts: qcom: sm8150: fix USB SS wakeup

 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 16 ++++++++--------
 arch/arm64/boot/dts/qcom/sdm845.dtsi  | 16 ++++++++--------
 arch/arm64/boot/dts/qcom/sm8150.dtsi  | 16 ++++++++--------
 3 files changed, 24 insertions(+), 24 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-12-13 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 17:33 Johan Hovold [this message]
2023-12-13 17:33 ` [PATCH 1/5] arm64: dts: qcom: sc8180x: fix USB DP/DM HS PHY interrupts Johan Hovold
2023-12-14 17:59   ` Konrad Dybcio
2023-12-13 17:34 ` [PATCH 2/5] arm64: dts: qcom: sdm845: " Johan Hovold
2023-12-13 18:58   ` Konrad Dybcio
2023-12-13 17:34 ` [PATCH 3/5] arm64: dts: qcom: sdm845: fix USB SS wakeup Johan Hovold
2023-12-13 18:58   ` Konrad Dybcio
2023-12-13 17:34 ` [PATCH 4/5] arm64: dts: qcom: sm8150: fix USB DP/DM HS PHY interrupts Johan Hovold
2023-12-13 18:59   ` Konrad Dybcio
2023-12-13 17:34 ` [PATCH 5/5] arm64: dts: qcom: sm8150: fix USB SS wakeup Johan Hovold
2023-12-13 19:00   ` Konrad Dybcio
2023-12-13 18:49 ` [PATCH 0/5] arm64: dts: qcom: fix USB wakeup interrupts again Konrad Dybcio
2023-12-14  1:55   ` Krishna Kurapati PSSNV
2023-12-14  7:47     ` Johan Hovold
2023-12-17 17:21 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213173403.29544-1-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_kriskura@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).