From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org,
bhelgaas@google.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] PCI: epf-mhi: Enable MHI async read/write support
Date: Thu, 14 Dec 2023 15:39:36 +0530 [thread overview]
Message-ID: <20231214100936.GI2938@thinkpad> (raw)
In-Reply-To: <feb4ed1b-ed74-aebe-0ab8-dec123fe0a31@quicinc.com>
On Thu, Dec 14, 2023 at 03:10:01PM +0530, Krishna Chaitanya Chundru wrote:
>
> On 11/27/2023 6:15 PM, Manivannan Sadhasivam wrote:
> > Now that both eDMA and iATU are prepared to support async transfer, let's
> > enable MHI async read/write by supplying the relevant callbacks.
> >
> > In the absence of eDMA, iATU will be used for both sync and async
> > operations.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/pci/endpoint/functions/pci-epf-mhi.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> > index 3d09a37e5f7c..d3d6a1054036 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> > @@ -766,12 +766,13 @@ static int pci_epf_mhi_link_up(struct pci_epf *epf)
> > mhi_cntrl->raise_irq = pci_epf_mhi_raise_irq;
> > mhi_cntrl->alloc_map = pci_epf_mhi_alloc_map;
> > mhi_cntrl->unmap_free = pci_epf_mhi_unmap_free;
> > + mhi_cntrl->read_sync = mhi_cntrl->read_async = pci_epf_mhi_iatu_read;
> > + mhi_cntrl->write_sync = mhi_cntrl->write_async = pci_epf_mhi_iatu_write;
> > if (info->flags & MHI_EPF_USE_DMA) {
> > mhi_cntrl->read_sync = pci_epf_mhi_edma_read;
> > mhi_cntrl->write_sync = pci_epf_mhi_edma_write;
> > - } else {
> > - mhi_cntrl->read_sync = pci_epf_mhi_iatu_read;
> > - mhi_cntrl->write_sync = pci_epf_mhi_iatu_write;
> > + mhi_cntrl->read_async = pci_epf_mhi_edma_read_async;
> > + mhi_cntrl->write_async = pci_epf_mhi_edma_write_async;
>
> I think the read_async & write async should be updated inside the if
> condition where MHI_EPF_USE_DMA flag is set.
>
That's what being done here. Am I missing anything?
- Mani
> - Krishna Chaitanya.
>
> > }
> > /* Register the MHI EP controller */
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-12-14 10:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 12:45 [PATCH 0/9] bus: mhi: ep: Add async read/write support Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 1/9] bus: mhi: ep: Pass mhi_ep_buf_info struct to read/write APIs Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 2/9] bus: mhi: ep: Rename read_from_host() and write_to_host() APIs Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 3/9] bus: mhi: ep: Introduce async read/write callbacks Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 4/9] PCI: epf-mhi: Simulate async read/write using iATU Manivannan Sadhasivam
2023-12-13 18:49 ` Krzysztof Wilczyński
2023-11-27 12:45 ` [PATCH 5/9] PCI: epf-mhi: Add support for DMA async read/write operation Manivannan Sadhasivam
2023-12-13 18:50 ` Krzysztof Wilczyński
2023-11-27 12:45 ` [PATCH 6/9] PCI: epf-mhi: Enable MHI async read/write support Manivannan Sadhasivam
2023-12-13 18:48 ` Krzysztof Wilczyński
2023-12-14 5:19 ` Manivannan Sadhasivam
2023-12-14 9:40 ` Krishna Chaitanya Chundru
2023-12-14 10:09 ` Manivannan Sadhasivam [this message]
2023-12-14 10:14 ` Krishna Chaitanya Chundru
2023-12-14 10:47 ` Manivannan Sadhasivam
2023-12-14 10:54 ` Krishna Chaitanya Chundru
2023-11-27 12:45 ` [PATCH 7/9] bus: mhi: ep: Add support for async DMA write operation Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 8/9] bus: mhi: ep: Add support for async DMA read operation Manivannan Sadhasivam
2023-11-27 12:45 ` [PATCH 9/9] bus: mhi: ep: Add checks for read/write callbacks while registering controllers Manivannan Sadhasivam
2023-12-13 19:31 ` [PATCH 0/9] bus: mhi: ep: Add async read/write support Bjorn Helgaas
2023-12-14 5:21 ` Manivannan Sadhasivam
2023-12-14 10:55 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214100936.GI2938@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_krichai@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).