From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72ADE250E7; Thu, 18 Jan 2024 14:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705589359; cv=none; b=XAXeldyqQIhktJXImQlfgKRDHsqDqVmNuHCaNuU+e0IcnpTQ7hWE0QCIECN9xg7dY/UqVu1iYLkpgEYuMnsrKnMoCd7+4NvnGmsCtH8uU/Pw0M6cLhuL7DVVgZeorLbLYIPh8xZ4YzExIzvpN8LYK3rInstFcIHlQ7bkwpXaICw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705589359; c=relaxed/simple; bh=oaXZOHDx2BP58wrfTY7FOWKwJKm/7v9GcGOdWbyjMH0=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition: Content-Transfer-Encoding:In-Reply-To; b=gpe9SBzCcqb+jGyYO2yheYz/8z6+xcQYr2u3ZNAxEc5XY8mqMvKGQOIO7BTrszXtbeHfKLtkeM3zuAvEoieYu91sqX+mtYp9/Sj/xki/ZnIwaOsh5Hr7x54yDVQyQaFPbYykVg3du4CUR5S3hfeeoRqziYPzGpWl0NLlhcoEiOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZAvBPWzi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZAvBPWzi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37E88C433A6; Thu, 18 Jan 2024 14:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705589358; bh=oaXZOHDx2BP58wrfTY7FOWKwJKm/7v9GcGOdWbyjMH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAvBPWzieJskFoW183PEr8ko56ub1ezMkwW/ohvj1sw9/kCHfTebfeHgole8+UtBy oSEHXiF8clPeYat+HYQzqzDgBvzL8othGgtOItqYWNCMUFFaYudSb+JxreiZlrI5HN 6K8SlxPuZl98eVjzlA6Dkru8H5dyhUzqhwIub2Q7fvMAMJPs1bcq3eTEKrhu9rLxB5 m/eJnCNM0bjMP02XpFYF/zpQG+ICKsvCJOiWnEB3XnglwsvConsP6vhgdwaycTopGV koI+u1gFMxFJ7hjQuhj2S1C0/eKZm1EoiN7CTnCJvnvAFwbip7l+BpdJvLAy0hGeF2 Cm3402uD0STMA== Date: Thu, 18 Jan 2024 14:49:12 +0000 From: Lee Jones To: Anjelique Melendez Cc: pavel@ucw.cz, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, luca.weiss@fairphone.com, konrad.dybcio@linaro.org, u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com, quic_gurus@quicinc.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: (subset) [PATCH v8 0/7] Add support for LUT PPG Message-ID: <20240118144912.GC3305748@google.com> References: <20231221185838.28440-1-quic_amelende@quicinc.com> <170496750168.1654525.11132648331912183091.b4-ty@kernel.org> <20240111100747.GM7948@google.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 16 Jan 2024, Anjelique Melendez wrote: > > > On 1/11/2024 2:07 AM, Lee Jones wrote: > > On Thu, 11 Jan 2024, Lee Jones wrote: > > > >> On Thu, 21 Dec 2023 10:58:30 -0800, Anjelique Melendez wrote: > >>> In certain PMICs, LUT pattern and LPG configuration is stored in SDAM > >>> modules instead of LUT peripheral. This feature is called PPG. > >>> > >>> This change series adds support for PPG. Thanks! > >>> Changes since v7: > >>> - Patch 4/7 > >>> - Initialize hi/lo_pause variables in lpg_pattern_set() > >>> Changes since v6: > >>> - Patch 2/7 > >>> - Removed required by constraint on PPG dt properties > >>> Changes since v5: > >>> - Patch 4/7 > >>> - Update logic so that multicolor led device triggers pattern > >>> on all LEDs at the same time > >>> - Update nitpicks from Lee > >>> - Patch 5/7 > >>> - Update nitpicks from Lee > >>> Changes since v4: > >>> - Patch 3/7 > >>> - Get rid of r/w helpers > >>> - Use regmap_read_poll_timeout() in qcom_pbs_wait_for_ack() > >>> - Update error path in qcom_pbs_trigger_event() > >>> - Fix reverse christmas tree > >>> - Patch 4/7 > >>> - Get rid of r/w helpers > >>> - Update variables to use "sdam" instead of "nvmem" > >>> - Fix comments > >>> - Fix reverse christmas tree > >>> - Update lpg_pattern_set() logic > >>> - Patch 5/7 > >>> - Removed sdam_lut_base from lpg_data > >>> Changes since v3: > >>> - Patch 4/7 > >>> - Fix function returns > >>> - Move register definition to top of file > >>> - Revert max_brightness and probe accidental changes > >>> - Combine init_sdam() and parse_sdam() > >>> - Change error prints in probe to use dev_err_probe > >>> - Remove ppg_en variable > >>> - Update when pbs triggers are set/cleared > >>> - Patch 6/7 > >>> - Remove use of nvmem_count > >>> - Move register definition to top of file > >>> - Remove lpg_get_sdam_lut_idx() > >>> Changes since v2: > >>> - Patch 1/7 > >>> - Fix dt_binding_check error > >>> - Rename binding file to match compatible > >>> - Iclude SoC specific comptaibles > >>> - Patch 2/7 > >>> - Update nvmem-names list > >>> - Patch 3/7 > >>> - Update EXPORT_SYMBOL to EXPORT_SYMBOL_GPL > >>> - Fix return/break logic in qcom_pbs_wait_for_ack() > >>> - Update iterators to be int > >>> - Add constants > >>> - Fix function calls in qcom_pbs_trigger_event() > >>> - Remove unnessary comments > >>> - Return -EPROBE_DEFER from get_pbs_client_device() > >>> Changes since v1: > >>> - Patch 1/7 > >>> - Fix dt_binding_check errors > >>> - Update binding description > >>> - Path 2/7 > >>> - Fix dt_binding_check errors > >>> - Update per variant constraints > >>> - Update nvmem description > >>> - Patch 3/7 > >>> - Update get_pbs_client_device() > >>> - Drop use of printk > >>> - Remove unused function > >>> > >>> [...] > >> > >> Applied, thanks! > >> > >> [2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG > >> commit: 2fdd08fec742e0c94a2a06a0c9ee0912b6f7ac39 > >> [4/7] leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM > >> commit: 07a1afc8fbb77cc893e2285112482902ac88a295 > >> [5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG > >> commit: f4f5f6a6f8d7bcc8efd0eee6751def22c9a38fd0 > >> [6/7] leds: rgb: leds-qcom-lpg: Include support for PPG with dedicated LUT SDAM > >> commit: 7399a927272de1fc42f4da8af1d8d60b65a15b84 > >> [7/7] leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme > >> commit: 7b4066868689b1f341e61957611d252b6fa8cafc > > > > This set had a bunch of checkpatch.pl errors. > > > > Please fix them up subsequently. > > > Hi Lee, > > Just wanted to get some quick clarification. Would you like checkpatch.pl issues fixed in a new version > of this series or would you like a new patch to fix all the issues? Looks like these patches are in your > for-leds-next-next branch so I am guessing you would like a new follow up patch > but I just wanted to double check. A follow-up please. -- Lee Jones [李琼斯]