From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Abel Vesa" <abel.vesa@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND v2 2/2] PCI: qcom: Add X1E80100 PCIe support
Date: Wed, 31 Jan 2024 00:09:30 +0530 [thread overview]
Message-ID: <20240130183930.GF4218@thinkpad> (raw)
In-Reply-To: <20240130180040.GA527428@bhelgaas>
On Tue, Jan 30, 2024 at 12:00:40PM -0600, Bjorn Helgaas wrote:
> On Tue, Jan 30, 2024 at 12:25:06PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote:
> > > Add the compatible and the driver data for X1E80100.
> >
> > If you happen to respin the series, please add info about the PCIe controller
> > found on this SoC. Like IP version, Gen speed, max. link width etc...
>
> FWIW, I always prefer actual speeds, e.g., "8 GT/s", instead of things
> like "Gen3", for the reason mentioned in the spec:
>
> Terms like "PCIe Gen3" are ambiguous and should be avoided. For
> example, "gen3" could mean (1) compliant with Base 3.0, (2)
> compliant with Base 3.1 (last revision of 3.x), (3) compliant with
> Base 3.0 and supporting 8.0 GT/s, (4) compliant with Base 3.0 or
> later and supporting 8.0 GT/s, ....
>
Makes sense. Will keep a note of it, thanks!
- Mani
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2024-01-30 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 14:41 [PATCH RESEND v2 0/2] PCI: qcom: Add PCIe support for X1E80100 Abel Vesa
2024-01-29 14:41 ` [PATCH RESEND v2 1/2] dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller Abel Vesa
2024-01-30 6:52 ` Manivannan Sadhasivam
2024-01-30 7:44 ` Krzysztof Kozlowski
2024-01-30 7:45 ` Krzysztof Kozlowski
2024-01-31 8:01 ` Abel Vesa
2024-01-29 14:41 ` [PATCH RESEND v2 2/2] PCI: qcom: Add X1E80100 PCIe support Abel Vesa
2024-01-30 6:55 ` Manivannan Sadhasivam
2024-01-30 18:00 ` Bjorn Helgaas
2024-01-30 18:39 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130183930.GF4218@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).