linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	 Kishon Vijay Abraham I <kishon@kernel.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-clk@vger.kernel.org, quic_cang@quicinc.com,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 07/17] arm64: dts: qcom: sdm845: Fix UFS PHY clocks
Date: Wed, 31 Jan 2024 12:37:30 +0530	[thread overview]
Message-ID: <20240131-ufs-phy-clock-v3-7-58a49d2f4605@linaro.org> (raw)
In-Reply-To: <20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org>

QMP PHY used in SDM845 requires 3 clocks:

* ref - 19.2MHz reference clock from RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC

While at it, let's move 'clocks' property before 'clock-names' to match
the style used commonly.

Fixes: cc16687fbd74 ("arm64: dts: qcom: sdm845: add UFS controller")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index c20592fa7dc8..d655bf5bdb96 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2639,10 +2639,12 @@ ufs_mem_phy: phy@1d87000 {
 			compatible = "qcom,sdm845-qmp-ufs-phy";
 			reg = <0 0x01d87000 0 0x1000>;
 
+			clocks = <&rpmhcc RPMH_CXO_CLK>,
+				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
+				 <&gcc GCC_UFS_MEM_CLKREF_CLK>;
 			clock-names = "ref",
-				      "ref_aux";
-			clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
-				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
+				      "ref_aux",
+				      "qref";
 
 			resets = <&ufs_mem_hc 0>;
 			reset-names = "ufsphy";

-- 
2.25.1


  parent reply	other threads:[~2024-01-31  7:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  7:07 [PATCH v3 00/17] Fix Qcom UFS PHY clocks Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 01/17] dt-bindings: phy: qmp-ufs: Fix " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 02/17] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Manivannan Sadhasivam
2024-01-31  7:16   ` Dmitry Baryshkov
2024-02-01 19:16   ` Konrad Dybcio
2024-01-31  7:07 ` [PATCH v3 03/17] dt-bindings: clock: qcom: Add missing UFS QREF clocks Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 04/17] clk: qcom: gcc-sc8180x: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 05/17] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 06/17] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2024-01-31  7:07 ` Manivannan Sadhasivam [this message]
2024-01-31  7:07 ` [PATCH v3 08/17] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 09/17] arm64: dts: qcom: sm6125: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 10/17] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 11/17] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 12/17] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 13/17] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 14/17] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 15/17] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 16/17] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2024-01-31  7:07 ` [PATCH v3 17/17] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam
2024-02-01 19:17   ` Konrad Dybcio
2024-02-07  4:46 ` (subset) [PATCH v3 00/17] Fix Qcom " Bjorn Andersson
2024-02-07 14:01 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131-ufs-phy-clock-v3-7-58a49d2f4605@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_cang@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).