From: Bjorn Helgaas <helgaas@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Johan Hovold" <johan+linaro@kernel.org>
Subject: Re: [PATCH v2 1/3] PCI: qcom: reshuffle reset logic in 2_7_0 .init
Date: Mon, 12 Feb 2024 15:14:32 -0600 [thread overview]
Message-ID: <20240212211432.GA1145620@bhelgaas> (raw)
In-Reply-To: <20240210-topic-8280_pcie-v2-1-1cef4b606883@linaro.org>
Would be nice to have a hint in the subject line about what this does.
Also capitalize to match the others ("PCI: qcom: <Capitalized verb>").
On Sat, Feb 10, 2024 at 06:10:05PM +0100, Konrad Dybcio wrote:
> At least on SC8280XP, if the PCIe reset is asserted, the corresponding
> AUX_CLK will be stuck at 'off'. This has not been an issue so far,
> since the reset is both left de-asserted by the previous boot stages
> and the driver only toggles it briefly in .init.
>
> As part of the upcoming suspend prodecure however, the reset will be
> held asserted.
s/prodecure/procedure/
> Assert the reset (which may end up being a NOP in some cases) and
> de-assert it back *before* turning on the clocks in preparation for
> introducing RC powerdown and reinitialization.
Bjorn
next prev parent reply other threads:[~2024-02-12 21:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 17:10 [PATCH v2 0/3] Qualcomm PCIe RC shutdown & reinit Konrad Dybcio
2024-02-10 17:10 ` [PATCH v2 1/3] PCI: qcom: reshuffle reset logic in 2_7_0 .init Konrad Dybcio
2024-02-12 21:14 ` Bjorn Helgaas [this message]
2024-02-15 11:51 ` Konrad Dybcio
2024-02-10 17:10 ` [PATCH v2 2/3] PCI: qcom: Read back PARF_LTSSM register Konrad Dybcio
2024-02-12 21:17 ` Bjorn Helgaas
2024-02-14 21:35 ` Konrad Dybcio
2024-02-14 22:28 ` Bjorn Helgaas
2024-02-15 10:21 ` Konrad Dybcio
2024-02-15 16:11 ` Bjorn Helgaas
2024-02-15 18:44 ` Konrad Dybcio
2024-02-16 6:52 ` Johan Hovold
2024-03-15 10:16 ` Konrad Dybcio
2024-03-15 11:16 ` Manivannan Sadhasivam
2024-03-15 16:47 ` Johan Hovold
2024-03-27 19:37 ` Konrad Dybcio
2024-03-27 19:38 ` Konrad Dybcio
2024-02-10 17:10 ` [PATCH v2 3/3] PCI: qcom: properly implement RC shutdown/power up Konrad Dybcio
2024-02-12 21:32 ` Bjorn Helgaas
2024-02-14 21:33 ` Konrad Dybcio
2024-02-15 7:13 ` Johan Hovold
2024-02-15 10:22 ` Konrad Dybcio
2024-02-20 4:12 ` Krishna Chaitanya Chundru
2024-03-27 19:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212211432.GA1145620@bhelgaas \
--to=helgaas@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).