From: kernel test robot <lkp@intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>,
daniel@ffwll.ch, jiasheng@iscas.ac.cn, quic_carlv@quicinc.com,
quic_pkanojiy@quicinc.com, stanislaw.gruszka@linux.intel.com,
jacek.lawrynowicz@linux.intel.com
Cc: oe-kbuild-all@lists.linux.dev, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, ogabbay@kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Subject: Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()
Date: Sat, 16 Mar 2024 04:51:26 +0800 [thread overview]
Message-ID: <202403160449.IaCY0Cl5-lkp@intel.com> (raw)
In-Reply-To: <20240315145034.3972749-2-quic_jhugo@quicinc.com>
Hi Jeffrey,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.8 next-20240315]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jeffrey-Hugo/drm-Add-DRM-managed-alloc_workqueue-and-alloc_ordered_workqueue/20240315-225330
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20240315145034.3972749-2-quic_jhugo%40quicinc.com
patch subject: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240316/202403160449.IaCY0Cl5-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240316/202403160449.IaCY0Cl5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403160449.IaCY0Cl5-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_managed.c:336: warning: Function parameter or struct member 'fmt' not described in 'drmm_alloc_workqueue'
>> drivers/gpu/drm/drm_managed.c:336: warning: Function parameter or struct member 'flags' not described in 'drmm_alloc_workqueue'
>> drivers/gpu/drm/drm_managed.c:336: warning: Function parameter or struct member 'max_active' not described in 'drmm_alloc_workqueue'
>> drivers/gpu/drm/drm_managed.c:336: warning: Excess function parameter 'wq' description in 'drmm_alloc_workqueue'
>> drivers/gpu/drm/drm_managed.c:374: warning: Function parameter or struct member 'fmt' not described in 'drmm_alloc_ordered_workqueue'
>> drivers/gpu/drm/drm_managed.c:374: warning: Function parameter or struct member 'flags' not described in 'drmm_alloc_ordered_workqueue'
>> drivers/gpu/drm/drm_managed.c:374: warning: Excess function parameter 'wq' description in 'drmm_alloc_ordered_workqueue'
vim +336 drivers/gpu/drm/drm_managed.c
320
321 /**
322 * drmm_alloc_workqueue - &drm_device-managed alloc_workqueue()
323 * @dev: DRM device
324 * @wq: workqueue to be allocated
325 *
326 * Returns:
327 * Valid pointer on success, NULL on error.
328 *
329 * This is a &drm_device-managed version of alloc_workqueue().
330 * The initialized lock is automatically destroyed on the final
331 * drm_dev_put().
332 */
333 struct workqueue_struct *drmm_alloc_workqueue(struct drm_device *dev,
334 const char *fmt, unsigned int flags,
335 int max_active, ...)
> 336 {
337 struct workqueue_struct *wq;
338 va_list args;
339 int ret;
340
341 va_start(args, max_active);
342 wq = alloc_workqueue(fmt, flags, max_active, args);
343 va_end(args);
344
345 if (!wq)
346 return NULL;
347
348 ret = drmm_add_action_or_reset(dev, drmm_destroy_workqueue, wq);
349 if (ret) {
350 destroy_workqueue(wq);
351 return NULL;
352 }
353
354 return wq;
355 }
356 EXPORT_SYMBOL(drmm_alloc_workqueue);
357
358 /**
359 * drmm_alloc_ordered_workqueue - &drm_device-managed
360 * alloc_ordered_workqueue()
361 * @dev: DRM device
362 * @wq: workqueue to be allocated
363 *
364 * Returns:
365 * Valid pointer on success, NULL on error.
366 *
367 * This is a &drm_device-managed version of alloc_ordered_workqueue().
368 * The initialized lock is automatically destroyed on the final
369 * drm_dev_put().
370 */
371 struct workqueue_struct *drmm_alloc_ordered_workqueue(struct drm_device *dev,
372 const char *fmt,
373 unsigned int flags, ...)
> 374 {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-03-15 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 14:50 [PATCH 0/2] drm: Add DRM managed workqueues Jeffrey Hugo
2024-03-15 14:50 ` [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue() Jeffrey Hugo
2024-03-15 20:51 ` kernel test robot [this message]
2024-03-15 14:50 ` [PATCH 2/2] accel/qaic: Use drmm_alloc_workqueue() Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403160449.IaCY0Cl5-lkp@intel.com \
--to=lkp@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-arm-msm@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ogabbay@kernel.org \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox