From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B2614831D for ; Wed, 3 Apr 2024 13:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712152225; cv=none; b=MJgqZ4kvpTJdHcOH6rPIzNrAPsyCKeAZi9v3AA9UkCJQDE+qVl5Iyyp1iJNLt5WT5UFs4WC3Iync1oGlWZg48H22gX5Myzk9wMXGVFf7qKoDY0z/LRbwjqdoFV8LeVAbYb4f8OuxLQdxei8Tj7bI7CSGtfs0AtPAZaZ/VolXxok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712152225; c=relaxed/simple; bh=X2XAS/oTqinlQY0bqWZ9HdUjhcK3j05vJH/5bNcOweY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IImdVS1FG+4u60a4zjX4MZ35gFy9NUX5TLcTdaxnP3EvEDwI1fts0fSP9UOtyHl1ecoQ122KOf5IJfrxx7mC5lpOl3dp9dUh6m7T9DFM7SjDnFHxiar0Cw8blikvrmqxPeTNFvhe+lgmBT2zFfOfQMriERLQoqy71Yo2qicL7Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CfbCHv/6; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CfbCHv/6" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5ce9555d42eso4187309a12.2 for ; Wed, 03 Apr 2024 06:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712152223; x=1712757023; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=f7pIzWrkcLxbGwLKhe5BWqkH4QaoGIyBQXlY1niD1ok=; b=CfbCHv/6SIBCP1W72SXIpI4tjNL00nPcURc0KlN7pXRYdfRnQrWcBTC0ARABICVeUQ DJuDL7aC7W6+KpB95X5mGEBTy84QWkRzIoYBEygT3LK5k/GLKYf5/EYQ561R3Px3Vu+G 5acaV4S/9j1d3Z2IP+xGbUmqVLds3dt3XLN9GnWwchtdQFPAQFkZhkzwqmpRpK9GWQw/ BjqdIy7lkvwxwl5uhI3hCCdIq1uHDpM+YYTBsY555YFKhYZ8UJI6UjiDIPFCAY1GZbly Ij/KfL0GviUiDC4ZgxuE8YYRQ1TTQkJe/2Dc503l5PjJC9rHc9TExb7TmVuLAMJ6a2CN N4cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712152223; x=1712757023; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7pIzWrkcLxbGwLKhe5BWqkH4QaoGIyBQXlY1niD1ok=; b=EcjADjNEnCi/JK5EJEYyjRR/eQiMv1qK+KziuOa2dCsNjrgI1xHJf1bVFUxkVU8tjK SvwcOF5GOM70x0Yt5LKMw5vWlzByYoGb+SZnF03Nybr7bn/NBqla6d6yf1923UnFPj2s kODeyVhAla5m8x0bZjII+k/e05Vgpktx0sw2EZ75+DG9vqwlfmBYVR0H0a2XL3hjQL5g 9EDC7zSc9OceRDI/YA5pIt4Uad5baTn4JOTX114VwL3PQG80Ovy98hmPbJyU2ljqm1P6 SXy4ypg8TMfa9B8L33PvylsBIkbe7nPGqaZcWTrWBJRn60EJucpZEfX92bC+iar+S65g zT0Q== X-Forwarded-Encrypted: i=1; AJvYcCX24zeQ1Db6nJ1rAokHaL94H/XMK5NNgDG9GHzJYK0qYL+++gIbI0K9KISnxaJLBrQUpkK8rIpobMXdYSFEEFsq6lRB5NbI6dopLlX0AQ== X-Gm-Message-State: AOJu0YzjBg103XGuU4Dwwnq37NnsefnifHF8JDPweZlruNU6ySZFbvM7 PnSWVSK4esGYmstOBVWBReUOkorNB/Ait1UySp/w53j1ce1PvgBOdFbZqLAppw== X-Google-Smtp-Source: AGHT+IFDdfRiUaNJoLcOr55g0unal8pZiJ3WGx9PpUBA19tgVAi/tYPRzvUz9AfJy4wzh0i9HRnXeA== X-Received: by 2002:a17:90a:4b8e:b0:2a2:6e60:b53c with SMTP id i14-20020a17090a4b8e00b002a26e60b53cmr3886528pjh.20.1712152222504; Wed, 03 Apr 2024 06:50:22 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id m10-20020a17090a34ca00b0029b9954a02asm2196137pjf.0.2024.04.03.06.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 06:50:22 -0700 (PDT) Date: Wed, 3 Apr 2024 19:20:15 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8996: Add missing UFS host controller reset Message-ID: <20240403135015.GN25309@thinkpad> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> <20240129-ufs-core-reset-fix-v1-3-7ac628aa735f@linaro.org> <20240130065550.GF32821@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 02, 2024 at 10:25:32PM +0300, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 20:35, Bjorn Andersson wrote: > > > > On Fri, Feb 09, 2024 at 10:16:25PM +0200, Dmitry Baryshkov wrote: > > > On Tue, 30 Jan 2024 at 08:55, Manivannan Sadhasivam > > > wrote: > > > > > > > > On Mon, Jan 29, 2024 at 11:44:15AM +0200, Dmitry Baryshkov wrote: > > > > > On Mon, 29 Jan 2024 at 09:55, Manivannan Sadhasivam > > > > > wrote: > > > > > > > > > > > > UFS host controller reset is required for the drivers to properly reset the > > > > > > controller. Hence, add it. > > > > > > > > > > > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > > > > > > > I think I had issues previously when I attempted to reset the > > > > > controller, but it might be because of the incomplete clocks > > > > > programming. Let met check whether it works first. > > > > > > > > > > > > > Sure. Please let me know. > > > > > > With the clocking fixes in place (I'll send them in a few minutes) and > > > with this patch the UFS breaks in the following way: > > > > > > > Was this further reviewed/investigated? What would you like me to do > > with this patch? > > I'd say, hold until we can understand what is going on. > > Mani, If you have any ideas what can be causing the issue, I'm open to > testing any ideas or any patches from your side. > Judging that the UFS breaks after toggling the reset, we might be > missing some setup steps. > I've bombarded the Qcom UFS team with too many questions, but didn't get answer for all of them. And this is one of those questions. Let me try to dig further and come back. - Mani -- மணிவண்ணன் சதாசிவம்