Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Tony Lindgren" <tony@atomide.com>,
	linux-arm-msm@vger.kernel.org,
	"Johan Hovold" <johan+linaro@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Yicong Yang" <yangyicong@hisilicon.com>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Guanbing Huang" <albanhuang@tencent.com>,
	"James Clark" <james.clark@arm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Vijaya Krishna Nivarthi" <quic_vnivarth@quicinc.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH 0/2] serial: Fix problems when serial transfer is happening at suspend time
Date: Thu, 23 May 2024 16:22:11 -0700	[thread overview]
Message-ID: <20240523232216.3148367-1-dianders@chromium.org> (raw)


This is a set of two patches that fix problems related to suspending
while a serial transfer is going on. The two patches are independent
from each other and can land in any order. The only thing tying them
together is that I used the same test to reproduce both of them.
Specifically, I could reproduce my problemes by logging in via an
agetty on the debug serial port (which was _not_ used for kernel
console) and running:
  cat /var/log/messages
...and then (via an SSH session) forcing a few suspend/resume cycles.

The first patch solves a problem that is probably more major. It was
introduced recently and has even shown up in stable trees.
Suspend/resume testing in ChromeOS test labs are hitting the problem
fixed by this patch. The fix hasn't been tested in labs, but when I
reproduced the problem locally I could see that the fix worked. IMO it
should land ASAP.

The second patch fixes an ancient problem that I only found because I
was trying to reproduce the first problem. Given how long it's been
around it's probably not urgent but it would be nice to get fixed.


Douglas Anderson (2):
  serial: port: Don't block system suspend even if bytes are left to
    xmit
  serial: qcom-geni: Fix qcom_geni_serial_stop_tx_fifo() while xfer

 drivers/tty/serial/qcom_geni_serial.c | 45 +++++++++++++++++++++++++--
 drivers/tty/serial/serial_port.c      | 10 ++++++
 2 files changed, 52 insertions(+), 3 deletions(-)

-- 
2.45.1.288.g0e0cd299f1-goog


             reply	other threads:[~2024-05-23 23:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 23:22 Douglas Anderson [this message]
2024-05-23 23:22 ` [PATCH 1/2] serial: port: Don't block system suspend even if bytes are left to xmit Douglas Anderson
2024-05-24  0:25   ` Stephen Boyd
2024-05-24 15:20     ` Doug Anderson
2024-05-27 17:54   ` Andy Shevchenko
2024-05-23 23:22 ` [PATCH 2/2] serial: qcom-geni: Fix qcom_geni_serial_stop_tx_fifo() while xfer Douglas Anderson
2024-05-24  0:38   ` Stephen Boyd
2024-05-25  0:17     ` Doug Anderson
2024-05-30 22:50       ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523232216.3148367-1-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=albanhuang@tencent.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.clark@arm.com \
    --cc=jirislaby@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=quic_vnivarth@quicinc.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox