Re: [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC

Manivannan Sadhasivam
2024-08-01T11:11:14Z

On Tue, Jul 30, 2024 at 03:24:31PM -0700, Elson Roy Serrao wrote:
> The Embedded USB Debugger (EUD) is a mini High-Speed USB on-chip hub to
> support the USB-based debug and trace capabilities on Qualcomm devices.
> The current implementation lacks in below aspects that are needed for
> proper EUD functionality.
>
> 1.) HS-Phy control: EUD being a HS hub needs HS-Phy support for it's
> operation. Hence EUD module should enable/disable HS-phy
> accordingly.
>
> 2.) Proper routing of USB role switch notifications: EUD hub is physically
> present in between the USB connector and the USB controller. So the
> usb role switch notifications originating from the connector should
> route through EUD. EUD also relies on role switch notifications to
> communicate with the USB, regarding EUD attach/detach events.
>
> This series aims at implementing the above aspects to enable EUD on
> Qualcomm sm8450 SoC.
>

For the open source community, EUD enablement means they will only get EUD ports
enumerated on the host and nothing else. There is no public info on how to use
EUD nor are there any tools to make use of it. So what is the purpose of
upstreaming it in the first place?

If the goal is to use EUD only by Qcom employees or customers who have signed
NDA, then you can just supply them the out-of-tree EUD patches and tools to work
with. There is absolutely no need to upstream the driver support.

So for this series and any other future EUD patches,

Nacked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

I'm really tempted to send a patch to remove the EUD driver altogether, but I'll
just wait for the response before doing so.

- Mani

--
மணிவண்ணன் சதாசிவம்