From: "Miquel Sabaté Solà" <mikisabate@gmail.com>
To: rafael@kernel.org
Cc: daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Miquel Sabaté Solà" <mikisabate@gmail.com>
Subject: [PATCH] cpuidle: Fix reference count on CPU node
Date: Tue, 17 Sep 2024 23:13:25 +0200 [thread overview]
Message-ID: <20240917211325.639765-1-mikisabate@gmail.com> (raw)
For the qcom-spm driver, an early return was not calling the proper
of_node_put call for a previously acquired device node.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
---
drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
index 1fc9968eae19..d3608f47d02b 100644
--- a/drivers/cpuidle/cpuidle-qcom-spm.c
+++ b/drivers/cpuidle/cpuidle-qcom-spm.c
@@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
return -ENODEV;
saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
- if (!saw_node)
+ if (!saw_node) {
+ of_node_put(cpu_node);
return -ENODEV;
+ }
pdev = of_find_device_by_node(saw_node);
of_node_put(saw_node);
--
2.46.0
next reply other threads:[~2024-09-17 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 21:13 Miquel Sabaté Solà [this message]
2024-10-01 20:13 ` [PATCH] cpuidle: Fix reference count on CPU node Miquel Sabaté Solà
2024-10-22 13:05 ` Miquel Sabaté Solà
2024-11-14 6:32 ` Miquel Sabaté Solà
2024-12-03 6:27 ` Miquel Sabaté Solà
2024-10-26 18:22 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917211325.639765-1-mikisabate@gmail.com \
--to=mikisabate@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox