From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>,
Kalle Valo <quic_kvalo@quicinc.com>,
Carl Vanderlip <quic_carlv@quicinc.com>,
Sujeev Dias <sdias@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie_table
Date: Sun, 6 Oct 2024 23:36:53 +0530 [thread overview]
Message-ID: <20241006180653.amrkwtlgjiggenny@thinkpad> (raw)
In-Reply-To: <20240207065136.18316-1-pchelkin@ispras.ru>
On Wed, Feb 07, 2024 at 09:51:36AM +0300, Fedor Pchelkin wrote:
> img_info->mhi_buf should be freed on error path in mhi_alloc_bhie_table().
> This error case is rare but still needs to be fixed.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/host/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index edc0ec5a0933..738dcd11b66f 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -357,6 +357,7 @@ int mhi_alloc_bhie_table(struct mhi_controller *mhi_cntrl,
> for (--i, --mhi_buf; i >= 0; i--, mhi_buf--)
> dma_free_coherent(mhi_cntrl->cntrl_dev, mhi_buf->len,
> mhi_buf->buf, mhi_buf->dma_addr);
> + kfree(img_info->mhi_buf);
>
> error_alloc_mhi_buf:
> kfree(img_info);
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2024-10-06 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 6:51 [PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie_table Fedor Pchelkin
2024-02-07 10:16 ` Greg Kroah-Hartman
2024-02-07 13:40 ` [PATCH v2] " Fedor Pchelkin
2024-02-07 18:09 ` Jeffrey Hugo
2024-10-03 11:34 ` Fedor Pchelkin
2024-10-06 18:05 ` [PATCH] " Manivannan Sadhasivam
2024-10-06 18:06 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241006180653.amrkwtlgjiggenny@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mhi@lists.linux.dev \
--cc=pchelkin@ispras.ru \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_kvalo@quicinc.com \
--cc=sdias@codeaurora.org \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox