From: Greg KH <gregkh@linuxfoundation.org>
To: Ekansh Gupta <quic_ekangupt@quicinc.com>
Cc: srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org,
quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org,
quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org,
arnd@arndb.de
Subject: Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request
Date: Mon, 7 Oct 2024 10:53:50 +0200 [thread overview]
Message-ID: <2024100729-overall-sugar-d3b8@gregkh> (raw)
In-Reply-To: <20241007084518.3649876-2-quic_ekangupt@quicinc.com>
On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote:
> +struct fastrpc_invoke_v2 {
> + struct fastrpc_invoke inv;
> + __u64 crc;
> + __u32 reserved[16];
I'm sure we have been over this before, but if you have a reserved
field, you HAVE to check that it is zero if you ever want to use it in
the future. As you did not check it, just remove it from this structure
as obviously it can never be used for anything.
Your internal review should have caught this, if not, please go fix it
AND get some internal review and signed-off-by before submitting this
series again.
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-07 8:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 8:45 [PATCH v1 0/4] Add invokeV2 to support new features Ekansh Gupta
2024-10-07 8:45 ` [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request Ekansh Gupta
2024-10-07 8:53 ` Greg KH [this message]
2024-10-10 5:25 ` Ekansh Gupta
2024-10-07 13:57 ` Dmitry Baryshkov
2025-01-23 5:46 ` Ekansh Gupta
2025-01-23 7:48 ` Dmitry Baryshkov
2025-01-23 9:49 ` Ekansh Gupta
2025-01-23 11:13 ` Dmitry Baryshkov
2025-01-23 12:04 ` Ekansh Gupta
2025-01-23 12:33 ` Dmitry Baryshkov
2025-01-24 4:19 ` Ekansh Gupta
2024-10-08 1:41 ` kernel test robot
2024-10-08 1:41 ` kernel test robot
2024-10-08 2:32 ` kernel test robot
2024-10-08 21:21 ` kernel test robot
2024-10-07 8:45 ` [PATCH v1 2/4] misc: fastrpc: Capture kernel and DSP performance counters Ekansh Gupta
2024-10-07 9:07 ` Greg KH
2024-10-07 8:45 ` [PATCH v1 3/4] misc: fastrpc: Modify context id calculation for poll mode Ekansh Gupta
2024-10-07 8:45 ` [PATCH v1 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2024-10-07 13:27 ` [PATCH v1 0/4] Add invokeV2 to support new features Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024100729-overall-sugar-d3b8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=quic_ekangupt@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).