From: Fritz Koenig <frkoenig@chromium.org>
To: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dikshita Agarwal <quic_dikshita@quicinc.com>
Cc: Nathan Hebert <nhebert@chromium.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Fritz Koenig <frkoenig@chromium.org>
Subject: [PATCH v4 0/2] media: venus: Add hierarchical h.264 controls
Date: Thu, 17 Oct 2024 13:04:29 -0700 [thread overview]
Message-ID: <20241017-submit-v4-0-d852bc7f7fdc@chromium.org> (raw)
v4:
- addressed feedback from Dikshita
- included reviewed by for patch 1
- Link to v3: https://lore.kernel.org/r/20240814-submit-v3-0-f7d05e3e8560@chromium.org
v3:
- dropped reordering patch
- updated cover letter
v2:
- cover letter
- testing methodology
- Signed-off-by
V4L2 has support for encoding with hierarchical frames using the
V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING* controls. This allows for
specifing frame references needed for temporal scalability. Encoding a
single stream with a single layer allows for the layer to be dropped and
the stream to be decoded without artifacts.
ChromeOS is planning to use this feature for the L1T2 web standard[1].
This allows video conferencing apps to encode once for a clients with
different performance/bandwidth capabilities. As the application is a
real time encoder only P frame support is added.
The ChromeOS test framework ("tast") was used to verify that no
regressions are present. This was done on SC7180 ("trogdor"). These
patches were also run on SC7280, but not with as an extensive test set.
Verification of the added controls was done with a bitstream analyser to
make sure that reference frame management is correct.
[1]: https://www.w3.org/TR/webrtc-svc/#L1T2*
Signed-off-by: Fritz Koenig <frkoenig@chromium.org>
---
Fritz Koenig (2):
media: venus: Helper function for dynamically updating bitrate
media: venus: Enable h.264 hierarchical coding
drivers/media/platform/qcom/venus/core.h | 4 +
drivers/media/platform/qcom/venus/venc.c | 73 +++++++++-----
drivers/media/platform/qcom/venus/venc_ctrls.c | 126 ++++++++++++++++++++++---
3 files changed, 165 insertions(+), 38 deletions(-)
---
base-commit: d07b43284ab356daf7ec5ae1858a16c1c7b6adab
change-id: 20240814-submit-05880a074377
Best regards,
--
Fritz Koenig <frkoenig@chromium.org>
next reply other threads:[~2024-10-17 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 20:04 Fritz Koenig [this message]
2024-10-17 20:04 ` [PATCH v4 1/2] media: venus: Helper function for dynamically updating bitrate Fritz Koenig
2024-10-18 4:50 ` Dikshita Agarwal
2024-10-17 20:04 ` [PATCH v4 2/2] media: venus: Enable h.264 hierarchical coding Fritz Koenig
2024-10-18 5:01 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017-submit-v4-0-d852bc7f7fdc@chromium.org \
--to=frkoenig@chromium.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nhebert@chromium.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox