Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Gabor Juhos <j4g8y7@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Gabor Juhos <j4g8y7@gmail.com>
Subject: [PATCH 2/5] clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config
Date: Mon, 21 Oct 2024 22:21:58 +0200	[thread overview]
Message-ID: <20241021-alpha-mode-cleanup-v1-2-55df8ed73645@gmail.com> (raw)
In-Reply-To: <20241021-alpha-mode-cleanup-v1-0-55df8ed73645@gmail.com>

Since neither 'alpha' nor 'alpha_hi' is defined in the configuration,
those will be initialized with zero values implicitly. By using zero
alpha values, the output rate of the PLL will be the same whether
alpha mode is enabled or not.

Remove the superfluous initialization of the 'alpha_en_mask' member
to make it clear that enabling alpha mode is not required to get the
desired output rate.

While at it, also add a comment to indicate the frequency the PLL
runs at with the current configuration.

No functional changes, the initial rate of the PLL is the same both
before and after the patch.

Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board).

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
 drivers/clk/qcom/apss-ipq-pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
index dec2a5019cc77bf60142a86453883e336afc860f..d6c1aea7e9e1e50a8d7561ce352feac4e76fb1e3 100644
--- a/drivers/clk/qcom/apss-ipq-pll.c
+++ b/drivers/clk/qcom/apss-ipq-pll.c
@@ -79,13 +79,13 @@ static const struct alpha_pll_config ipq5018_pll_config = {
 	.test_ctl_hi_val = 0x00400003,
 };
 
+/* 1.080 GHz configuration */
 static const struct alpha_pll_config ipq5332_pll_config = {
 	.l = 0x2d,
 	.config_ctl_val = 0x4001075b,
 	.main_output_mask = BIT(0),
 	.aux_output_mask = BIT(1),
 	.early_output_mask = BIT(3),
-	.alpha_en_mask = BIT(24),
 	.status_val = 0x3,
 	.status_mask = GENMASK(10, 8),
 	.lock_det = BIT(2),

-- 
2.47.0


  parent reply	other threads:[~2024-10-21 20:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 20:21 [PATCH 0/5] clk: qcom: remove superfluous alpha settings from PLL configs Gabor Juhos
2024-10-21 20:21 ` [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config Gabor Juhos
2024-10-25  6:24   ` Dmitry Baryshkov
2024-10-25 20:05     ` Gabor Juhos
2024-10-26 18:55       ` Dmitry Baryshkov
2024-10-28 11:50         ` Gabor Juhos
2024-10-21 20:21 ` Gabor Juhos [this message]
2024-10-26 19:00   ` [PATCH 2/5] clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 " Dmitry Baryshkov
2024-10-21 20:21 ` [PATCH 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config Gabor Juhos
2024-10-25  6:18   ` Dmitry Baryshkov
2024-10-25 20:06     ` Gabor Juhos
2024-10-26 18:58       ` Dmitry Baryshkov
2024-10-21 20:22 ` [PATCH 4/5] clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config Gabor Juhos
2024-10-25  6:20   ` Dmitry Baryshkov
2024-10-21 20:22 ` [PATCH 5/5] clk: qcom: dispcc-sm6115: " Gabor Juhos
2024-10-25  6:20   ` Dmitry Baryshkov
2024-10-26 19:00     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241021-alpha-mode-cleanup-v1-2-55df8ed73645@gmail.com \
    --to=j4g8y7@gmail.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox