From: Rob Herring <robh@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Varadarajan Narayanan <quic_varada@quicinc.com>,
vkoul@kernel.org, kishon@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
andersson@kernel.org, konradybcio@kernel.org,
dmitry.baryshkov@linaro.org, mantas@8devices.com,
quic_rohiagar@quicinc.com, quic_kriskura@quicinc.com,
manivannan.sadhasivam@linaro.org, abel.vesa@linaro.org,
quic_kbajaj@quicinc.com, quic_wcheng@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: qcom: Add USB controller and phy nodes for IPQ5424
Date: Wed, 13 Nov 2024 12:11:38 -0600 [thread overview]
Message-ID: <20241113181138.GA1011553-robh@kernel.org> (raw)
In-Reply-To: <ZzSYU61pmFTcPf5_@hovoldconsulting.com>
On Wed, Nov 13, 2024 at 01:15:15PM +0100, Johan Hovold wrote:
> On Wed, Nov 13, 2024 at 12:53:16PM +0530, Varadarajan Narayanan wrote:
>
> > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > @@ -16,12 +16,71 @@ / {
> > aliases {
> > serial0 = &uart1;
> > };
> > +
> > + regulator_fixed_3p3: s3300 {
>
> Fixed regulator nodes should have a "regulator-" prefix in their name.
Specifically, regulator-<voltage> is preferred. So "regulator-3300000"
Not enforced because there are some exceptions.
Rob
next prev parent reply other threads:[~2024-11-13 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 7:23 [PATCH v2 0/6] Enable IPQ5424 USB support Varadarajan Narayanan
2024-11-13 7:23 ` [PATCH v2 1/6] dt-bindings: phy: qcom,qusb2: Document IPQ5424 compatible Varadarajan Narayanan
2024-11-13 7:23 ` [PATCH v2 2/6] phy: qcom-qusb2: add QUSB2 support for IPQ5424 Varadarajan Narayanan
2024-11-13 14:44 ` Dmitry Baryshkov
2024-11-13 7:23 ` [PATCH v2 3/6] dt-bindings: phy: qcom,qmp-usb: Add IPQ5424 USB3 PHY Varadarajan Narayanan
2024-11-13 7:23 ` [PATCH v2 4/6] phy: qcom: qmp: Enable IPQ5424 support Varadarajan Narayanan
2024-11-13 7:23 ` [PATCH v2 5/6] dt-bindings: usb: qcom,dwc3: Add IPQ5424 to USB DWC3 bindings Varadarajan Narayanan
2024-11-13 7:23 ` [PATCH v2 6/6] arm64: dts: qcom: Add USB controller and phy nodes for IPQ5424 Varadarajan Narayanan
2024-11-13 12:15 ` Johan Hovold
2024-11-13 18:11 ` Rob Herring [this message]
2024-11-14 7:48 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113181138.GA1011553-robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mantas@8devices.com \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox