From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D3518FDD8; Mon, 18 Nov 2024 09:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731923058; cv=none; b=S8VLu7XcIOu3WtkHEnPisRpfx0dhNR2b9a0N0PKUKqHVnsFyzv8T+wWzFSdqhPlcGtnTbD0UUIWgoNCRWv90Nwz5ltDzh6lW6WyTg/7m636n+yyv5lDS7/yOf6da3QFq+cm0pdMbGm51V7G/t5ZJhDst80K9RCJBo9b4elkbJgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731923058; c=relaxed/simple; bh=xkGDIVTsjYl2daXkQELzdBVqI1NqFFTGHwZ9oH4jtg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kt6EBlejTwLl19wCdDYl4ThmwhLILheDPospJg4RSp41cC2tVdDXoH+p0+xCRCAhCLZ3k9XCifoU8bIItveyzlrHCwq8LgG5jXJdP+tjjj/Mhbh/7zlxvsMEse1pPLLK2+xi/aaH19PxkIlGkiTox6JtEHaQQoaRwe6b9Neu/6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CVkichzM; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CVkichzM" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A5D385B3; Mon, 18 Nov 2024 10:43:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731923031; bh=xkGDIVTsjYl2daXkQELzdBVqI1NqFFTGHwZ9oH4jtg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CVkichzMiV3e0BGfVJwqOmN7JW9UFAdFwYknwJi9NFaABsS3vVTKVteKogEj7B2Uy bR5k0lZfhuetEpIa/WAnnHYEGgmjcIm+jmVePtfT5OURVmlbegALQOou8quBwgZCgj 9q65vqEOFKvCU5olGrCy7664A1rYY3kWESwRkeu8= Date: Mon, 18 Nov 2024 11:43:58 +0200 From: Laurent Pinchart To: Jani Nikula Cc: Dmitry Baryshkov , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Karol Herbst , Lyude Paul , Danilo Krummrich , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Xinhui Pan , Alain Volmat , Raphael Gallais-Pou , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Peter Senna Tschudin , Ian Ray , Martyn Welch , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Stefan Agner , Alison Wang , Patrik Jakobsson , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Dave Airlie , Gerd Hoffmann , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Gurchetan Singh , Chia-I Wu , Zack Rusin , Broadcom internal kernel review list , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode Message-ID: <20241118094358.GK31681@pendragon.ideasonboard.com> References: <20241115-drm-connector-mode-valid-const-v1-0-b1b523156f71@linaro.org> <20241115-drm-connector-mode-valid-const-v1-1-b1b523156f71@linaro.org> <20241117205426.GE12409@pendragon.ideasonboard.com> <20241117233250.GK12409@pendragon.ideasonboard.com> <87plms51w4.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87plms51w4.fsf@intel.com> On Mon, Nov 18, 2024 at 11:26:03AM +0200, Jani Nikula wrote: > On Mon, 18 Nov 2024, Dmitry Baryshkov wrote: > > On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart wrote: > >> On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > >> > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > >> > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > >> > > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > >> > > > accept const struct drm_display_mode argument. Change the mode_valid > >> > > > callback of drm_encoder_slave to also accept const argument. > >> > > > > >> > > > Signed-off-by: Dmitry Baryshkov > >> > > > >> > > Reviewed-by: Laurent Pinchart > >> > > > >> > > On a side note, there's only two I2C slave encoder drivers left... I > >> > > wonder if we could so something about them. The ch7006 and sil164 > >> > > drivers seem to be used by nouveau only, could they be moved to > >> > > drivers/gpu/drm/nouveau/ ? We would move the whole drm_encoder_slave > >> > > implementation there too, and leave it to die (or get taken out of limbo > >> > > and fixed) with dispnv04. > >> > > >> > Or it might be better to switch to drm_bridge. Currently we also have > >> > sil164 (sub)drivers in ast and i915 drivers. I don't know if there is > >> > any common code to share or not. If there is some, it might be nice to > >> > use common framework. > >> > >> That would require porting nouveau and i915 to drm_bridge. As much as > >> I'd love to see that happening, I won't hold my breath. > > > > Me neither. Probably moving those two and drm_encoder_slave to nouveau > > is really the best course for now. > > Granted, the dvo part of i915 is ugly, but it's also only relevant for > the oldest hardware i915 supports. Like 20 years old. Not sure there's > much return on investment in big refactoring, more risk that it breaks > without nobody noticing. Just let it be in i915? That's my opinion too. The gain is not worth the risk. -- Regards, Laurent Pinchart