From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100
Date: Tue, 19 Nov 2024 11:13:15 -0600 [thread overview]
Message-ID: <20241119171315.GA1805024-robh@kernel.org> (raw)
In-Reply-To: <20241116-topic-x1e_usb2_bindings-v1-1-dde2d63f428f@oss.qualcomm.com>
On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> X1 has multiple DWC3 hosts, including one that's USB2, which naturally
> means it doesn't have a SuperSpeed interrupt. Make it optional to fix
> warnings such as:
>
> usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
That's a good start, but what about all the other warnings for usb
interrupts?:
13 usb@f92f8800: 'interrupt-names' is a required property
11 usb@76f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
11 usb@6af8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short
11 usb@6af8800: interrupt-names:1: 'qusb2_phy' was expected
11 usb@6af8800: interrupt-names:0: 'pwr_event' was expected
11 usb@6af8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short
9 usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
7 usb@c2f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
5 usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
5 usb@8af8800: interrupt-names: ['pwr_event'] is too short
4 usb@8af8800: interrupts: [[0, 62, 4]] is too short
4 usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-11-19 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 11:17 [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100 Konrad Dybcio
2024-11-19 17:13 ` Rob Herring [this message]
2024-11-22 2:15 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119171315.GA1805024-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox