From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F271A0BFD for ; Thu, 28 Nov 2024 13:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732800284; cv=none; b=VtlcTLahSzdJqdhsIFHxbqswO6MfcZ9ZCRUJfwvhf4azwUBZBX7EaCmh5VmjWAA4/g3kAchfvSYa01OtLS/sqU2dSkgqT4PO5Ytp5uQSa8EoDUd0CEKMBAkf2Ep6bPYVrMyJFeOPCoqN687OShJXhPXTGz9ZQIsHdhfGeHKrA18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732800284; c=relaxed/simple; bh=EiQXqUxIixcM/WIqsE6yZhdRc2YDwoBwf0kwdTIOQLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e8JTIziuJSAHQCw6+0OQt7fPWC0mnmkuCbJPYvUa2PA9qnExjFWtLUwBpfqYDMbOAP4shDpc+f//SogcmghFHAwQX+lm1kwWuKhjFQ+tGzxRTygqcOGeqJxO4hyUD837JfTGaTFnDGn2w88owhdV7azktY9kcmhyhtBH0Vx/la4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XFOLGqaM; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XFOLGqaM" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2ee46851b5eso96902a91.1 for ; Thu, 28 Nov 2024 05:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732800281; x=1733405081; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=y/S3V26ZtpsH53gJ+nZdjF8Q8MrpcidP1Hfwlg06frY=; b=XFOLGqaMrAgAs/EAVX2uU3saBP7riM6VcpUEb199Xd5CuFEEl11dLi29jPhaPv4cVL 7k4944aDxi19ky2rjhNM5Fcq9BJ9072A5+exeau8Qbwd8bAyO8VHmHzEdBG8JjvjlUlB vqp6JKmQsxt3c0siN9cywgnGGYEo/xlCcYrf4zPactVn9tBwJy5yM99L0D+Ssv5y9Kd4 pXTmynrq0T7g6iSJT0oTOXJ5M+bUi+tPNQpTsXDzbn0e8633KWXvjxjVe9jwJoMHUJ5v HWglMhN0Hq3+rg2NhoI2Rwe6asgpmeZxA1HS4Zm2fg1rZXXhDvAsjbUwH08zL3kLTFda Uw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732800281; x=1733405081; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y/S3V26ZtpsH53gJ+nZdjF8Q8MrpcidP1Hfwlg06frY=; b=UFvkjAzinl8aYFPQQcHsMMgEb7WQ5eRykjYLAvwcl+f65aSVPF2/f242jQ7LAPT7wf A1BBUSbQPUF+4XWsfR2HHge64OPQbt48yYpMcECIEEx3fPktjc5RJbUTuB4XneQVMBPF LqDhNamDghx89TTvHgBFhknub1kXngTzyX5t5ckUdyf/9F71vn9upWWJOcq59aXU200t Zo0j47gLrmUUsOWD2375UM9Aennwl2gXpEY6ZOqUegiJCUnXSQToFYAzMR+Too+tFOpu hekva7LPtCgNj5BWgiwJsf4IAcrCu2GD1BjwDLaDKaJk/rWmLheZWxGOhiQEmCi8be3m 187w== X-Forwarded-Encrypted: i=1; AJvYcCUJqW8Z0kwAYryS+sqh9ARLhcqQQjO2oDmAytJmsESB1iOk5liiDSk8I8gLEGeg5MZuJOFLoGYBT+H0lbVb@vger.kernel.org X-Gm-Message-State: AOJu0Yy+iyx4he5oZSsngTRK6mgheNj97jXVykLHtNooWEtM5g2FHIAm t/9J2cYd+QmOBiAKk3xGhrKXlJyelqdubV+z8ziTJ2v87OgCPVS2C0O9wdQLXw== X-Gm-Gg: ASbGncsoAuO1X+Qi0T8HU5unV/UiOlCcmrRG5XWVrZJj1eAmtlKz9neNIupXw26M/cL dFcvVVt9TVDHWDe/EOKaJHijDebP+sk9H4O+Ugp6P9NDktnA7S2Roz16Q6cXh8Umth6VuN5TdS5 4v08t36JQONUWgBihAxzJ7nKnMlCXMWJ9c5tmB4iV9x4FDeIz9DyD/xZKdMgnmZvA+GOc8mh2Ga DMzALUOSZKPyo2dpmY+xWc1EVILQ4z5bCd2sKBltROU0ElL4IzEgM7AUvl8 X-Google-Smtp-Source: AGHT+IHhjHrwJN/0a3LoxP1T5UBrL/PpHDbGZKXCNWeqjqOsCu7VZTYvWW+l6+4/H4GWb3YSpNc2tw== X-Received: by 2002:a17:90b:388a:b0:2ea:adaa:1a42 with SMTP id 98e67ed59e1d1-2ee08ecc3f2mr11264448a91.16.1732800281343; Thu, 28 Nov 2024 05:24:41 -0800 (PST) Received: from thinkpad ([117.213.97.61]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee2aff1f34sm1408085a91.5.2024.11.28.05.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 05:24:40 -0800 (PST) Date: Thu, 28 Nov 2024 18:54:32 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Krishna Chaitanya Chundru , andersson@kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615 Message-ID: <20241128132432.fxvmjeluagignbph@thinkpad> References: <20241112-qps615_pwr-v3-0-29a1e98aa2b0@quicinc.com> <20241112-qps615_pwr-v3-1-29a1e98aa2b0@quicinc.com> <42425b92-6e0d-a77b-8733-e50614bcb3a8@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 26, 2024 at 07:58:16AM +0100, Krzysztof Kozlowski wrote: > On 26/11/2024 07:50, Krishna Chaitanya Chundru wrote: > > > > > > On 11/25/2024 1:10 PM, Krzysztof Kozlowski wrote: > >> On 24/11/2024 02:41, Krishna Chaitanya Chundru wrote: > >>>> ... > >>>> > >>>>> + qps615,axi-clk-freq-hz: > >>>> > >>>> That's a downstream code you send us. > >>>> > >>>> Anyway, why assigned clock rates do not work for you? You are > >>>> re-implementing legacy property now under different name :/ > >>>> > >>>> The assigned clock rates comes in to the picture when we are > >>>> using clock > >>> framework to control the clocks. For this switch there are no > >>> clocks needs to be control, the moment we power on the switch > >>> clocks are enabled by default. This switch provides a mechanism to > >>> control the frequency using i2c. And switch supports only two > >>> frequencies i.e > >> > >> > >> frequency of what, since there are no clocks? > >> > > The axi clock frequency internal to the switch, host can't control > > the enablement of the clocks it can control only the frequency. > > > > we already had a discussion on this on v2[1], and we taught you agreed > > on this property. > > > > [1] > > https://lore.kernel.org/netdev/d1af1eac-f9bd-7a8e-586b-5c2a76445145@codeaurora.org/T/#m3d5864c758f2e05fa15ba522aad6a37e3417bd9f > > > > This points something else. I diged v2 and found many unanswered > questions and unfinished discussion: > The conversation is here: https://lore.kernel.org/linux-arm-msm/20240823094028.7xul4eoiexey5xjm@thinkpad/ But there was no explicit agreement on the usage of 'qps615,axi-clk-freq-hz'. If describing the PCI device's internal clock frequency is not applicable, then I'd recommend to change the clock rate in the driver itself based on the number of DSPs enabled (or based on other configuration). - Mani -- மணிவண்ணன் சதாசிவம்