Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Akhil P Oommen <quic_akhilpo@quicinc.com>
To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Akhil P Oommen <quic_akhilpo@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Maya Matuszczyk <maccraft123mc@gmail.com>
Cc: <linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: [PATCH v4 4/7] drm/msm/adreno: Add module param to disable ACD
Date: Thu, 9 Jan 2025 02:10:00 +0530	[thread overview]
Message-ID: <20250109-gpu-acd-v4-4-08a5efaf4a23@quicinc.com> (raw)
In-Reply-To: <20250109-gpu-acd-v4-0-08a5efaf4a23@quicinc.com>

Add a module param to disable ACD which will help to quickly rule it
out for any GPU issues.

Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
---
 drivers/gpu/drm/msm/adreno/a6xx_gmu.c      | 7 +++++++
 drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 1f213a0fc61b..ce08eed572c8 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -1475,6 +1475,13 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
 	struct adreno_gpu *adreno_gpu = &a6xx_gpu->base;
 	struct msm_gpu *gpu = &adreno_gpu->base;
 	int ret, i, cmd_idx = 0;
+	extern bool disable_acd;
+
+	/* Skip ACD probe if requested via module param */
+	if (disable_acd) {
+		DRM_DEV_ERROR(gmu->dev, "Skipping GPU ACD probe\n");
+		return 0;
+	}
 
 	cmd->version = 1;
 	cmd->stride = 1;
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 236b25c094cd..f4552b8c6767 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -24,6 +24,10 @@ int enable_preemption = -1;
 MODULE_PARM_DESC(enable_preemption, "Enable preemption (A7xx only) (1=on , 0=disable, -1=auto (default))");
 module_param(enable_preemption, int, 0600);
 
+bool disable_acd;
+MODULE_PARM_DESC(disable_acd, "Forcefully disable GPU ACD");
+module_param_unsafe(disable_acd, bool, 0600);
+
 extern const struct adreno_gpulist a2xx_gpulist;
 extern const struct adreno_gpulist a3xx_gpulist;
 extern const struct adreno_gpulist a4xx_gpulist;

-- 
2.45.2


  parent reply	other threads:[~2025-01-08 20:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 20:39 [PATCH v4 0/7] Support for GPU ACD feature on Adreno X1-85 Akhil P Oommen
2025-01-08 20:39 ` [PATCH v4 1/7] drm/msm/adreno: Add support for ACD Akhil P Oommen
2025-01-09  7:53   ` neil.armstrong
2025-01-08 20:39 ` [PATCH v4 2/7] drm/msm/a6xx: Increase HFI response timeout Akhil P Oommen
2025-01-09  7:54   ` neil.armstrong
2025-01-09 11:28     ` Akhil P Oommen
2025-01-08 20:39 ` [PATCH v4 3/7] drm/msm: a6x: Rework qmp_get() error handling Akhil P Oommen
2025-01-08 20:40 ` Akhil P Oommen [this message]
2025-01-09 13:18   ` [PATCH v4 4/7] drm/msm/adreno: Add module param to disable ACD Konrad Dybcio
2025-01-08 20:40 ` [PATCH v4 5/7] dt-bindings: opp: Add v2-qcom-adreno vendor bindings Akhil P Oommen
2025-01-08 21:23   ` Rob Herring (Arm)
2025-01-09  8:06   ` Krzysztof Kozlowski
2025-01-09 13:13     ` Akhil P Oommen
2025-01-09 16:15       ` Krzysztof Kozlowski
2025-01-09 13:11   ` kernel test robot
2025-04-19 14:33   ` Akhil P Oommen
2025-04-21  8:25     ` Dmitry Baryshkov
2025-01-08 20:40 ` [PATCH v4 6/7] arm64: dts: qcom: x1e80100: Add ACD levels for GPU Akhil P Oommen
2025-01-09 13:19   ` Konrad Dybcio
2025-01-08 20:40 ` [PATCH v4 7/7] arm64: dts: qcom: x1e80100: Add OPPs up to Turbo L3 " Akhil P Oommen
2025-01-08 21:14 ` [PATCH v4 0/7] Support for GPU ACD feature on Adreno X1-85 Maya Matuszczyk
2025-03-18 13:12 ` Anthony Ruhier
2025-04-09 15:08   ` Konrad Dybcio
2025-04-10 15:51     ` Anthony Ruhier
2025-04-10 19:31       ` Dmitry Baryshkov
2025-04-10 16:00 ` Anthony Ruhier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109-gpu-acd-v4-4-08a5efaf4a23@quicinc.com \
    --to=quic_akhilpo@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maccraft123mc@gmail.com \
    --cc=marijn.suijten@somainline.org \
    --cc=nm@ti.com \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox