From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, Joel Stanley <joel@jms.id.au>,
<linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
<20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com>
Subject: [PATCH 1/2] media: iris: represent dma_mask in more readable form
Date: Thu, 9 Jan 2025 16:56:40 +0530 [thread overview]
Message-ID: <20250109-iris-driver-fixes-v1-1-789a0f5dd7ee@quicinc.com> (raw)
In-Reply-To: <20250109-iris-driver-fixes-v1-0-789a0f5dd7ee@quicinc.com>
Update the value of dma mask from GENMASK(31, 29) - 1 to 0xe0000000-1 to
make it easier to understand and keep it consistent.
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
---
drivers/media/platform/qcom/iris/iris_platform_sm8250.c | 3 ++-
drivers/media/platform/qcom/iris/iris_platform_sm8550.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8250.c b/drivers/media/platform/qcom/iris/iris_platform_sm8250.c
index 9ef2fcc1a0fd..b14b1c5d632c 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_sm8250.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_sm8250.c
@@ -125,7 +125,8 @@ struct iris_platform_data sm8250_data = {
.opp_pd_tbl_size = ARRAY_SIZE(sm8250_opp_pd_table),
.clk_tbl = sm8250_clk_table,
.clk_tbl_size = ARRAY_SIZE(sm8250_clk_table),
- .dma_mask = GENMASK(31, 29) - 1,
+ /* Upper bound of DMA address range */
+ .dma_mask = 0xe0000000 - 1,
.fwname = "qcom/vpu-1.0/venus.mbn",
.pas_id = IRIS_PAS_ID,
.inst_caps = &platform_inst_cap_sm8250,
diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
index ad945489126e..35d278996c43 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
@@ -232,7 +232,8 @@ struct iris_platform_data sm8550_data = {
.opp_pd_tbl_size = ARRAY_SIZE(sm8550_opp_pd_table),
.clk_tbl = sm8550_clk_table,
.clk_tbl_size = ARRAY_SIZE(sm8550_clk_table),
- .dma_mask = GENMASK(31, 29) - 1,
+ /* Upper bound of DMA address range */
+ .dma_mask = 0xe0000000 - 1,
.fwname = "qcom/vpu/vpu30_p4.mbn",
.pas_id = IRIS_PAS_ID,
.inst_caps = &platform_inst_cap_sm8550,
--
2.34.1
next prev parent reply other threads:[~2025-01-09 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 11:26 [PATCH 0/2] media: iris: fix memory leak and improve driver Dikshita Agarwal
2025-01-09 11:26 ` Dikshita Agarwal [this message]
2025-01-09 11:26 ` [PATCH 2/2] media: iris: fix memory leak while freeing queue memory Dikshita Agarwal
2025-01-09 12:47 ` [PATCH 0/2] media: iris: fix memory leak and improve driver Hans Verkuil
2025-01-09 13:21 ` Hans Verkuil
2025-01-09 15:17 ` Johan Hovold
2025-01-10 17:32 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109-iris-driver-fixes-v1-1-789a0f5dd7ee@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com \
--cc=hverkuil@xs4all.nl \
--cc=joel@jms.id.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stefan.schmidt@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox