From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH v6 6/6] media: venus: vdec: Make the range of us_per_frame explicit
Date: Sat, 11 Jan 2025 09:55:19 +0000 [thread overview]
Message-ID: <20250111-fix-cocci-v6-6-1aa7842006cc@chromium.org> (raw)
In-Reply-To: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org>
Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame.
There is no need to do a 64 bit division here.
Also, the driver only works with whole fps.
Found by cocci:
drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/qcom/venus/vdec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index e160a5508154..aa9ba38186b8 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -484,8 +484,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
do_div(us_per_frame, timeperframe->denominator);
us_per_frame = max(USEC_PER_SEC, us_per_frame);
- fps = (u64)USEC_PER_SEC;
- do_div(fps, us_per_frame);
+ fps = USEC_PER_SEC / (u32)us_per_frame;
fps = min(VENUS_MAX_FPS, fps);
inst->fps = fps;
--
2.47.1.613.gc27f4b7a9f-goog
next prev parent reply other threads:[~2025-01-11 9:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 9:55 [PATCH v6 0/6] media: Fix coccinelle warning/errors Ricardo Ribalda
2025-01-11 9:55 ` [PATCH v6 1/6] media: dvb-frontends: tda10048: Make the range of z explicit Ricardo Ribalda
2025-01-11 9:55 ` [PATCH v6 2/6] media: venus: vdec: Clamp parm smaller than 1fps and bigger than 240 Ricardo Ribalda
2025-01-15 1:14 ` Bryan O'Donoghue
2025-06-16 11:04 ` Vikash Garodia
2025-06-16 11:44 ` Ricardo Ribalda
2025-06-16 15:44 ` Vikash Garodia
2025-01-11 9:55 ` [PATCH v6 3/6] media: venus: venc: " Ricardo Ribalda
2025-06-16 11:12 ` Vikash Garodia
2025-01-11 9:55 ` [PATCH v6 4/6] media: venus: Remove timeperframe from inst Ricardo Ribalda
2025-06-16 11:24 ` Vikash Garodia
2025-01-11 9:55 ` [PATCH v6 5/6] media: venus: venc: Make the range of us_per_frame explicit Ricardo Ribalda
2025-06-16 11:31 ` Vikash Garodia
2025-01-11 9:55 ` Ricardo Ribalda [this message]
2025-01-15 1:17 ` [PATCH v6 6/6] media: venus: vdec: " Bryan O'Donoghue
2025-06-16 11:32 ` Vikash Garodia
2025-06-12 9:22 ` [PATCH v6 0/6] media: Fix coccinelle warning/errors Bryan O'Donoghue
2025-06-16 11:34 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250111-fix-cocci-v6-6-1aa7842006cc@chromium.org \
--to=ribalda@chromium.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).