From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3199D4430 for ; Wed, 26 Feb 2025 05:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740547826; cv=none; b=Oduo/NCnnAfhIebdH9LH3d4e3UAGzE7OGfji0Lr+ps9Byx1ATNB5Z3YG4ktwzr1+LakQifjnSNZjmSxzdEwOlusD4mjX5p5G5vm8Mn1Oj/zcMdJpJPZUQbQgUgRIQHxTTkJ6V8EG4TuhF6jbgvYIhU5qnd95brPs9nGwG214+Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740547826; c=relaxed/simple; bh=PDCwV3qdEOjxXIjtKkWf5Vz2HcCqhICawWEfa4yI5K8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b+9TQLCt8a2M5kCzKMrq/wXb72NXLqXE3jn3Emn7eBHP2xbGbLVIhlwdoHojWuCbOQxh85I9EV90JL6cgpGtsmjaruh32sLp2z3vwFdcUN2+UyyIgiM10KJ/dROL7ZT/2EUrHlcfFj9ydU4pTs/OsmFhvO8WwkZsLsvYd8lU1gA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hoKf9oVM; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hoKf9oVM" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-220e6028214so139634495ad.0 for ; Tue, 25 Feb 2025 21:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740547824; x=1741152624; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ysxu4HBM1PvBAX3G7aQAJNrxG8wBMOF98K3kSzCpKb4=; b=hoKf9oVMGq/+2ovy8FOqD2fmzLHSTD8lGrmrZtUKQC7itxUJJAsI+fR+xw1l+RYBmD Ljf6IgoB6vTyHnWa4Wsp4cEff0bvxOr5Zl5bIPXewCJuMn4jkgnHrBe5bJYJxNn95T0g 9Aj1ddGjbZ2QZdMcAqEiy3jOeXNlop7sABATIrmL43bVSHBvuqEwN4P95MtxaB6XdNHu ZHn8xbComngq+Pocw2X1PxoBLcb1ViyAzCwjN2zlHoO4a1Gc8KjZc9WDw0rIlRsOLCl9 gcGSNCvvs4W20XyQjioyWvCflTIgoYEjvRfju2I9En4zpMKAt3Bq+O+lc/CNHdPLLYia i57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740547824; x=1741152624; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ysxu4HBM1PvBAX3G7aQAJNrxG8wBMOF98K3kSzCpKb4=; b=Q941gvuvyhVeoI0rBf/l+47C/fITYGQ7iIbfaKqo/eSXA480Gv6n7SM/gknxnKUjnM QXuW1Aqb/ThpuX6/rQE8VhIA7ty2lnXIngpd+Lwx8rVHY91C3Y2p6WE6di5HIJIwIKS9 7fZ57XLE74BtGaAT0rpNsfoaqBoLJ1DQ46q3dNcVsDqE2y8TNIqgN7VdRqU5HdpfOOJr aFx2SaXIG9TcyyweRoDU1OOS1N4tl0NSGy6b553afPrE/SMrljS+964HUri70Pi4R6KV pIwZEVDRWhI1qgmaUWtx4YTEOiwrpWaPwrNzAqMO5DBgMbT2TKiPI37IrzHfKri6n2tt PvRg== X-Forwarded-Encrypted: i=1; AJvYcCWllPLCZz2fc9lvBaUv2LTI/+rm6LcDgq1Jgz/FKNQaybvWVRDe3EuSUYbO8B5xMn8M9HL6N4yspl61GDyK@vger.kernel.org X-Gm-Message-State: AOJu0YxXsQiP7uo6OCSVTUpWo9xjgx1AmaJNoexUlqNwZ0qq4QAr+X+n z70VgPZBMvroCf6lEjbGvdZBGquBFwdlVpbOl6cYR+kufQDDpyKLSQy/Sj4q5w== X-Gm-Gg: ASbGncs9NxK5XI4X4T4hC4Jz3efSn82Xx92xwwQBXfVm67MTUrBDmT+4+/Rnkz5Ms+1 WKZC4UtaLD1t7fvOI+TewhwfrpSWrN3T5e7A4KgQBwQqKgXfAvlHnr+eGmztn6OceBCZdSdxB09 f9k+m5fEUTKTVthe35ap6+7DsehLNopZYqsyGXZXanejZb0whdT86JdKS92A8yINH8WHfM52rgq qXeW0z9E95O3fm82n4IiA59rOtw+qOZ6btugtVfXjuP1bCBKF08xwiqPmelvDwIHzggLlw1SHD5 rPbJvXwNW8Cwiqq4eNo7PReYMtV1eFfvDx8M X-Google-Smtp-Source: AGHT+IG1ATYcBA3Lx5kX9fxW7lirbjTeUCqtNQ1K3OphxIX9hK11KaA9lvhbUyRdKaGgUECgCpTu2A== X-Received: by 2002:a17:903:1c4:b0:215:5ea2:6544 with SMTP id d9443c01a7336-2219ff827b7mr300683495ad.7.1740547824537; Tue, 25 Feb 2025 21:30:24 -0800 (PST) Received: from thinkpad ([120.60.72.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2230a0a6252sm23604675ad.186.2025.02.25.21.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 21:30:23 -0800 (PST) Date: Wed, 26 Feb 2025 11:00:19 +0530 From: Manivannan Sadhasivam To: Bart Van Assche Cc: Manivannan Sadhasivam , Manish Pandey , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_nitirawa@quicinc.com Subject: Re: [PATCH 0/3] scsi: ufs-qcom: Enable Dumping of Hibern8, MCQ, and Testbus Registers Message-ID: <20250226053019.y6tdukcqpijkug4m@thinkpad> References: <20241025055054.23170-1-quic_mapa@quicinc.com> <20241112075000.vausf7ulr2t5svmg@thinkpad> <20241209040355.kc4ab6nfp6syw37q@thinkpad> <3a850d86-5974-4b2d-95be-e79dad33636f@acm.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a850d86-5974-4b2d-95be-e79dad33636f@acm.org> On Mon, Dec 09, 2024 at 10:35:39AM -0800, Bart Van Assche wrote: > On 12/8/24 12:03 PM, Manivannan Sadhasivam wrote: > > On Tue, Nov 12, 2024 at 10:10:02AM -0800, Bart Van Assche wrote: > > > On 11/11/24 11:50 PM, Manivannan Sadhasivam wrote: > > > > On Fri, Oct 25, 2024 at 11:20:51AM +0530, Manish Pandey wrote: > > > > > Submitting a series of patches aimed at enhancing the debugging and monitoring capabilities > > > > > of the UFS-QCOM driver. These patches introduce new functionalities that will significantly > > > > > aid in diagnosing and resolving issues related to hardware and software operations. > > > > > > > > > > > > > TBH, the current state of dumping UFSHC registers itself is just annoying as it > > > > pollutes the kernel ring buffer. I don't think any peripheral driver in the > > > > kernel does this. Please dump only relevant registers, not everything that you > > > > feel like dumping. > > > > > > I wouldn't mind if the code for dumping UFSHC registers would be removed. > > > > Instead of removing, I'm planning to move the dump to dev_coredump framework. > > But should we move all the error prints also? Like all ufshcd_print_*() > > functions? > > Hmm ... we may be better off to check which of these functions can be > removed rather than moving all of them to another framework. > devcoredump turned out to be not a good fit for storage drivers. And I can't figure out another way. And Qcom is telling me that these debug prints are necessary for them to debug the issues going forward. Your thoughts? - Mani -- மணிவண்ணன் சதாசிவம்