From: Rob Herring <robh@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: peda@axentia.se, broonie@kernel.org, andersson@kernel.org,
krzk+dt@kernel.org, ivprusov@salutedevices.com,
luca.ceresoli@bootlin.com, zhoubinbin@loongson.cn,
paulha@opensource.cirrus.com, lgirdwood@gmail.com,
conor+dt@kernel.org, konradybcio@kernel.org, perex@perex.cz,
tiwai@suse.com, dmitry.baryshkov@oss.qualcomm.com,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
johan+linaro@kernel.org
Subject: Re: [PATCH v2 3/5] ASoC: dt-bindings: wcd93xx: add bindings for audio mux controlling hp
Date: Fri, 21 Mar 2025 17:00:05 -0500 [thread overview]
Message-ID: <20250321220005.GA4185430-robh@kernel.org> (raw)
In-Reply-To: <20250320115633.4248-4-srinivas.kandagatla@linaro.org>
On Thu, Mar 20, 2025 at 11:56:31AM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> On some platforms to minimise pop and click during switching between
> CTIA and OMTP headset an additional HiFi mux is used. Most common
> case is that this switch is switched on by default, but on some
> platforms this needs a regulator enable.
>
> Move to using mux-controls so that both the gpio and regulators can be
> driven correctly, rather than adding regulator handing in the codec.
>
> This patch adds required bindings to add such mux controls.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> index 10531350c336..e7aa00a9c59a 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> @@ -23,8 +23,13 @@ properties:
> - qcom,wcd9380-codec
> - qcom,wcd9385-codec
>
> + mux-controls:
> + description: A reference to the audio mux switch for
> + switching CTIA/OMTP Headset types
maxItems: 1
> +
> us-euro-gpios:
> - description: GPIO spec for swapping gnd and mic segments
> + description: GPIO spec for swapping gnd and mic segments.
> + This property is considered obsolete, recommended to use mux-controls.
> maxItems: 1
>
> required:
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-03-21 22:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 11:56 [PATCH v2 0/5] ASoC: wcd938x: enable t14s audio headset srinivas.kandagatla
2025-03-20 11:56 ` [PATCH v2 1/5] dt-bindings: mux: add optional regulator binding to gpio mux srinivas.kandagatla
2025-03-21 9:28 ` Krzysztof Kozlowski
2025-03-20 11:56 ` [PATCH v2 2/5] mux: gpio: add optional regulator support srinivas.kandagatla
2025-03-20 12:16 ` Maud Spierings
2025-03-21 9:27 ` Krzysztof Kozlowski
2025-03-20 11:56 ` [PATCH v2 3/5] ASoC: dt-bindings: wcd93xx: add bindings for audio mux controlling hp srinivas.kandagatla
2025-03-21 9:29 ` Krzysztof Kozlowski
2025-03-21 12:29 ` Srinivas Kandagatla
2025-03-21 22:00 ` Rob Herring [this message]
2025-03-20 11:56 ` [PATCH v2 4/5] ASoC: codecs: wcd938x: add mux control support for hp audio mux srinivas.kandagatla
2025-03-20 14:03 ` Dmitry Baryshkov
2025-03-21 12:35 ` Srinivas Kandagatla
2025-03-21 13:16 ` Dmitry Baryshkov
2025-03-21 13:26 ` Srinivas Kandagatla
2025-03-21 16:34 ` Dmitry Baryshkov
2025-03-21 14:14 ` Srinivas Kandagatla
2025-03-21 17:16 ` Dmitry Baryshkov
2025-03-20 15:02 ` Christopher Obbard
2025-03-20 11:56 ` [PATCH v2 5/5] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support srinivas.kandagatla
2025-03-20 13:58 ` Dmitry Baryshkov
2025-03-20 14:59 ` Christopher Obbard
2025-03-21 9:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321220005.GA4185430-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ivprusov@salutedevices.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=paulha@opensource.cirrus.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox