Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Jassi Brar <jassisinghbrar@gmail.com>,
	 Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Luca Weiss" <luca@lucaweiss.eu>,
	"Barnabás Czémán" <barnabas.czeman@mainlining.org>
Subject: [PATCH 2/2] soc: qcom: smp2p: Fix fallback to qcom,ipc parse
Date: Mon, 21 Apr 2025 04:04:17 +0200	[thread overview]
Message-ID: <20250421-fix-qcom-smd-v1-2-574d071d3f27@mainlining.org> (raw)
In-Reply-To: <20250421-fix-qcom-smd-v1-0-574d071d3f27@mainlining.org>

mbox_request_channel() returning value was changed in case of error.
It uses returning value of of_parse_phandle_with_args().
It is returning with -ENOENT instead of -ENODEV when no mboxes property
exists.

Fixes: 24fdd5074b20 ("mailbox: use error ret code of of_parse_phandle_with_args()")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 drivers/soc/qcom/smp2p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index a3e88ced328a91f1eb9dbaaaeb12fc901838bdaa..c9199d6fbe26ecc5ce941cfd608ebf1381be0935 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -575,7 +575,7 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
 	smp2p->mbox_client.knows_txdone = true;
 	smp2p->mbox_chan = mbox_request_channel(&smp2p->mbox_client, 0);
 	if (IS_ERR(smp2p->mbox_chan)) {
-		if (PTR_ERR(smp2p->mbox_chan) != -ENODEV)
+		if (PTR_ERR(smp2p->mbox_chan) != -ENOENT)
 			return PTR_ERR(smp2p->mbox_chan);
 
 		smp2p->mbox_chan = NULL;

-- 
2.49.0


  parent reply	other threads:[~2025-04-21  2:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  2:04 [PATCH 0/2] Fix fallback qcom,ipc parse Barnabás Czémán
2025-04-21  2:04 ` [PATCH 1/2] rpmsg: qcom_smd: Fix fallback to " Barnabás Czémán
2025-04-21 10:38   ` Dmitry Baryshkov
2025-04-21 11:40     ` barnabas.czeman
2025-04-24 11:16       ` Dmitry Baryshkov
2025-04-21  2:04 ` Barnabás Czémán [this message]
2025-04-22  8:21 ` [PATCH 0/2] Fix fallback " Stephan Gerhold
2025-07-29 11:14   ` Nayeemahmed Badebade
2025-05-09 22:13 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421-fix-qcom-smd-v1-2-574d071d3f27@mainlining.org \
    --to=barnabas.czeman@mainlining.org \
    --cc=andersson@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=luca@lucaweiss.eu \
    --cc=mathieu.poirier@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox