From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F37F275844; Tue, 29 Apr 2025 07:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745911230; cv=none; b=NR3gC7UdXpSlC77c2EDFTajf8yunkKjZOESC0YCy3TDSo6Dum2f9wvvxvu1rodGi8Q/A2AgoTN4nK8r1HCxyKU6HZS6jjIiYBw6b/1VLWcbM3IKQmueIJlJT1pvFw25xMh5gKj+AWjN5w2AXAOaLWOMtt8Hph5wUkwdT3LpC2S8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745911230; c=relaxed/simple; bh=DvHWSK/fyReyGHhIvbpBBWWX2aW0IDwM+4oLR25AGF8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ejM0sa0xdhmbM1Xb8yif3Q+i8ppZRTTmqXA+qDHHWoYWVxOCyx/U9jNts0URehPfyKbbj+5fFMVsf5yuW0Lq43EyoJrJLUng+xpi7pthaXYTzxHbgJKZdrFZzXFNjMt+3dvj9SHR2hVp6XVV7e31v32uACqliiU3oAYsqDUm63M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=AOlvZUbD; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="AOlvZUbD" Received: by mail.gandi.net (Postfix) with ESMTPSA id 4104E43A54; Tue, 29 Apr 2025 07:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745911225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyqiKFHppWJecvLWPqnoqiZIgBN9McBLLBAx3iq3BJc=; b=AOlvZUbDeCYCofu6N6SVZm37ESGY0nMlrkfxQ5dAN84Fq2iaUrmBO4hxGrIsQgFwXG8jKs r57awTqRSW9gLM820C44Qz1M7D7XZU6f9KW4R8dL9Xf/84rIH1G3jtt2bZKdjBno9Hls6f P4AQqF7HAo4UfNJUbivJW5ZU89QK5OyBMKq5HmZXZSqsjOf2bU271p/xax7yIUknv7bfHm 235bRBUyIr7mgFAvzPiNzKEC5Ek2rVNPMtQjlIm5hdoMuyTHGlsqy0eJ6IPLTOS9nipI1K YjpjNrjhwy7LNygVeqRYRqdCSAheOXzlkDZcggURgMnTYzkbo8vbJPrt5EbYdA== Date: Tue, 29 Apr 2025 09:20:22 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Marek =?UTF-8?B?QmVow7pu?= , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau Subject: Re: [PATCH net-next v5 03/14] net: phy: Introduce PHY ports representation Message-ID: <20250429092022.1463d5bf@device-130.home> In-Reply-To: <20250428171102.37455ad6@kernel.org> References: <20250425141511.182537-1-maxime.chevallier@bootlin.com> <20250425141511.182537-4-maxime.chevallier@bootlin.com> <20250428171102.37455ad6@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieefvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeevledtvdevueehhfevhfelhfekveeftdfgiedufeffieeltddtgfefuefhueeknecukfhppedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjedphhgvlhhopeguvghvihgtvgdqudeftddrhhhomhgvpdhmrghilhhfrhhomhepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedtpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhor hhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqmhhsmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhopegrnhgurhgvfieslhhunhhnrdgthhdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhm X-GND-Sasl: maxime.chevallier@bootlin.com Hi Jakub, On Mon, 28 Apr 2025 17:11:02 -0700 Jakub Kicinski wrote: > On Fri, 25 Apr 2025 16:14:56 +0200 Maxime Chevallier wrote: > > +/** > > + * phy_port_get_type: get the PORT_* attribut for that port. > > + */ > > +int phy_port_get_type(struct phy_port *port) > > Bunch of missing argument descriptions in the kdoc in this patch. Thanks for taking a look :) I'll address the kdoc for next time I'll wait a bit before re-spin, to get a chance to get some feedback on the whole thing from the PHY folks. Maxime