From: Jakub Kicinski <kuba@kernel.org>
To: Chris Lew <chris.lew@oss.qualcomm.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Hemant Kumar <quic_hemantk@quicinc.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v2] net: qrtr: mhi: synchronize qrtr and mhi preparation
Date: Mon, 9 Jun 2025 16:00:42 -0700 [thread overview]
Message-ID: <20250609160042.7a8940d7@kernel.org> (raw)
In-Reply-To: <20250604-qrtr_mhi_auto-v2-1-a143433ddaad@oss.qualcomm.com>
On Wed, 04 Jun 2025 14:05:42 -0700 Chris Lew wrote:
> + rc = qrtr_mhi_queue_rx(qdev);
> + if (rc) {
> + qrtr_endpoint_unregister(&qdev->ep);
> + mhi_unprepare_from_transfer(mhi_dev);
is ignoring the rc here intentional? may be worth a comment
> + }
> +
> dev_dbg(qdev->dev, "Qualcomm MHI QRTR driver probed\n");
>
> return 0;
Note that we return 0 here, not rc
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-09 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 21:05 [PATCH v2] net: qrtr: mhi: synchronize qrtr and mhi preparation Chris Lew
2025-06-05 8:24 ` Loic Poulain
2025-06-16 23:47 ` Chris Lew
2025-06-09 23:00 ` Jakub Kicinski [this message]
2025-06-17 0:29 ` Chris Lew
2025-06-18 7:53 ` Johan Hovold
2025-06-18 8:25 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609160042.7a8940d7@kernel.org \
--to=kuba@kernel.org \
--cc=chris.lew@oss.qualcomm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fido_max@inbox.ru \
--cc=horms@kernel.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_hemantk@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).