linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
To: jorge.ramirez@oss.qualcomm.com, quic_vgarodia@quicinc.com,
	quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org,
	mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konradybcio@kernel.org, stanimir.k.varbanov@gmail.com
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: [PATCH v2 2/7] media: venus: helpers: add IS_VPU() and IS_HFI() macros
Date: Thu, 19 Jun 2025 16:20:07 +0200	[thread overview]
Message-ID: <20250619142012.1768981-3-jorge.ramirez@oss.qualcomm.com> (raw)
In-Reply-To: <20250619142012.1768981-1-jorge.ramirez@oss.qualcomm.com>

Introduce IS_VPU(core, ...) and IS_HFI(core, ...) macros that abstract
over multiple version checks for VPU and HFI.

They reuse existing IS_<TYPE>(core) definitions.

Allowing up to 4 versions is a fair compromise. Any more would justify an
interface.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
---
 drivers/media/platform/qcom/venus/core.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
index b412e0c5515a..b9de27dc3493 100644
--- a/drivers/media/platform/qcom/venus/core.h
+++ b/drivers/media/platform/qcom/venus/core.h
@@ -528,6 +528,29 @@ struct venus_inst {
 #define IS_IRIS2(core)		((core)->res->vpu_version == VPU_VERSION_IRIS2)
 #define IS_IRIS2_1(core)	((core)->res->vpu_version == VPU_VERSION_IRIS2_1)
 
+#define IS_VPU_MATCH(core, type)	IS_##type(core)
+#define IS_VERSION_MATCH(core, type)	IS_##type(core)
+
+/* Limit this to 4 versions. Use a helper if >4 versions share logic. */
+#define MATCH_1(CMD, core, a) \
+	IS_##CMD##_MATCH(core, a)
+#define MATCH_2(CMD, core, a, b) \
+	(IS_##CMD##_MATCH(core, a) || IS_##CMD##_MATCH(core, b))
+#define MATCH_3(CMD, core, a, b, c) \
+	(IS_##CMD##_MATCH(core, a) || IS_##CMD##_MATCH(core, b) || \
+	IS_##CMD##_MATCH(core, c))
+#define MATCH_4(CMD, core, a, b, c, d) \
+	(IS_##CMD##_MATCH(core, a) || IS_##CMD##_MATCH(core, b) || \
+	IS_##CMD##_MATCH(core, c) || IS_##CMD##_MATCH(core, d))
+
+#define GET_MACRO(_1, _2, _3, _4, NAME, ...) NAME /* _1-_4 are ignored */
+#define IS_DISPATCH(CMD, core, ...) \
+	(GET_MACRO(__VA_ARGS__, MATCH_4, MATCH_3, MATCH_2, MATCH_1)( \
+		CMD, core, __VA_ARGS__))
+
+#define IS_VPU(core, ...)	IS_DISPATCH(VPU, core, __VA_ARGS__)
+#define IS_HFI(core, ...)	IS_DISPATCH(VERSION, core, __VA_ARGS__)
+
 #define ctrl_to_inst(ctrl)	\
 	container_of((ctrl)->handler, struct venus_inst, ctrl_handler)
 
-- 
2.34.1


  parent reply	other threads:[~2025-06-19 14:20 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 14:03 [PATCH 0/5] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-06-13 14:03 ` [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-06-13 14:20   ` Bryan O'Donoghue
2025-06-15 11:38     ` Jorge Ramirez
2025-06-16  8:20   ` Krzysztof Kozlowski
2025-06-16 12:52     ` Jorge Ramirez
2025-06-16 14:41       ` Krzysztof Kozlowski
2025-06-16 16:18         ` Jorge Ramirez
2025-06-16 16:23           ` Krzysztof Kozlowski
2025-06-16 16:59             ` Jorge Ramirez
2025-06-17  6:14               ` Krzysztof Kozlowski
2025-06-17  6:47                 ` Jorge Ramirez
2025-06-17  6:56                   ` Krzysztof Kozlowski
2025-06-17  7:30                     ` Jorge Ramirez
2025-06-17  7:55                       ` Krzysztof Kozlowski
2025-06-13 14:03 ` [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node Jorge Ramirez-Ortiz
2025-06-13 14:06   ` Bryan O'Donoghue
2025-06-15 11:18     ` Jorge Ramirez
2025-06-16  8:22   ` Krzysztof Kozlowski
2025-06-16 12:57     ` Jorge Ramirez
2025-06-13 14:04 ` [PATCH 3/5] media: venus: vdec: ar50_lite video core support Jorge Ramirez-Ortiz
2025-06-13 14:18   ` Bryan O'Donoghue
2025-06-15 11:38     ` Jorge Ramirez
2025-06-16  8:13       ` Bryan O'Donoghue
2025-06-16 12:56         ` Jorge Ramirez
2025-06-13 14:04 ` [PATCH 4/5] media: venus: hfi_plat_v6_lite: Populate decode capabilities Jorge Ramirez-Ortiz
2025-06-13 14:04 ` [PATCH 5/5] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-06-13 14:20   ` Bryan O'Donoghue
2025-06-19 14:20 ` [PATCH v2 0/7] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-06-19 14:20   ` [PATCH v2 1/7] dt-bindings: media: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-06-19 14:23     ` Bryan O'Donoghue
2025-06-19 14:20   ` Jorge Ramirez-Ortiz [this message]
2025-06-19 14:20   ` [PATCH v2 3/7] media: venus: use IS_HFI() macro for multi-version check Jorge Ramirez-Ortiz
2025-06-19 14:20   ` [PATCH v2 4/7] media: venus: vdec: AR50_LITE video core support Jorge Ramirez-Ortiz
2025-06-19 19:44     ` Bryan O'Donoghue
2025-06-19 14:20   ` [PATCH v2 5/7] media: venus: hfi_plat_v6_lite: Populate decode capabilities Jorge Ramirez-Ortiz
2025-06-19 19:47     ` Bryan O'Donoghue
2025-06-19 20:53       ` Jorge Ramirez
2025-06-19 14:20   ` [PATCH v2 6/7] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-06-19 14:20   ` [PATCH v2 7/7] arm64: dts: qcom: qcm2290: Add venus video node Jorge Ramirez-Ortiz
2025-06-19 14:29   ` [PATCH v2 0/7] media: venus: Add QCM2290 support with AR50_LITE core Bryan O'Donoghue
2025-06-19 14:38     ` Jorge Ramirez
2025-06-19 19:43       ` Bryan O'Donoghue
2025-06-19 20:54         ` Jorge Ramirez
2025-06-23  7:49 ` [PATCH v3 0/5] " Jorge Ramirez-Ortiz
2025-06-23  7:49   ` [PATCH v3 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-06-23  7:57     ` Krzysztof Kozlowski
2025-06-23  7:49   ` [PATCH v3 2/5] media: venus: vdec: AR50_LITE video core support Jorge Ramirez-Ortiz
2025-06-23  7:49   ` [PATCH v3 3/5] media: venus: hfi_plat_v6_lite: Populate decode capabilities Jorge Ramirez-Ortiz
2025-06-23  7:49   ` [PATCH v3 4/5] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-06-23  7:49   ` [PATCH v3 5/5] arm64: dts: qcom: qcm2290: Add venus video node Jorge Ramirez-Ortiz
2025-06-23  7:55   ` [PATCH v3 0/5] media: venus: Add QCM2290 support with AR50_LITE core Krzysztof Kozlowski
2025-06-23  8:07     ` Jorge Ramirez
2025-06-23  8:39       ` Krzysztof Kozlowski
2025-06-23 10:37         ` Jorge Ramirez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250619142012.1768981-3-jorge.ramirez@oss.qualcomm.com \
    --to=jorge.ramirez@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).