* [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
@ 2025-06-30 22:41 Richard Acayan
2025-07-01 10:55 ` Konrad Dybcio
2025-08-12 3:04 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Richard Acayan @ 2025-06-30 22:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree
Cc: Richard Acayan
The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
its charging controller in PM660.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
.../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
index 74b5d9c68eb6..d01422844fbf 100644
--- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
+++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
@@ -33,6 +33,14 @@ / {
aliases { };
+ battery: battery {
+ compatible = "simple-battery";
+
+ voltage-min-design-microvolt = <3312000>;
+ voltage-max-design-microvolt = <4400000>;
+ charge-full-design-microamp-hours = <3000000>;
+ };
+
chosen {
stdout-path = "serial0:115200n8";
@@ -478,6 +486,15 @@ &mdss_mdp {
status = "okay";
};
+&pm660_charger {
+ monitored-battery = <&battery>;
+ status = "okay";
+};
+
+&pm660_rradc {
+ status = "okay";
+};
+
&pm660l_flash {
status = "okay";
--
2.50.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
2025-06-30 22:41 [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger Richard Acayan
@ 2025-07-01 10:55 ` Konrad Dybcio
2025-07-01 22:32 ` Richard Acayan
2025-08-12 3:04 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2025-07-01 10:55 UTC (permalink / raw)
To: Richard Acayan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree
On 01-Jul-25 00:41, Richard Acayan wrote:
> The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
> its charging controller in PM660.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> index 74b5d9c68eb6..d01422844fbf 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> @@ -33,6 +33,14 @@ / {
>
> aliases { };
>
> + battery: battery {
> + compatible = "simple-battery";
> +
> + voltage-min-design-microvolt = <3312000>;
> + voltage-max-design-microvolt = <4400000>;
Does this match what downstream sets into the hw?
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
2025-07-01 10:55 ` Konrad Dybcio
@ 2025-07-01 22:32 ` Richard Acayan
2025-07-02 10:52 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Richard Acayan @ 2025-07-01 22:32 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree
On Tue, Jul 01, 2025 at 12:55:14PM +0200, Konrad Dybcio wrote:
>
>
> On 01-Jul-25 00:41, Richard Acayan wrote:
> > The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
> > its charging controller in PM660.
> >
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> > .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > index 74b5d9c68eb6..d01422844fbf 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
> > @@ -33,6 +33,14 @@ / {
> >
> > aliases { };
> >
> > + battery: battery {
> > + compatible = "simple-battery";
> > +
> > + voltage-min-design-microvolt = <3312000>;
> > + voltage-max-design-microvolt = <4400000>;
>
> Does this match what downstream sets into the hw?
Actually, downstream sets the "empty" voltage to 2.6 V. This minimum is
closer to the "cutoff" voltage at 3.3 V.
The maximum voltage is consistent with downstream.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
2025-07-01 22:32 ` Richard Acayan
@ 2025-07-02 10:52 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2025-07-02 10:52 UTC (permalink / raw)
To: Richard Acayan
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree
On 7/2/25 12:32 AM, Richard Acayan wrote:
> On Tue, Jul 01, 2025 at 12:55:14PM +0200, Konrad Dybcio wrote:
>>
>>
>> On 01-Jul-25 00:41, Richard Acayan wrote:
>>> The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
>>> its charging controller in PM660.
>>>
>>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>>> ---
>>> .../arm64/boot/dts/qcom/sdm670-google-sargo.dts | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
>>> index 74b5d9c68eb6..d01422844fbf 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
>>> @@ -33,6 +33,14 @@ / {
>>>
>>> aliases { };
>>>
>>> + battery: battery {
>>> + compatible = "simple-battery";
>>> +
>>> + voltage-min-design-microvolt = <3312000>;
>>> + voltage-max-design-microvolt = <4400000>;
>>
>> Does this match what downstream sets into the hw?
>
> Actually, downstream sets the "empty" voltage to 2.6 V. This minimum is
> closer to the "cutoff" voltage at 3.3 V.
>
> The maximum voltage is consistent with downstream.
Alright, thanks
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger
2025-06-30 22:41 [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger Richard Acayan
2025-07-01 10:55 ` Konrad Dybcio
@ 2025-08-12 3:04 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-08-12 3:04 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, Richard Acayan
On Mon, 30 Jun 2025 18:41:59 -0400, Richard Acayan wrote:
> The Pixel 3a has a rechargeable 3000 mAh battery. Describe it and enable
> its charging controller in PM660.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sdm670-google-sargo: enable charger
commit: 8839b8e6e849e209b52bf0ae4d0770d89c036b0e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-12 3:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 22:41 [PATCH] arm64: dts: qcom: sdm670-google-sargo: enable charger Richard Acayan
2025-07-01 10:55 ` Konrad Dybcio
2025-07-01 22:32 ` Richard Acayan
2025-07-02 10:52 ` Konrad Dybcio
2025-08-12 3:04 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).