[PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

Bryan O'Donoghue reviews and applies patches for both Iris and Venus
Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
in pull requests like [1]), so he is de facto the maintainer responsible
for the code.  Reflect this actual state my changing his entry from
reviewer to maintainer and moving the entry to alphabetical position by
first name.

[1] https://lore.kernel.org/linux-media/20250630121704.260831-1-bod@kernel.org/T/#u

Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Vikash Garodia <quic_vgarodia@quicinc.com>
Cc: Dikshita Agarwal <quic_dikshita@quicinc.com>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 40831ae42296..f56e40d9b3c7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20678,10 +20678,10 @@ F:	Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
 F:	drivers/regulator/vqmmc-ipq4019-regulator.c
 
 QUALCOMM IRIS VIDEO ACCELERATOR DRIVER
+M:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
 M:	Vikash Garodia <quic_vgarodia@quicinc.com>
 M:	Dikshita Agarwal <quic_dikshita@quicinc.com>
 R:	Abhinav Kumar <abhinav.kumar@linux.dev>
-R:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
 L:	linux-media@vger.kernel.org
 L:	linux-arm-msm@vger.kernel.org
 S:	Maintained
@@ -20750,9 +20750,9 @@ F:	Documentation/devicetree/bindings/usb/qcom,pmic-*.yaml
 F:	drivers/usb/typec/tcpm/qcom/
 
 QUALCOMM VENUS VIDEO ACCELERATOR DRIVER
+M:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
 M:	Vikash Garodia <quic_vgarodia@quicinc.com>
 M:	Dikshita Agarwal <quic_dikshita@quicinc.com>
-R:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
 L:	linux-media@vger.kernel.org
 L:	linux-arm-msm@vger.kernel.org
 S:	Maintained
-- 
2.43.0

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Vikash Garodia]

On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
> in pull requests like [1]), so he is de facto the maintainer responsible
> for the code.  Reflect this actual state my changing his entry from
> reviewer to maintainer and moving the entry to alphabetical position by
> first name.

NAK.

The roles and responsibilities are well agreed by media maintainer(Hans), with
Bryan part of that discussion, w.r.t code contributions to iris and sending
patches to media tree. The only reason Bryan post the patches is that Hans wants
single PR for patches across Qualcomm media drivers (Camss/Videoss)

Hi Hans,

Incase you would like to split sending PRs, as the contributions for Venus/Iris
would be significantly higher, let us know, we can pick that up separately.

Regards,
Vikash
> 
> [1] https://lore.kernel.org/linux-media/20250630121704.260831-1-bod@kernel.org/T/#u
> 
> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Cc: Vikash Garodia <quic_vgarodia@quicinc.com>
> Cc: Dikshita Agarwal <quic_dikshita@quicinc.com>
> Cc: Abhinav Kumar <abhinav.kumar@linux.dev>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 40831ae42296..f56e40d9b3c7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20678,10 +20678,10 @@ F:	Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
>  F:	drivers/regulator/vqmmc-ipq4019-regulator.c
>  
>  QUALCOMM IRIS VIDEO ACCELERATOR DRIVER
> +M:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>  M:	Vikash Garodia <quic_vgarodia@quicinc.com>
>  M:	Dikshita Agarwal <quic_dikshita@quicinc.com>
>  R:	Abhinav Kumar <abhinav.kumar@linux.dev>
> -R:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>  L:	linux-media@vger.kernel.org
>  L:	linux-arm-msm@vger.kernel.org
>  S:	Maintained
> @@ -20750,9 +20750,9 @@ F:	Documentation/devicetree/bindings/usb/qcom,pmic-*.yaml
>  F:	drivers/usb/typec/tcpm/qcom/
>  
>  QUALCOMM VENUS VIDEO ACCELERATOR DRIVER
> +M:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>  M:	Vikash Garodia <quic_vgarodia@quicinc.com>
>  M:	Dikshita Agarwal <quic_dikshita@quicinc.com>
> -R:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>  L:	linux-media@vger.kernel.org
>  L:	linux-arm-msm@vger.kernel.org
>  S:	Maintained

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

On 15/07/2025 07:51, Vikash Garodia wrote:
> 
> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>> in pull requests like [1]), so he is de facto the maintainer responsible
>> for the code.  Reflect this actual state my changing his entry from
>> reviewer to maintainer and moving the entry to alphabetical position by
>> first name.
> 
> NAK.
> 
> The roles and responsibilities are well agreed by media maintainer(Hans), with
> Bryan part of that discussion, w.r.t code contributions to iris and sending
> patches to media tree. The only reason Bryan post the patches is that Hans wants
> single PR for patches across Qualcomm media drivers (Camss/Videoss)

That's the maintainer role, so Bryan is the maintainer. I am documenting
actual status and your NAK is naking what? That Bryan cannot handle patches?

Sorry, this is already happening.

Your push back here is odd, impolite and really disappointing. You
actually should be happy that person outside wants to care about this
driver...

> Hi Hans,
> 
> Incase you would like to split sending PRs, as the contributions for Venus/Iris
> would be significantly higher, let us know, we can pick that up separately.

Considering quality of the code you sent as Iris upstreaming, you are
not there yet.

https://lore.kernel.org/all/1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com/

Please learn, read how the process works, what is the responsibility of
maintainers first.


Best regards,
Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Vikash Garodia]

On 7/15/2025 12:14 PM, Krzysztof Kozlowski wrote:
> On 15/07/2025 07:51, Vikash Garodia wrote:
>>
>> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>>> in pull requests like [1]), so he is de facto the maintainer responsible
>>> for the code.  Reflect this actual state my changing his entry from
>>> reviewer to maintainer and moving the entry to alphabetical position by
>>> first name.
>>
>> NAK.
>>
>> The roles and responsibilities are well agreed by media maintainer(Hans), with
>> Bryan part of that discussion, w.r.t code contributions to iris and sending
>> patches to media tree. The only reason Bryan post the patches is that Hans wants
>> single PR for patches across Qualcomm media drivers (Camss/Videoss)
> 
> That's the maintainer role, so Bryan is the maintainer. I am documenting
> actual status and your NAK is naking what? That Bryan cannot handle patches?
I would say, you are reading too much into it, i updated what we have discussed
and agreed upon the different roles for managing venus and iris drivers.
> 
> Sorry, this is already happening.
> 
> Your push back here is odd, impolite and really disappointing. You
> actually should be happy that person outside wants to care about this
> driver...
> 
>> Hi Hans,
>>
>> Incase you would like to split sending PRs, as the contributions for Venus/Iris
>> would be significantly higher, let us know, we can pick that up separately.
> 
> Considering quality of the code you sent as Iris upstreaming, you are
> not there yet.
If you see the scope to improve the quality, you are always welcome to add
patches to improve it.

Regards,
Vikash
> 
> https://lore.kernel.org/all/1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com/
> 
> Please learn, read how the process works, what is the responsibility of
> maintainers first.
> 
> 
> Best regards,
> Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

On 15/07/2025 09:00, Vikash Garodia wrote:
> 
> On 7/15/2025 12:14 PM, Krzysztof Kozlowski wrote:
>> On 15/07/2025 07:51, Vikash Garodia wrote:
>>>
>>> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>>>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>>>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>>>> in pull requests like [1]), so he is de facto the maintainer responsible
>>>> for the code.  Reflect this actual state my changing his entry from
>>>> reviewer to maintainer and moving the entry to alphabetical position by
>>>> first name.
>>>
>>> NAK.
>>>
>>> The roles and responsibilities are well agreed by media maintainer(Hans), with
>>> Bryan part of that discussion, w.r.t code contributions to iris and sending
>>> patches to media tree. The only reason Bryan post the patches is that Hans wants
>>> single PR for patches across Qualcomm media drivers (Camss/Videoss)
>>
>> That's the maintainer role, so Bryan is the maintainer. I am documenting
>> actual status and your NAK is naking what? That Bryan cannot handle patches?
> I would say, you are reading too much into it, i updated what we have discussed
> and agreed upon the different roles for managing venus and iris drivers.

Reading too much? Bryan HANDLES THE PATCHES.

That's it.

There is nothing "too much here".

Person handling the patches IS the maintainer. Full stop.

>>
>> Sorry, this is already happening.
>>
>> Your push back here is odd, impolite and really disappointing. You
>> actually should be happy that person outside wants to care about this
>> driver...
>>
>>> Hi Hans,
>>>
>>> Incase you would like to split sending PRs, as the contributions for Venus/Iris
>>> would be significantly higher, let us know, we can pick that up separately.
>>
>> Considering quality of the code you sent as Iris upstreaming, you are
>> not there yet.
> If you see the scope to improve the quality, you are always welcome to add
> patches to improve it.

I spoke about your work. You cannot use argument that you want to handle
patches regardless of quality of your code.

> 
> Regards,
> Vikash
>>
>> https://lore.kernel.org/all/1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com/

The one here.


Best regards,
Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

On 14/07/2025 17:16, Krzysztof Kozlowski wrote:
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 40831ae42296..f56e40d9b3c7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20678,10 +20678,10 @@ F:	Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
>  F:	drivers/regulator/vqmmc-ipq4019-regulator.c
>  
>  QUALCOMM IRIS VIDEO ACCELERATOR DRIVER
> +M:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>  M:	Vikash Garodia <quic_vgarodia@quicinc.com>
>  M:	Dikshita Agarwal <quic_dikshita@quicinc.com>
>  R:	Abhinav Kumar <abhinav.kumar@linux.dev>
> -R:	Bryan O'Donoghue <bryan.odonoghue@linaro.org>


I think it would be good to add here also T:. Bryan, do you use your
kernel.org repo or the freedesktop repo from last pull request?

Best regards,
Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Bryan O'Donoghue]

On 15/07/2025 08:18, Krzysztof Kozlowski wrote:
>> +M:	Bryan O'Donoghue<bryan.odonoghue@linaro.org>
>>   M:	Vikash Garodia<quic_vgarodia@quicinc.com>
>>   M:	Dikshita Agarwal<quic_dikshita@quicinc.com>
>>   R:	Abhinav Kumar<abhinav.kumar@linux.dev>
>> -R:	Bryan O'Donoghue<bryan.odonoghue@linaro.org>
> 
> I think it would be good to add here also T:. Bryan, do you use your
> kernel.org repo or the freedesktop repo from last pull request?
> 
> Best regards,
> Krzysztof

Freedesktop - the media-ci lets us test a whole bunch of stuff so its 
convenient / less work to issue a PR from there.

---
bod

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

On 15/07/2025 09:06, Krzysztof Kozlowski wrote:
> On 15/07/2025 09:00, Vikash Garodia wrote:
>>
>> On 7/15/2025 12:14 PM, Krzysztof Kozlowski wrote:
>>> On 15/07/2025 07:51, Vikash Garodia wrote:
>>>>
>>>> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>>>>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>>>>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>>>>> in pull requests like [1]), so he is de facto the maintainer responsible
>>>>> for the code.  Reflect this actual state my changing his entry from
>>>>> reviewer to maintainer and moving the entry to alphabetical position by
>>>>> first name.
>>>>
>>>> NAK.
>>>>
>>>> The roles and responsibilities are well agreed by media maintainer(Hans), with
>>>> Bryan part of that discussion, w.r.t code contributions to iris and sending
>>>> patches to media tree. The only reason Bryan post the patches is that Hans wants
>>>> single PR for patches across Qualcomm media drivers (Camss/Videoss)
>>>
>>> That's the maintainer role, so Bryan is the maintainer. I am documenting
>>> actual status and your NAK is naking what? That Bryan cannot handle patches?
>> I would say, you are reading too much into it, i updated what we have discussed
>> and agreed upon the different roles for managing venus and iris drivers.
> 
> Reading too much? Bryan HANDLES THE PATCHES.
> 
> That's it.
> 
> There is nothing "too much here".
> 
> Person handling the patches IS the maintainer. Full stop.

Based on email you forwarded to me and some more feedback I got, I think
I understood what would be the solution to satisfy your point of not
changing existing entry and solve my problem of maintainer handling
patches not being listed anywhere as maintainer. I will solve it v2.

Best regards,
Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Bryan O'Donoghue]

On 15/07/2025 10:20, Krzysztof Kozlowski wrote:
> On 15/07/2025 09:06, Krzysztof Kozlowski wrote:
>> On 15/07/2025 09:00, Vikash Garodia wrote:
>>>
>>> On 7/15/2025 12:14 PM, Krzysztof Kozlowski wrote:
>>>> On 15/07/2025 07:51, Vikash Garodia wrote:
>>>>>
>>>>> On 7/14/2025 8:46 PM, Krzysztof Kozlowski wrote:
>>>>>> Bryan O'Donoghue reviews and applies patches for both Iris and Venus
>>>>>> Qualcomm SoC video codecs (visible in git log as his Signed-off-by and
>>>>>> in pull requests like [1]), so he is de facto the maintainer responsible
>>>>>> for the code.  Reflect this actual state my changing his entry from
>>>>>> reviewer to maintainer and moving the entry to alphabetical position by
>>>>>> first name.
>>>>>
>>>>> NAK.
>>>>>
>>>>> The roles and responsibilities are well agreed by media maintainer(Hans), with
>>>>> Bryan part of that discussion, w.r.t code contributions to iris and sending
>>>>> patches to media tree. The only reason Bryan post the patches is that Hans wants
>>>>> single PR for patches across Qualcomm media drivers (Camss/Videoss)
>>>>
>>>> That's the maintainer role, so Bryan is the maintainer. I am documenting
>>>> actual status and your NAK is naking what? That Bryan cannot handle patches?
>>> I would say, you are reading too much into it, i updated what we have discussed
>>> and agreed upon the different roles for managing venus and iris drivers.
>>
>> Reading too much? Bryan HANDLES THE PATCHES.
>>
>> That's it.
>>
>> There is nothing "too much here".
>>
>> Person handling the patches IS the maintainer. Full stop.
> 
> Based on email you forwarded to me and some more feedback I got, I think
> I understood what would be the solution to satisfy your point of not
> changing existing entry and solve my problem of maintainer handling
> patches not being listed anywhere as maintainer. I will solve it v2.
> 
> Best regards,
> Krzysztof

Doh, this is definitely my bad, I should have made a _new_ entry in 
MAINTAIENRS similar to this.

AIROHA PCIE PHY DRIVER
M:      Lorenzo Bianconi <lorenzo@kernel.org>
L:      linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml
F:      drivers/phy/phy-airoha-pcie-regs.h
F:      drivers/phy/phy-airoha-pcie.c

GENERIC PHY FRAMEWORK
M:      Vinod Koul <vkoul@kernel.org>
M:      Kishon Vijay Abraham I <kishon@kernel.org>
L:      linux-phy@lists.infradead.org
S:      Supported
Q:      https://patchwork.kernel.org/project/linux-phy/list/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
F:      Documentation/devicetree/bindings/phy/
F:      drivers/phy/
F:      include/dt-bindings/phy/
F:      include/linux/phy/

scripts/get_maintainer.pl drivers/phy/phy-airoha-pcie.c
Lorenzo Bianconi <lorenzo@kernel.org> (maintainer:AIROHA PCIE PHY DRIVER)
Vinod Koul <vkoul@kernel.org> (maintainer:GENERIC PHY FRAMEWORK)
Kishon Vijay Abraham I <kishon@kernel.org> (maintainer:GENERIC PHY 
FRAMEWORK)
linux-arm-kernel@lists.infradead.org (moderated list:AIROHA PCIE PHY DRIVER)
linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK)
linux-kernel@vger.kernel.org (open list)
GENERIC PHY FRAMEWORK status: Supported

Its 1:1 what we have for drivers/media/platform/qcom

I'll add that entry and leave the Iris/Venus entries as-is.

---
bod

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Krzysztof Kozlowski]

On 15/07/2025 13:03, Bryan O'Donoghue wrote:
>>>
>>> Reading too much? Bryan HANDLES THE PATCHES.
>>>
>>> That's it.
>>>
>>> There is nothing "too much here".
>>>
>>> Person handling the patches IS the maintainer. Full stop.
>>
>> Based on email you forwarded to me and some more feedback I got, I think
>> I understood what would be the solution to satisfy your point of not
>> changing existing entry and solve my problem of maintainer handling
>> patches not being listed anywhere as maintainer. I will solve it v2.
>>
>> Best regards,
>> Krzysztof
> 
> Doh, this is definitely my bad, I should have made a _new_ entry in 
> MAINTAIENRS similar to this.
> 
> AIROHA PCIE PHY DRIVER
> M:      Lorenzo Bianconi <lorenzo@kernel.org>
> L:      linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S:      Maintained
> F:      Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml
> F:      drivers/phy/phy-airoha-pcie-regs.h
> F:      drivers/phy/phy-airoha-pcie.c
> 
> GENERIC PHY FRAMEWORK
> M:      Vinod Koul <vkoul@kernel.org>
> M:      Kishon Vijay Abraham I <kishon@kernel.org>
> L:      linux-phy@lists.infradead.org
> S:      Supported
> Q:      https://patchwork.kernel.org/project/linux-phy/list/
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
> F:      Documentation/devicetree/bindings/phy/
> F:      drivers/phy/
> F:      include/dt-bindings/phy/
> F:      include/linux/phy/
> 
> scripts/get_maintainer.pl drivers/phy/phy-airoha-pcie.c
> Lorenzo Bianconi <lorenzo@kernel.org> (maintainer:AIROHA PCIE PHY DRIVER)
> Vinod Koul <vkoul@kernel.org> (maintainer:GENERIC PHY FRAMEWORK)
> Kishon Vijay Abraham I <kishon@kernel.org> (maintainer:GENERIC PHY 
> FRAMEWORK)
> linux-arm-kernel@lists.infradead.org (moderated list:AIROHA PCIE PHY DRIVER)
> linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK)
> linux-kernel@vger.kernel.org (open list)
> GENERIC PHY FRAMEWORK status: Supported
> 
> Its 1:1 what we have for drivers/media/platform/qcom
> 
> I'll add that entry and leave the Iris/Venus entries as-is.

Any progress on this? We agreed you will be sending that, but I think it
did not happen, so maybe you want me to send it?

Best regards,
Krzysztof

Re: [PATCH] media: iris: MAINTAINERS: Document actual maintainership by Bryan O'Donoghue

[Bryan O'Donoghue]

On 12/08/2025 09:26, Krzysztof Kozlowski wrote:
>> I'll add that entry and leave the Iris/Venus entries as-is.
> Any progress on this? We agreed you will be sending that, but I think it
> did not happen, so maybe you want me to send it?

Ah I forgot to send this, its in my local tree.

One sec..

---
bod