From: Jakub Kicinski <kuba@kernel.org>
To: Vivek.Pernamitta@quicinc.com
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Manivannan Sadhasivam <mani@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mhi@lists.linux.dev>,
<linux-arm-msm@vger.kernel.org>,
Vivek Pernamitta <quic_vpernami@quicinc.com>
Subject: Re: [PATCH 2/4] net: mhi : Add support to enable ethernet interface
Date: Fri, 25 Jul 2025 17:10:53 -0700 [thread overview]
Message-ID: <20250725171053.03c0c44d@kernel.org> (raw)
In-Reply-To: <20250724-b4-eth_us-v1-2-4dff04a9a128@quicinc.com>
On Thu, 24 Jul 2025 19:21:18 +0530 Vivek.Pernamitta@quicinc.com wrote:
> ndev = alloc_netdev(sizeof(struct mhi_net_dev), netname,
> - NET_NAME_PREDICTABLE, mhi_net_setup);
> + NET_NAME_PREDICTABLE, info->ethernet_if ?
> + mhi_ethernet_setup : mhi_net_setup);
Similar story, if it's an Ethernet device is should be called eth%d
and user space can name it whatever it wants based on the full sysfs
attribute set.
For n-th time in our history we discover that having the kernel create
"predictable" names always falls short, sigh.
next prev parent reply other threads:[~2025-07-26 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 13:51 [PATCH 0/4] net: mhi : Add support to enable ethernet interface Vivek.Pernamitta
2025-07-24 13:51 ` [PATCH 1/4] net: mhi: Rename MHI interface to improve clarity Vivek.Pernamitta
2025-07-26 0:08 ` Jakub Kicinski
2025-07-24 13:51 ` [PATCH 2/4] net: mhi : Add support to enable ethernet interface Vivek.Pernamitta
2025-07-26 0:10 ` Jakub Kicinski [this message]
2025-07-24 13:51 ` [PATCH 3/4] net: mhi: Add MHI IP_SW1, ETH0 and ETH1 interface Vivek.Pernamitta
2025-07-24 13:51 ` [PATCH 4/4] bus: mhi: host: pci: Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for QDU100 Vivek.Pernamitta
2025-07-24 16:39 ` [PATCH 0/4] net: mhi : Add support to enable ethernet interface Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725171053.03c0c44d@kernel.org \
--to=kuba@kernel.org \
--cc=Vivek.Pernamitta@quicinc.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_vpernami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).