linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bus: mhi: host: pci_generic: Add Quectel RM520N-GLAP to pci id table
@ 2025-07-29 11:37 Michael Fritscher
  2025-08-18  8:19 ` Manivannan Sadhasivam
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Fritscher @ 2025-07-29 11:37 UTC (permalink / raw)
  To: Manivannan Sadhasivam; +Cc: mhi, linux-arm-msm, linux-kernel, Michael Fritscher

Quectel RM520N-GLAP is a variant of Quectel RM520N-GLAA with fused out USB.
Add its PCI vendor and product id to the list to use the right dev info.

Signed-off-by: Michael Fritscher <michael@fritscher.net>
---
This series add support for the Quectel RM520N-GLAP, which uses a
Qualcomm PCI Vendor ID. Origin is linked at the end. After this it is
found as

MHI PCI device found: quectel-rm5xx

and works.

Link: https://forum.gl-inet.com/t/how-to-installing-vanilla-openwrt-on-gl-x3000/45404/15
---
 drivers/bus/mhi/host/pci_generic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 589cb6722316..3f3212dda5bb 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -857,6 +857,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info },
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306),
 		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info },
+	/* RM520N-GL variant with Qualcomm vendor and subvendor ID */
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_QCOM, 0x5201),
+		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
 	/* Telit FN990 */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2010),
 		.driver_data = (kernel_ulong_t) &mhi_telit_fn990_info },

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250729-add-rm520n-glap-support-8add91648721

Best regards,
-- 
Michael Fritscher <michael@fritscher.net>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bus: mhi: host: pci_generic: Add Quectel RM520N-GLAP to pci id table
  2025-07-29 11:37 [PATCH] bus: mhi: host: pci_generic: Add Quectel RM520N-GLAP to pci id table Michael Fritscher
@ 2025-08-18  8:19 ` Manivannan Sadhasivam
  0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2025-08-18  8:19 UTC (permalink / raw)
  To: Michael Fritscher; +Cc: mhi, linux-arm-msm, linux-kernel, duke_xinanwen

+ Duke Xin

On Tue, Jul 29, 2025 at 01:37:51PM GMT, Michael Fritscher wrote:
> Quectel RM520N-GLAP is a variant of Quectel RM520N-GLAA with fused out USB.
> Add its PCI vendor and product id to the list to use the right dev info.
> 
> Signed-off-by: Michael Fritscher <michael@fritscher.net>
> ---
> This series add support for the Quectel RM520N-GLAP, which uses a
> Qualcomm PCI Vendor ID. Origin is linked at the end. After this it is
> found as
> 
> MHI PCI device found: quectel-rm5xx
> 
> and works.
> 

This looks similar to another issue that is being discussed here:
https://lore.kernel.org/mhi/ywase3lkm5iimrzyin5grb3hr36zedsvzs3p2z6z2q6532g3cq@25ibqnpmanvo/

These Quectel modems are reusing the QCOM Vendor IDs and ends up causing
trouble. We need to hear from Quectel on why this happens and how they want
these modems to be supported in mainline.

- Mani

> Link: https://forum.gl-inet.com/t/how-to-installing-vanilla-openwrt-on-gl-x3000/45404/15
> ---
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 589cb6722316..3f3212dda5bb 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -857,6 +857,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306),
>  		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info },
> +	/* RM520N-GL variant with Qualcomm vendor and subvendor ID */
> +	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_QCOM, 0x5201),
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
>  	/* Telit FN990 */
>  	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2010),
>  		.driver_data = (kernel_ulong_t) &mhi_telit_fn990_info },
> 
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250729-add-rm520n-glap-support-8add91648721
> 
> Best regards,
> -- 
> Michael Fritscher <michael@fritscher.net>
> 

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-18  8:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 11:37 [PATCH] bus: mhi: host: pci_generic: Add Quectel RM520N-GLAP to pci id table Michael Fritscher
2025-08-18  8:19 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).