From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09CFA4690 for ; Fri, 1 Aug 2025 15:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754060887; cv=none; b=CC//fnRZm3KCdI8Lut7BZDTfYaj715wtISGurst1LBaN8V5Iog+PznG+jc+o1V4RCosSWgD3unxZG11etENbzLCV2AneX1zZsZedfSAH9uuyaKdJDOiXI6DnBitHkWWJjLlaHOjeRRD0uX/vIuRDUYRhZutX58WSCijT0J2optg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754060887; c=relaxed/simple; bh=KP97mkf4mFx6Hynpv+UvTtqAjJLhCHcsa39rmhW+j40=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=limt7qcMy2pSGgyQ2sKtW6mANXfkfO7ZIxfmQqSigw4fUh52lK0dMK1NuUQDOVglPFFB5aroqmZlvO0TAjKzFSvqiwY5zVmTYVlDqqy17CCTcQAg4jZHE3T0vpb4+Y0+4uNO6WrjeHruez7hhajRbeBtp/J/JR/ObY+7S+9/qKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bc2xHQd6; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bc2xHQd6" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2403ceef461so8501195ad.3 for ; Fri, 01 Aug 2025 08:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754060885; x=1754665685; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rf99YwbE+zk9ZgJ2ORD0W2vahwafwsW/a1Bh6B8t8K0=; b=bc2xHQd6D2HGLfMPkf0XPeDJyc8xtcIMI1yERSnoAnuJZMRDnhtCbywVLKNn+UjxcY ZVMs0tWCP5OT2mlFrkn46rYstCV+8Hmdr8b81HLdw5L72j1G7K4fZ/nir0NlKtCWjt7f o6JWrFS5/FWYNrwsf00DXWAPZ0WzgEjrSXE0qTyRf2CIrEfzKLPigMmDgtG1h+CEPLB+ 8xvLWQdQUNfmhoMTKObJc/ImvjWFPydypF25zorEFUQSJLEZAiCKlpAmS18xx9CPCOiQ kXI6mFaxGsxHJo+HDJjPXZ46gXtF97XLyBpI8jrIAZU1Ic4KN2+fomZixYuRV/HubJ1n Tnzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754060885; x=1754665685; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rf99YwbE+zk9ZgJ2ORD0W2vahwafwsW/a1Bh6B8t8K0=; b=ptppUMgwK5djXi4EhOnhreA4zQQyWrT4+mPeNTDBZQ2W/EpVl/2MZ5ioV8FNBf46M3 s5U90dIZTRhiHNnLIRs/A5SbwYGsG7RrQNMQxef8wCVuMQ9dvi0K8VEO9D2H8pF2n4A3 Mr5S7JF4FwMNmBhapMGA1IKwsDVOl5hjwaJwn/3IxgDebOny7pJMYW0b1ZA+vQ2GrdCu knohdMbjIKj7vepp+p026b7V8McL0Nkej/KLhF2tjm1f39CoVvqoF2yZ8Vwa95G3JoNu aaYSzd854db5gOq/9xlhg0iTUGbMR5mbPiBwvM7cU0MVzMHXDy+udDXQ+6A9jEDXsSXc NQlA== X-Gm-Message-State: AOJu0Ywcj1fsttezDFCFoglCoAAFT96VVhabHAEh8lvMyR1aqcZpgnS6 TKDP6l6C0bH8+BhUC6gV+3TnYfFin8oa1w6Ai/SCRUpDgFCmYdR0mGdKt0dwz7iy2eo0ZGjA4Fa w6VslcciDTg== X-Gm-Gg: ASbGncsa3IC+XFCPxWdq5NRL0xdBpBgE3eD2N6y+qe2jXpIXiSFanfuFDxIhjxlCmI/ NwGx15mEk4iKATkyCnYz99twDWWbtU9QegoaAXCaooSGyJMLaHYKcVKVHMWyvZErSfX0x9mskNV tyY6sAfFQhaZ1FpfnC8SywO9AET8vHMkuI7uMzkUERkfaWo2m7smdb1Y1/Muz8uFbGww/gpFySE 5B8035HzWliuq+D9G82MOWV7sbcpQ27YzYF7z0etWl8HlFphXB4dYsqEOAwRrq4V47o2+HcIiiT /AK0NxMlg7L/bxH3UDcvaci/zJNNuCwGEHVkYLPPUJiZgc4bX5kxs0UVO8MfGLZgvzAr2c4N0uU 0P5A48el5Z9GiKaNr0Q== X-Google-Smtp-Source: AGHT+IGiwYm32MVhjAi/R8SAhYPDtoGfgkZqyTUOInwqu82Q9+Cr13JsjqnX0HH3RV2AGlVvh596rA== X-Received: by 2002:a17:902:d2cd:b0:223:619e:71da with SMTP id d9443c01a7336-24096bb3420mr176856955ad.49.1754060885202; Fri, 01 Aug 2025 08:08:05 -0700 (PDT) Received: from [127.0.1.1] ([112.64.60.64]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8aafa11sm45639705ad.172.2025.08.01.08.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 08:08:04 -0700 (PDT) From: Jun Nie Date: Fri, 01 Aug 2025 23:07:27 +0800 Subject: [PATCH v14 03/13] drm/msm/dpu: decide right side per last bit Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250801-v6-16-rc2-quad-pipe-upstream-v14-3-b626236f4c31@linaro.org> References: <20250801-v6-16-rc2-quad-pipe-upstream-v14-0-b626236f4c31@linaro.org> In-Reply-To: <20250801-v6-16-rc2-quad-pipe-upstream-v14-0-b626236f4c31@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jun Nie , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754060859; l=1985; i=jun.nie@linaro.org; s=20240403; h=from:subject:message-id; bh=KP97mkf4mFx6Hynpv+UvTtqAjJLhCHcsa39rmhW+j40=; b=pF1qZrZf2S+wUGQF/vCeb1xQMwFfn3f+VOwpEVhumT1JmRUWshKxSjhwjlppjnAQvIBf1Y7p3 1qpy5d8fWD1BpBpuiMdy9fhYKpn68tPwOZpZ/FxZvmQCDofhsmcoE1N X-Developer-Key: i=jun.nie@linaro.org; a=ed25519; pk=MNiBt/faLPvo+iJoP1hodyY2x6ozVXL8QMptmsKg3cc= Currently, only one pair of mixers is supported, so a non-zero counter value is sufficient to identify the correct mixer within that pair. However, future implementations may involve multiple mixer pairs. With the current implementation, all mixers within the second pair would be incorrectly selected as right mixer. To correctly select the mixer within a pair, test the least significant bit of the counter. If the least significant bit is not set, select the mixer as left one; otherwise, select the mixer as right one for all pairs. Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index d4b545448d74657aafc96e9042c7756654b4f0e7..9a40492e5aa961f7180ba4ac6c86e06fcccef8c2 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -377,11 +377,10 @@ static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc) { struct dpu_crtc_state *crtc_state; - int lm_idx, lm_horiz_position; + int lm_idx; crtc_state = to_dpu_crtc_state(crtc->state); - lm_horiz_position = 0; for (lm_idx = 0; lm_idx < crtc_state->num_mixers; lm_idx++) { const struct drm_rect *lm_roi = &crtc_state->lm_bounds[lm_idx]; struct dpu_hw_mixer *hw_lm = crtc_state->mixers[lm_idx].hw_lm; @@ -392,7 +391,7 @@ static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc) cfg.out_width = drm_rect_width(lm_roi); cfg.out_height = drm_rect_height(lm_roi); - cfg.right_mixer = lm_horiz_position++; + cfg.right_mixer = lm_idx & 0x1; cfg.flags = 0; hw_lm->ops.setup_mixer_out(hw_lm, &cfg); } -- 2.34.1