From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF16225743E for ; Fri, 1 Aug 2025 13:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056291; cv=none; b=ZJecd0LjluQXlXyJzJVmRYbshmJyUDtRscvNl3AQGzcxfYhRXFkBZUoxUqDvz3oHO6e9pb8lXzWiT0zJRwQuOHwYQoNY95RyYhUKb1ghIyUwaCuDouBd+k6V14WQU7bsjr/K9sArE0wh6dKantyyhHNtamPAXfYkY6GGaYUuAc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056291; c=relaxed/simple; bh=NBwFx/yH904VfCprkWLv97gvBydY/VJ1MCw22/7DCtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yw3R8dFk0zWOj3H6kALzhbx3EfPDe6LW4hVON0yxWIkqgw4VqCJA96Wz+2QswaMZo7H6GxB9mlh3PvIJxe6x9tfy9xA5WF3W1dDFIcE2avToWqCqTuK1GFm33APSmfgyC8QcBEHWwpl7nsY+qqIfUToOaK8PV8SadVEs6C/zXVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bj6cMkpQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bj6cMkpQ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571CLY7O001961 for ; Fri, 1 Aug 2025 13:51:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mLmvIm7aiVxs6oMFsxxhFeeRx+tZKZlR89XtVnuV08M=; b=bj6cMkpQ1CVvcSbF fWDc1EgzCf9Uy42mi859BDmHxMGZLuGWKQ0511T+iMZFf3FBw34+kmvRM9ZwZ2T+ hqSiWO0SElelynghmVxziCRovCRsIoOp0DPCMhhygCXadGqFTBMY31fmCzil56hn TwN1uWP4dvOa9eW9/rLfqx5Hxzi1t9g/fc+EQhci4F7kHScRoMm18OgCxPA/IMJJ Sn+1TZEAkO1SA4NpsS9qT97FYO17Vd89PNXRC1ZFsXpnqbmMpUiqBr4iute12eU/ HjisHaG7kQRnXCTRalQhsczTLaXyaZfligHAJKqA1HEeCralZm5qQxCRbtItymku 3B47hw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 488wgrr7e6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:28 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ab81d016c1so13976021cf.3 for ; Fri, 01 Aug 2025 06:51:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056287; x=1754661087; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mLmvIm7aiVxs6oMFsxxhFeeRx+tZKZlR89XtVnuV08M=; b=NhJyhbLo3UNLP0xUInrmrPEwlT/DtDansjTiGMInFh0PAIFnx5vkjoacfm4nKnWG67 i9STRj0vCvmc92Elc3I08AG8CW6CvoQCQaUvL5aSIiwlzvdrmI/j5Tk+Kmn3Lf1hUrjH Kdz2ishQ9pndpOenXLW7vTYhpSshni/7MCHm3vu7YqOi/WbQyFWJU8/FcZfvUIyO2JG5 wBgi9UDNh8iABWeUyP+BjX7xrKNjeTt4hIwNoyu3ITasrh0oxHQLU7Xc9j12khaAWAOI caIHBcL8CweNjtri5LNyqEz2nGsM0Qcgt5zkNxN2tfB7usb//dqFgvAMapyvthfTcG5k 1yTA== X-Forwarded-Encrypted: i=1; AJvYcCVRTkyLUKMm1vZRA5tbgtm/rp3hTp+TcbAbZZc71YJoqojiyrHmR8CcJNoBCfJPbTsm/TLIAEccCq54+XhF@vger.kernel.org X-Gm-Message-State: AOJu0Yy2X/Q/IXvKOxy4V7CiLid611X6g8wSPygSmyuzKpznFmTMr9Jn 6Ms5TeL4FiDWkufGLLhxNQedOuDtQYG6lOjreC966aEtRL4sQtYrIVJPTFz6ttq3ZR3XjMz2j2C hn473IwlhMGcKSYsTl/LOClOzUDwUuHzUBi9kKGQojzkO2zUnMRvlCvMtKdNc9YUgjKVx X-Gm-Gg: ASbGncuissaZ09XC1dAm43fpQcYncyoFbQIgTQnd7sN4LBgLIZTD/HEIMJdt9qc5nnA FPbcAee4+Jv4sZwEmj819Du+8ND4+2z8J/3HrtqKaP1Zv6AQSTed/J0jAGko0eDAvC0L3uQcjoE /dB0KpiynF4YMhPA207itAM/bW05vW3GswQqV26xB9FP5Wzn6j62wC9eWE3w6/DwxJyXLLJz43Z 3HW9tOJM1NychRgFKiCOVo6FJ3RTuhXZrkARfmWNkVY2WUyup/ahBIpZJWcHzj2Uv5Zd7FjUDed ZW+NRFAUqPfjBWWQ9DgQTwvlhN97qpdbygrjYhkMdeiwQcVB+S6kXMv5fYh9gd0MJlbLexz+YHr 7N/K5/ay5uJ64m/SSyp+MTcbDT4nQhScNdLrIjAcC0pwI4G0Gymt4 X-Received: by 2002:ac8:7f0d:0:b0:4ae:cc29:829b with SMTP id d75a77b69052e-4aefc3aa90amr71546831cf.60.1754056287135; Fri, 01 Aug 2025 06:51:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2viD7HCKu6xS/QJRV2/S6eN0H8AL2SA3fKo1xo5upDmFhtIUjZt51hysctMnmpx05ndtrSQ== X-Received: by 2002:ac8:7f0d:0:b0:4ae:cc29:829b with SMTP id d75a77b69052e-4aefc3aa90amr71546121cf.60.1754056286612; Fri, 01 Aug 2025 06:51:26 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:25 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:14 +0300 Subject: [PATCH 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250801-wb-drop-encoder-v1-6-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1629; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NBwFx/yH904VfCprkWLv97gvBydY/VJ1MCw22/7DCtU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZTWODg7Z0I052lkDGy5sp+gbJXRPPW3+xXz I8SasIVGkCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUwAKCRCLPIo+Aiko 1WY8B/42eKCXBjQZniwEwDivu+L77h8KSZkeqYYq+el8I39V5l9aHEmdvGRms2n+efNwV1ck0rj Jy1a9Cv67p7eEXrs8o1zTP+BGa3sKhKTs4lvZWHx3d6YjAcJr2Zg3df9INQWC7IsATuDKgfbA2E JhHLnz8c+tuCb07y0uqnRTHGpLB3UcVli5DjTVGH5gGQPYpegIYqh/FVxuacRujIWIvOW4qRCT8 +FnwXJAsYkPA9arYZIm2kX8awv2FHs2ZTSNfz1ht3uGAjMo4BD1uCkmrqpvMEoLyEzE8gjHsSP8 5aOgtKUcrk2v0+9aBgHAKiILYunQCCOJCo28SHY+jdKL58YA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=fs7cZE4f c=1 sm=1 tr=0 ts=688cc660 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=hRdDZflY9wZGYtDLNskA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: kQ2qgBB-XK02Whi45Dj8hBzEjgZg-bfm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX5tRD7VbOxTYZ WyqBe47u6ZfkuqPmJS7PgJyh/vUoHIsFWGbQvlykU+I8cubJNW4RHivFuIx6zRa1XRH1lSuaAAt eHyYyT60BYzVOUSOJqSrQayrfaqVMN3WrvBkbGWPQKuGNoVqs35u/Ce1IsQ+4C/T9eWVu2S2V6x J4gEM5zc7lV/QnhsqiXlYWEYtfrunqNhNmxy2VHTk24DWvDI7Ospvi5SaZe/0K3ka0plKsUPGdn DeJg4DWSAmgUHGIu1+hz+ITfe3fTmRVLns9pcGZKc85pzlc45mLBpu+Q8A4PD/F+KhpBZuOscW4 BK6gMUZfSunilRws3fEz4/OWUKiPZl6HcFm1TO4uyEPZ2sp0xXGaFLjA5YJ6AjVN0P2UVb+PrGG fiT36/yMYLKrzi264yxXRpEoCKIkUJbUWC6qlnCNz2P2K9zH7oS9CF8+mn5kWoUtGR8ieNuy X-Proofpoint-ORIG-GUID: kQ2qgBB-XK02Whi45Dj8hBzEjgZg-bfm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 mlxlogscore=882 impostorscore=0 bulkscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 42acac05fe47861ced226a4f64661f545e21ddb5..fef4e4ee47cf41d40de47c5201f0349dc36c56bd 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -377,7 +377,6 @@ vc4_txp_connector_detect(struct drm_connector *connector, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs = { .detect = vc4_txp_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, @@ -601,10 +600,10 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret = drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret = drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; -- 2.39.5