From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D48285078 for ; Mon, 4 Aug 2025 18:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754332175; cv=none; b=a74g08jfnMP+OuH3fFQGjEl/nzw64Kva90IC9JiOtsGtF2nibGiECnNaJd6G8U/C8jBFBDQ1+1ks1bF71tW6jlx2ButzG8Z/k1YKJaS+x3CTy2X2OmIiibuU6YTMVQbDGRp/VGGFi5P/yP/TV7hlXJy9f1j7MSoj3BPghzNz9Sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754332175; c=relaxed/simple; bh=97Wf+005AjX2fyW62YinF32DHzBNO7WW5hMyEiyttls=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=jNJiDoJ6pZxL9HqZ8MDC+eHDRMQy/xL+WrDLXYCUszb0z830QsQh+JFFQBLg9PZTil6MCwmPJSuYfTX3t7CvliozPaJdKLwK3gpr5LSm4Vbt8zYLAlZXyZ9A3AY+VTdicFawioEC970bs8VY4HFNOgVaSGNaGhV5UowzHwtr26Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GGNCSbfZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GGNCSbfZ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5749XVHF006898 for ; Mon, 4 Aug 2025 18:29:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=4ZRS8X1q6T0ZLRueHzSZjd xm433yImBfAQNa/j3W3Cc=; b=GGNCSbfZcMkjB5y7evYdsnaCStsZoEky7Ae1tk nmO4sRjd3j3CX9+ZTbvUd/NGLMVEQ71LqdwhFRfraf+aLxjXNgMvar7cYbeaaLrx V7LWl6U1gorPCuouMU8Bdb1hsHdylSMhl9T/cnQqCt5jNb4YIizVUbyRFYlIJdfl 0ak5+iG2IevxTt0opjHINMctSXOP14TXxtWCzeSF7njra/MCjhtqLbqN0YjzC8/j SkcPw6LLGXt7ZVIlfNXdQ7/TePW+gT2QMYjz03Z5VkekUD9P9BpOH13NSMj6e92e lI+3wwbDk4R2WJNNKdwUQ14F3zTH0SdAwSV5bEemjRbV6zJg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4899pae046-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 04 Aug 2025 18:29:32 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2425e41424cso24228015ad.1 for ; Mon, 04 Aug 2025 11:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754332171; x=1754936971; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4ZRS8X1q6T0ZLRueHzSZjdxm433yImBfAQNa/j3W3Cc=; b=cvBcPG4q0HLE2KJiUAcqMBpC+mZ/9RDq2G47flxI4NlVk4+KAYDcivkVRxgoOB548w 0ONL5VbDh9zEWmF1TNb2EaNpo9wF4bwp1Ulv+mzI/ucrV7JBjnTxAwYuJnHExHH9FGDG HSCP/lX43neSLnJ281K81ldZQyKUbTNVgA0NbBySCF+NmQWpaW+oWTVQPlENHgdNpC6A yLKziBUhxKtonqKLg8JUyHiUTIBQoUdfZrUzmMxJGlICcpzG4SkU2u1l+DggWNbvNJxU AhlAzTAu7o03Eg3YSbdgV3+tzBCU7VOIaaBtr8IUxfgc+03K1lSFdz/15aYShwjvh8c8 zC8w== X-Forwarded-Encrypted: i=1; AJvYcCXmpFhqYb/lCbWN0ioJdPCXLOKPkml5wBL3sBNdJSgutFoy2WsiWfqfA1nTVA2gSjFzT5D722LBEUW8EXay@vger.kernel.org X-Gm-Message-State: AOJu0YzEldhxjSZWTT/XknGeI9ytgSay82vl3s+AYvcMwGxYhDlBNJUq A2KNdRLO6IPf/rFLC7ttUCjE80UfzTnNtA5NcKhh/woHdQsUHjAMsGcFIVs+MdN+qwG4Sd+durs V3LljIQFSum6UVA55aVapX0TeLZNQIfAzPuhYD80/jaVqvVBbSoilM+WMBTzqfpegUf/ZK2wzfh tr X-Gm-Gg: ASbGncsxH3J0Q0TlDAPiIaDzBraku3eL8fZNNdKHIXk23HynMKpieOGBCIkLu6tChew PNCq1b4DSmKs2Q7M8KdReARR8aAPkDmUs45wMYQdD3U1+kM4eso1El0ezMp26BlH1JPBEzM/RES 32j0GYAIUoNOHD7t0CJpF6t9XLbPkXZH5V6P1YCTXBwRVPpcn1Z+UaHamshfgOUi3+D0bbGZDeA YPaAeBo6TdOwF/o3RrToMDt1X893t7Gq1iiNROlZZpwztDhHPGooedq0EjT5nf0HtGjht+wTE95 ouZCNThjpn3qbR/Sf0k7x4Eg0Ta2dHSxQOnP02uFIT3SVRABHmax2Zli3h0KD7Og X-Received: by 2002:a17:903:1245:b0:234:1163:ff99 with SMTP id d9443c01a7336-2424705444bmr148283465ad.43.1754332170839; Mon, 04 Aug 2025 11:29:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHI/N3VZbz9RZmPiG99XcQflvUuxhU8jRiEQZfNcOiAlYNY9sO/cJUZlj+swyKOmrjO6HOihA== X-Received: by 2002:a17:903:1245:b0:234:1163:ff99 with SMTP id d9443c01a7336-2424705444bmr148283045ad.43.1754332170443; Mon, 04 Aug 2025 11:29:30 -0700 (PDT) Received: from hu-tdas-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8aaaf1bsm116664345ad.159.2025.08.04.11.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Aug 2025 11:29:30 -0700 (PDT) From: Taniya Das Date: Mon, 04 Aug 2025 23:59:21 +0530 Subject: [PATCH] clk: qcom: gcc: Update the SDCC clock to use shared_floor_ops Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250804-sdcc_rcg2_shared_ops-v1-1-41f989e8cbb1@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAAD8kGgC/x3MQQqAIBBG4avErBNMSqKrRIjoX82mYgYiCO+et PwW772kEIbS1LwkuFn5PCq6tqG0x2OD4VxNzrrBjrY3mlMKkjYXdI+CHM5LDaKH8904rPBU00u w8vNv56WUD3ZyUNdmAAAA X-Change-ID: 20250804-sdcc_rcg2_shared_ops-ea6e26185fe6 To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Taniya Das Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das X-Mailer: b4 0.15-dev-aa3f6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA0MDEwNiBTYWx0ZWRfX3jDKgY5QlWxn c9ifv7thbVTaLCLlSCeIxXIArgBqxEmajCaWiS+kNiwE0Ql7DCydgH86oqeN3+Mkk8N9+99ZECm gq2P1zuvkGLQQ+9kQ0dNpFZa0NQrjfpFLrD2UTcsmfy85kaZbo6FYbgKS2bwyKnSrZONlHUgcbP 4QTQe67zjQpedpA49Cg0Jg+zR0xfoNwzDT7vvWy6TX/T1t6hFQc+XjMMT9Y8dX23Uy2aBm+LIJc nlYHi9UnK2zfi/smTRxUMj9T1sTe6W/mRN60MKN8mjcIjBHZxY2z75fZIVBwzd8YXuUdsGEXX5X /c5dsWUX6ixgoS4BIrQAq+2sJDYf5TVO+h/tor/61VGg1mXYC53DjV0rvAPyT1lOhCLWg3BTs7z Kf2PylNvZWE9g7gH0LjWhY5ABaLiL26vArlD4szTyT41orGT07kYszxJnu1wNNpQi8vm4cMF X-Proofpoint-GUID: pUvfwSotZqfCj9DVJvS0N_DOsJ-MqLxo X-Authority-Analysis: v=2.4 cv=N88pF39B c=1 sm=1 tr=0 ts=6890fc0c cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=PH1V8s2_vfPofe0uiFIA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: pUvfwSotZqfCj9DVJvS0N_DOsJ-MqLxo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-04_08,2025-08-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508040106 gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot. This happens due to the floor_ops tries to update the rcg configuration even if the clock is not enabled. The shared_floor_ops ensures that the new parent configuration is cached in the parked_cfg in the case where the clock is off. Ensure to use the ops for the other SDCC clock instances as well. Fixes: 39d6dcf67fe9 ("clk: qcom: gcc: Add support for QCS615 GCC clocks") Signed-off-by: Taniya Das --- drivers/clk/qcom/gcc-qcs615.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs615.c b/drivers/clk/qcom/gcc-qcs615.c index 9695446bc2a3c81f63f6fc0c98d298270f3494cc..5b3b8dd4f114bdcb8911a9ce612c39a1c6e05b23 100644 --- a/drivers/clk/qcom/gcc-qcs615.c +++ b/drivers/clk/qcom/gcc-qcs615.c @@ -784,7 +784,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = { .name = "gcc_sdcc1_apps_clk_src", .parent_data = gcc_parent_data_1, .num_parents = ARRAY_SIZE(gcc_parent_data_1), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, }; @@ -806,7 +806,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = { .name = "gcc_sdcc1_ice_core_clk_src", .parent_data = gcc_parent_data_0, .num_parents = ARRAY_SIZE(gcc_parent_data_0), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, }; @@ -830,7 +830,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_8, .num_parents = ARRAY_SIZE(gcc_parent_data_8), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, }; --- base-commit: 5c5a10f0be967a8950a2309ea965bae54251b50e change-id: 20250804-sdcc_rcg2_shared_ops-ea6e26185fe6 Best regards, -- Taniya Das