* [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock
@ 2025-08-09 8:36 Dmitry Baryshkov
2025-08-12 10:27 ` Konrad Dybcio
2025-08-18 14:40 ` Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-08-09 8:36 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel
None of MDP5 platforms have a LUT clock on the display-controller, it
was added by the mistake. Drop it, fixing DT warnings on MSM8976 /
MSM8956 platforms. Technically it's an ABI break, but no other platforms
are affected.
Fixes: 385c8ac763b3 ("dt-bindings: display/msm: convert MDP5 schema to YAML format")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
index e153f8d26e7aaec64656570bbec700794651c10f..2735c78b0b67af8c004350f40ca9700c563b75f8 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
@@ -60,7 +60,6 @@ properties:
- const: bus
- const: core
- const: vsync
- - const: lut
- const: tbu
- const: tbu_rt
# MSM8996 has additional iommu clock
---
base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
change-id: 20250809-msm8976-no-lut-4b5100bcfb35
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock
2025-08-09 8:36 [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock Dmitry Baryshkov
@ 2025-08-12 10:27 ` Konrad Dybcio
2025-08-12 11:09 ` Dmitry Baryshkov
2025-08-18 14:40 ` Rob Herring (Arm)
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2025-08-12 10:27 UTC (permalink / raw)
To: Dmitry Baryshkov, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel
On 8/9/25 10:36 AM, Dmitry Baryshkov wrote:
> None of MDP5 platforms have a LUT clock on the display-controller, it
8974 and friends seem to bind it to the GDSC
although on msm-3.4:
arch/arm/mach-msm/clock-8974.c
4197:static struct branch_clk mdss_mdp_lut_clk = {
4203: .dbg_name = "mdss_mdp_lut_clk",
4205: CLK_INIT(mdss_mdp_lut_clk.c),
4609: {&mdss_mdp_lut_clk.c, MMSS_BASE, 0x0015},
5118: CLK_LOOKUP("lut_clk", mdss_mdp_lut_clk.c, "mdp.0"),
5387: CLK_LOOKUP("lut_clk", mdss_mdp_lut_clk.c, "fd8c2304.qcom,gdsc"
Konrad
> was added by the mistake. Drop it, fixing DT warnings on MSM8976 /
> MSM8956 platforms. Technically it's an ABI break, but no other platforms
> are affected.
>
> Fixes: 385c8ac763b3 ("dt-bindings: display/msm: convert MDP5 schema to YAML format")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> index e153f8d26e7aaec64656570bbec700794651c10f..2735c78b0b67af8c004350f40ca9700c563b75f8 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> @@ -60,7 +60,6 @@ properties:
> - const: bus
> - const: core
> - const: vsync
> - - const: lut
> - const: tbu
> - const: tbu_rt
> # MSM8996 has additional iommu clock
>
> ---
> base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
> change-id: 20250809-msm8976-no-lut-4b5100bcfb35
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock
2025-08-12 10:27 ` Konrad Dybcio
@ 2025-08-12 11:09 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-08-12 11:09 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On Tue, Aug 12, 2025 at 12:27:14PM +0200, Konrad Dybcio wrote:
> On 8/9/25 10:36 AM, Dmitry Baryshkov wrote:
> > None of MDP5 platforms have a LUT clock on the display-controller, it
>
> 8974 and friends seem to bind it to the GDSC
>
> although on msm-3.4:
>
> arch/arm/mach-msm/clock-8974.c
> 4197:static struct branch_clk mdss_mdp_lut_clk = {
> 4203: .dbg_name = "mdss_mdp_lut_clk",
> 4205: CLK_INIT(mdss_mdp_lut_clk.c),
> 4609: {&mdss_mdp_lut_clk.c, MMSS_BASE, 0x0015},
> 5118: CLK_LOOKUP("lut_clk", mdss_mdp_lut_clk.c, "mdp.0"),
> 5387: CLK_LOOKUP("lut_clk", mdss_mdp_lut_clk.c, "fd8c2304.qcom,gdsc"
At least it's not used on upstream (nor could I find relevant docs in
the HPG).
>
> Konrad
>
> > was added by the mistake. Drop it, fixing DT warnings on MSM8976 /
> > MSM8956 platforms. Technically it's an ABI break, but no other platforms
> > are affected.
> >
> > Fixes: 385c8ac763b3 ("dt-bindings: display/msm: convert MDP5 schema to YAML format")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> > Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> > index e153f8d26e7aaec64656570bbec700794651c10f..2735c78b0b67af8c004350f40ca9700c563b75f8 100644
> > --- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> > @@ -60,7 +60,6 @@ properties:
> > - const: bus
> > - const: core
> > - const: vsync
> > - - const: lut
> > - const: tbu
> > - const: tbu_rt
> > # MSM8996 has additional iommu clock
> >
> > ---
> > base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
> > change-id: 20250809-msm8976-no-lut-4b5100bcfb35
> >
> > Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock
2025-08-09 8:36 [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock Dmitry Baryshkov
2025-08-12 10:27 ` Konrad Dybcio
@ 2025-08-18 14:40 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-08-18 14:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: David Airlie, linux-kernel, Marijn Suijten, Simona Vetter,
dri-devel, Abhinav Kumar, freedreno, Dmitry Baryshkov,
Maarten Lankhorst, Conor Dooley, Jessica Zhang, Sean Paul,
Rob Clark, Maxime Ripard, Thomas Zimmermann, Krzysztof Kozlowski,
devicetree, linux-arm-msm
On Sat, 09 Aug 2025 11:36:54 +0300, Dmitry Baryshkov wrote:
> None of MDP5 platforms have a LUT clock on the display-controller, it
> was added by the mistake. Drop it, fixing DT warnings on MSM8976 /
> MSM8956 platforms. Technically it's an ABI break, but no other platforms
> are affected.
>
> Fixes: 385c8ac763b3 ("dt-bindings: display/msm: convert MDP5 schema to YAML format")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-18 14:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-09 8:36 [PATCH] dt-bindings: display/msm: qcom,mdp5: drop lut clock Dmitry Baryshkov
2025-08-12 10:27 ` Konrad Dybcio
2025-08-12 11:09 ` Dmitry Baryshkov
2025-08-18 14:40 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).