From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6000A20110B for ; Tue, 19 Aug 2025 01:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755567083; cv=none; b=T+Z3GH6swzp1yvAyvzj80w8x9NEH1jhiF4LJ4TIIH8P2WsXRIxx22VBdxkpNbzYmTHsd9zYP7E38sAHNS/pL9OfpYbnn7Bgo4oGaekDpg/cxP5R/Fjl8EMZFJo+PBEkmMGoF3xQgLKTzBKZ41mZAPJyHbnrKu6WAu6iiL0okwkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755567083; c=relaxed/simple; bh=KP97mkf4mFx6Hynpv+UvTtqAjJLhCHcsa39rmhW+j40=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V2EJv8RuRYKrfwm+kbMXzixgWe4oN/OCgnX6qo0r6Un2vcF/LpO5B1RRAnWDp+rxSVh234+WbvlIxOoSYC9sMfnz4qP+FKSzndeQwmF7GOF/pAV3aive1xontH/3qCeIp40EXETKO+8LD0XjcHftB2ho87ERxnDCwkoNkkvB+7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vKMJbsZk; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vKMJbsZk" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-32326793a85so3669848a91.1 for ; Mon, 18 Aug 2025 18:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755567081; x=1756171881; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rf99YwbE+zk9ZgJ2ORD0W2vahwafwsW/a1Bh6B8t8K0=; b=vKMJbsZku22c55ifBnHkn6CLm5kkNctY9KdGeQ6d9B5wyd8G5Bpcf/I+ywhQuKVeRJ g0VQrRGE9NwUc2dcUDSG/+LMu+JxwRJiuxUs4aD+rlO7gkXlUHx7B+PLaHu48GqR125V ULPrJ6pR5ypQc+bgoeWB/E59uUzMvreupZWVtXgdHquMvFYzvulry76geeHqayx4tGhX 4KT+cFSX6xdTetk4bGYNpJiT854Brgm+ihXnJzJQeBdxMMtP6FGNlQPxgvxe6XFrYWxT L5qFI30/1giybaHqo3OvQblIjb6LQdN8U6PsKdZKCix43fy2bAPdTX864XmeGr4AbUyV YykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755567081; x=1756171881; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rf99YwbE+zk9ZgJ2ORD0W2vahwafwsW/a1Bh6B8t8K0=; b=eqjl4R9gMZxM6nBEg30GSjWyk53R/BAS6E3+J5qQe2MwfNwcT5+t1LleY5avVHLCOn QPFFNugJDRzJyWQnLQ5FbJ07JPmAgtrF/uPg5Ra+Il9IzwAKVab2k4CrWolkP6RN9FYh q+utp2E1vTL/A+aUQAXLa7fiqyYrNXU03gdoTB50gKdB8wOYEM/RtfkDCWJgMD3tnkDc YeF7ZN35xFjos4Oer/zURWBGD5NUEun57ziKIiBCbvXa/+ZlsH6NSb7LGBzIVYZKxTHa PZLpHvF97ZnCnLgvNwspUS87WWyYQdSpXZuFkh/eqWqb9GIknSW24hWWdibBtN7BhnX7 KgZA== X-Gm-Message-State: AOJu0YwU2XkUuVIoMG7o3TWUckakvis6/qD/Yhc39CosdatXYnlTJrc/ uFqqLI2zcJthZ2Yutu/GJ7OvirUVSw4CCuoa9rEYtw/CFoi28O8EGT7OJ/sNnVgER4TdbuiNSHx +EttM5V8= X-Gm-Gg: ASbGncuUfOgAUpM0LNA1XKm208PGx8rpqqEmXHPaX1PX/zGEFeOs2uu8WV0Mv5ds+wn dIhuq+D1rAFyr0jSfUHbXPm888y0mpGFnzxn/VKlDb1hA1aJA2CU+SvJq2/O4NqHWYPivj5zfTD EPEwCF9hdnABuXUOxo3PzvmYhOoO8+NNFCs42KZLADINrfLSqcku22TpX+m+3mW0YPBzwGzjhQq Vp4Roo7PzOhOfIuQdYqg15zyvlU6wRuYcrJuAPfw5TLizz3uWXDDqzYD0O1ex8aRQT3k0gEik4M ++g75lA7MFl8AGNcmjk2R+jn46c7YmE+pyldHLePyiV0RJffHPItaKmEqXdH49+bpDXAdx6OGPJ s7Iz3ewiwKL/XHK7uBQ== X-Google-Smtp-Source: AGHT+IHsqfSLfsmrlFST+ENYayoezQghp4VEB2nLn4dJzMzMWEWc/lmmasXNyozxF8zA5e3IljcCrg== X-Received: by 2002:a17:90b:2cc8:b0:311:c939:c851 with SMTP id 98e67ed59e1d1-32476a4f190mr1303029a91.4.1755567081241; Mon, 18 Aug 2025 18:31:21 -0700 (PDT) Received: from [127.0.1.1] ([112.64.60.64]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3245e4faf80sm248637a91.5.2025.08.18.18.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 18:31:20 -0700 (PDT) From: Jun Nie Date: Tue, 19 Aug 2025 09:30:57 +0800 Subject: [PATCH v15 03/13] drm/msm/dpu: decide right side per last bit Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250819-v6-16-rc2-quad-pipe-upstream-v15-3-2c7a85089db8@linaro.org> References: <20250819-v6-16-rc2-quad-pipe-upstream-v15-0-2c7a85089db8@linaro.org> In-Reply-To: <20250819-v6-16-rc2-quad-pipe-upstream-v15-0-2c7a85089db8@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jun Nie , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755567061; l=1985; i=jun.nie@linaro.org; s=20240403; h=from:subject:message-id; bh=KP97mkf4mFx6Hynpv+UvTtqAjJLhCHcsa39rmhW+j40=; b=YoZ5FtiM7UZD4XTi6fivtdVzU+G2ybZj+qrFjggUBlCvL1Krk5X0FNM4ec81wpW7LAShhi1N+ DMHZL59GWxPCXAwtIhih5Ir2QOQcxPAWn45fJTn5T9iZCg6Ml0flHyO X-Developer-Key: i=jun.nie@linaro.org; a=ed25519; pk=MNiBt/faLPvo+iJoP1hodyY2x6ozVXL8QMptmsKg3cc= Currently, only one pair of mixers is supported, so a non-zero counter value is sufficient to identify the correct mixer within that pair. However, future implementations may involve multiple mixer pairs. With the current implementation, all mixers within the second pair would be incorrectly selected as right mixer. To correctly select the mixer within a pair, test the least significant bit of the counter. If the least significant bit is not set, select the mixer as left one; otherwise, select the mixer as right one for all pairs. Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index d4b545448d74657aafc96e9042c7756654b4f0e7..9a40492e5aa961f7180ba4ac6c86e06fcccef8c2 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -377,11 +377,10 @@ static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc) { struct dpu_crtc_state *crtc_state; - int lm_idx, lm_horiz_position; + int lm_idx; crtc_state = to_dpu_crtc_state(crtc->state); - lm_horiz_position = 0; for (lm_idx = 0; lm_idx < crtc_state->num_mixers; lm_idx++) { const struct drm_rect *lm_roi = &crtc_state->lm_bounds[lm_idx]; struct dpu_hw_mixer *hw_lm = crtc_state->mixers[lm_idx].hw_lm; @@ -392,7 +391,7 @@ static void _dpu_crtc_program_lm_output_roi(struct drm_crtc *crtc) cfg.out_width = drm_rect_width(lm_roi); cfg.out_height = drm_rect_height(lm_roi); - cfg.right_mixer = lm_horiz_position++; + cfg.right_mixer = lm_idx & 0x1; cfg.flags = 0; hw_lm->ops.setup_mixer_out(hw_lm, &cfg); } -- 2.34.1