From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA72340D95 for ; Tue, 19 Aug 2025 20:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635591; cv=none; b=EecMqs00LQjfnEiaZOqZSLBUB2e6KKJ+ZzqJ8/HL/bM3/mlAkZMhb/aiA+0BX/vc19Cg79gvJ7RqhMkM5BmL6AAe1ql689DBAam/Z1W4mR6gZTMrSO8SjgqHM1GRr93XxcWO4X4WaWO6CEQobMII1ESBYwI1SoO561Mz3TP7v5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635591; c=relaxed/simple; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NRG2AvQZtUle3UgCIFYyAT5ccreQPV3JVeU0VlKfLvwm4FUIaHxhsC/BAHI07bNTXRzZ5UV3z4O+AUd22Sq2nmlJUAnTwzvIgkk0T3jSv2vUcfSr1S9QztMyi0R0hNVopHi6CJdIfEoOphj99nkIDlZGGShIqPCRwXEJWfHmfRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SjU+1JJl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SjU+1JJl" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHOEr3001874 for ; Tue, 19 Aug 2025 20:33:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=SjU+1JJlEMN5h9Lq moBhgBbX7sVHFtLKHhg1uDJF+cObpbBG1wEVxbYP1yKWK8vYKsKnNLAl/eBnBC+o h77RKV8DW2ANEg1sBVNkx0PbDgc3asTaQv9UeGnJNHu4QnWT8RFv+T9xJRyeL+PE RBX27Qu3PLDQBXT7lfmo6AiRpdwuTsz0CikBraO/amPvw4feNj5Xb7/foe/kDxJ4 VuP07j7pin7nS5EGCHJRGDDmTM/T/PSRgnQ3kusPhpsd8NlNT8qfCvXS+5YrXzdX EEFT7I3RhLOKpPQaW9oEhkt1UWrykB63FA4/onp3niGnghnM4488Hl5m2ojMXfII OtRueQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jh079vg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:08 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70a928dc378so136448646d6.2 for ; Tue, 19 Aug 2025 13:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635587; x=1756240387; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=VSXb6fUA5Bd+pUjmYkRf9K6xGvm1xhQjnSHjvpALGGQ2lPYLHjZOIefxeIQ2xnGuJ2 XkWjJabF1bptrrKoLwLMkepLfL8bHr0nKCK+owcfV1eohbyGSvr74ncFb+eqMevNhHMS +2NrKgHIXqI90G0ab6HAAmvqHp59Fa22LaGgvlbzflgyq999hNg4lHH3nhK5TLbaPUGD d7z8E0kDIy9Epi4/FSUd298V7jjujVjY+mPWSmr1T5AfSsLDdx2kohLECoCRrl/x22zD /sNf/PmtBR+7XTF0dhs2v85nNgCTuPIBQfXybADGo3fLazP735PkaAQgv+u+LqcYTOBf HkEQ== X-Forwarded-Encrypted: i=1; AJvYcCX0+t6TD5DapqCZo9dbcFvR9HD2lZuXvAz7XKg+FlrSrevfAuQMlML3a2bG0K8wEE1W9ESBFANV5wNOgO/r@vger.kernel.org X-Gm-Message-State: AOJu0YzEASGH4tgmEePo1KqwAsLuDEYMUND85yhPw0Pp+4Em9iLDlQLz nfqB6Mv4cTrr02/8NMMf8zEN+NtDX/P+rQc55TOi/6R6dYrxMyq/UewPXDwf+4ktZrUuuvxZtn6 p4pu4pd/WC1ZMd2p+3Tga3VaHKTyh8YtYdESHvkfYZ0C8jAtjLtaN0U3ZDmPDmd9Akh4B X-Gm-Gg: ASbGnctH3cyIGElB8bTWhp/nTFqI4GY43MEtf4tj1tfGusjzLV7960CiPQ4xaXe94iA EggwUVwnA4ZmJJ86KPfA0TM96GvIA/zorKRFn95Dq0d+zB+3/zVH0BPCx55W91V1ViabZZaED6c tj3Llb6aRfleXWP1Q66J2AwaiqYlgKoNj2WcXLqll2M4aPW9/nt5UETDkDC9jZ1AkrhfSdCi5wD PicMCf40/RbvKnQrDZBnWAz89AxtgoAqbSSReZq6LNFUI5UVF/oghJO2jH3WZUwea3pRLmYMlyP L7AJBMeG0aU/e7mDEkpBo6qJP8ihe6JqSvmKOspFbxWtCtOQTgrcum/maskY/6sTLK0uLNW3Ph6 TL2MVGzQJiugiR7suhsYcuVAlQ1C40pJ2zA0slWielW1yVmmpmkiU X-Received: by 2002:a05:6214:d42:b0:707:4cba:124c with SMTP id 6a1803df08f44-70d76fcc6d0mr3925276d6.15.1755635587377; Tue, 19 Aug 2025 13:33:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXbzwbtPTMthExC2v/jPPGR0U6e77awEra/VfApnsoPxFWnQVPM0TA/4e3XCxu/atusvWn1w== X-Received: by 2002:a05:6214:d42:b0:707:4cba:124c with SMTP id 6a1803df08f44-70d76fcc6d0mr3924596d6.15.1755635586630; Tue, 19 Aug 2025 13:33:06 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:05 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:56 +0300 Subject: [PATCH v3 2/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250819-wb-drop-encoder-v3-2-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3013; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98pXeI0YI5rMMU0cfAZCQzyHd5SV6fCosRp 2k4DpPn0m6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1apAB/9Wed3uT8K4J7VbxZQYRdgbqkXEWuchv9h23rqen6qeVxtKb3hxBGlgSJGYV9xreUNSJnt kycaE7r7dHO6njLoIlrsEUjSpp8QhzDrdB3TkUHQI/qXhPZRO6jFnnNiIze3++SQeVxeLeQq2PZ 2rFLFqfPI2FY5msigg2DlqPrvKPoUNuVNS7pdu0UY/CvuGxBWQi4zhvckEkyL9Hux8vTpJPyf/i 6rhXGOI0GDWURVYOezbaytNWfpchR77qNdCUgqGdCF3fhHq8AI+avLEXbs+dyFKUqhzUgbLepqT 7umscLV59LLEPrJSAUSBGxAHsDU9svqZIx/JOZbeay4TJd/a X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: LqaTMvPNU5cYPhStciI1bW7XZQeouTRA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyMCBTYWx0ZWRfX3/gBTN5sUeTc NH9RBJTdVij1CeWRXS/FyqHvlxQOJa9Nug7NhoKvcqu4z7z0p6eABKAUhIGLlqCOes6ZMKZtBXQ jl+u5Wz6TOQ2nBPMDfM+AKPHChOdqNuFV1AAJsmPIIMESKf76ihHPkeNAYG8Rz3xC/WIV9DVlC/ SXT+aTNFY0ZzMw+q0JI+NNA6MyLKQr83+khwr1Hxqv9dbDzL6gHcXqpM/Dm+Ajvz3teLE1Nink9 jGmOG4MR8GrmxBf+uMP6S1xTD6mPbPdH6JnxxwT8OubGlRlqHhh7+HOMNeGR4KT/H4PBwE3tbFy +XC1EKfvjGNoGc5+nvnKhYv0kVqoujUN+aMKvCpkFnVCAFiQNLuhI2GiBAE0qpUEeuziMhc/InX 98QbXtVV X-Authority-Analysis: v=2.4 cv=a+Mw9VSF c=1 sm=1 tr=0 ts=68a4df84 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: LqaTMvPNU5cYPhStciI1bW7XZQeouTRA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160020 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++---------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9dc97e736049feaa8a1fe1bcc82ff..bcc53d4015f1f27181e977272cdcfa35e970fa62 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *connector, return 0; } -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs = { .reset = drm_atomic_helper_connector_reset, .detect = komeda_wb_connector_detect, .fill_modes = komeda_wb_connector_fill_modes, - .destroy = komeda_wb_connector_destroy, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats = 0; int err; if (!kcrtc->master->wb_layer) return 0; - kwb_conn = kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn = drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, return -ENOMEM; } - err = drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder = drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&kcrtc->base); + + err = drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); -- 2.47.2