* [PATCH 1/4] arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters
2025-08-19 10:45 [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Stephan Gerhold
@ 2025-08-19 10:45 ` Stephan Gerhold
2025-08-19 10:45 ` [PATCH 2/4] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: " Stephan Gerhold
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2025-08-19 10:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Dmitry Baryshkov, Maud Spierings, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
The &eusb3_repeater belongs to the first port of the USB MP controller and
the &eusb6_repeater belongs to the second. This is obvious if one looks at
e.g. the CRD or the Dell XPS where only the second port of the USB MP is
used: They only have the &eusb6_repeater and already specify it for the
&usb_mp_hsphy1.
Swap them to set the correct repeater for each of the USB ports.
Fixes: d12fbd11c5a3 ("arm64: dts: qcom: x1e001de-devkit: Enable support for both Type-A USB ports")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index 2d9627e6c7983daedba87619ba01074ee22b43c9..a3323d03f644e411c472305f5cf3482ecbdb787c 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -1474,7 +1474,7 @@ &usb_mp_hsphy0 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb6_repeater>;
+ phys = <&eusb3_repeater>;
status = "okay";
};
@@ -1483,7 +1483,7 @@ &usb_mp_hsphy1 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb3_repeater>;
+ phys = <&eusb6_repeater>;
status = "okay";
};
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix swapped USB MP repeaters
2025-08-19 10:45 [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Stephan Gerhold
2025-08-19 10:45 ` [PATCH 1/4] arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters Stephan Gerhold
@ 2025-08-19 10:45 ` Stephan Gerhold
2025-08-19 10:45 ` [PATCH 3/4] arm64: dts: qcom: x1e80100-asus-vivobook-s15: " Stephan Gerhold
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2025-08-19 10:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Dmitry Baryshkov, Maud Spierings, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
The &eusb3_repeater belongs to the first port of the USB MP controller and
the &eusb6_repeater belongs to the second. This is obvious if one looks at
e.g. the CRD or the Dell XPS where only the second port of the USB MP is
used: They only have the &eusb6_repeater and already specify it for the
&usb_mp_hsphy1.
Swap them to set the correct repeater for each of the USB ports.
Fixes: ffbf3a8be766 ("arm64: dts: qcom: x1e78100-t14s: Enable support for both Type-A USB ports")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 4cf61c2a34e31233b1adc93332bcabef22de3f86..e04df29a8853797c0e36cb60ebc2fb3161a41d30 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -1543,7 +1543,7 @@ &usb_mp_hsphy0 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb6_repeater>;
+ phys = <&eusb3_repeater>;
status = "okay";
};
@@ -1552,7 +1552,7 @@ &usb_mp_hsphy1 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb3_repeater>;
+ phys = <&eusb6_repeater>;
status = "okay";
};
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix swapped USB MP repeaters
2025-08-19 10:45 [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Stephan Gerhold
2025-08-19 10:45 ` [PATCH 1/4] arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters Stephan Gerhold
2025-08-19 10:45 ` [PATCH 2/4] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: " Stephan Gerhold
@ 2025-08-19 10:45 ` Stephan Gerhold
2025-08-19 10:45 ` [PATCH 4/4] arm64: dts: qcom: x1e80100-qcp: " Stephan Gerhold
2025-08-24 2:55 ` [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2025-08-19 10:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Dmitry Baryshkov, Maud Spierings, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
The &eusb3_repeater belongs to the first port of the USB MP controller and
the &eusb6_repeater belongs to the second. This is obvious if one looks at
e.g. the CRD or the Dell XPS where only the second port of the USB MP is
used: They only have the &eusb6_repeater and already specify it for the
&usb_mp_hsphy1.
Swap them to set the correct repeater for each of the USB ports.
Fixes: c0c46eea2444 ("arm64: dts: qcom: x1e80100-vivobook-s15: Enable USB-A ports")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
index 62eba17cdc87c088ca471b4cbf5b44af06400fe4..b571e8349d3b378ad2436b86044652db3f16993f 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
@@ -971,7 +971,7 @@ &usb_mp_hsphy0 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb6_repeater>;
+ phys = <&eusb3_repeater>;
status = "okay";
};
@@ -980,7 +980,7 @@ &usb_mp_hsphy1 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb3_repeater>;
+ phys = <&eusb6_repeater>;
status = "okay";
};
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] arm64: dts: qcom: x1e80100-qcp: Fix swapped USB MP repeaters
2025-08-19 10:45 [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Stephan Gerhold
` (2 preceding siblings ...)
2025-08-19 10:45 ` [PATCH 3/4] arm64: dts: qcom: x1e80100-asus-vivobook-s15: " Stephan Gerhold
@ 2025-08-19 10:45 ` Stephan Gerhold
2025-08-24 2:55 ` [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2025-08-19 10:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Dmitry Baryshkov, Maud Spierings, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
The &eusb3_repeater belongs to the first port of the USB MP controller and
the &eusb6_repeater belongs to the second. This is obvious if one looks at
e.g. the CRD or the Dell XPS where only the second port of the USB MP is
used: They only have the &eusb6_repeater and already specify it for the
&usb_mp_hsphy1.
Swap them to set the correct repeater for each of the USB ports.
Fixes: 9f53c3611960 ("arm64: dts: qcom: x1e78100-qcp: Enable Type-A USB ports labeled 3 and 4/6")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 9369b76c668b5c008fefd85d5ca18e87ab9ce93f..b02a66f0895e9c91e5403553620615e0a3bfd7a9 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -1507,7 +1507,7 @@ &usb_mp_hsphy0 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb6_repeater>;
+ phys = <&eusb3_repeater>;
status = "okay";
};
@@ -1516,7 +1516,7 @@ &usb_mp_hsphy1 {
vdd-supply = <&vreg_l2e_0p8>;
vdda12-supply = <&vreg_l3e_1p2>;
- phys = <&eusb3_repeater>;
+ phys = <&eusb6_repeater>;
status = "okay";
};
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports
2025-08-19 10:45 [PATCH 0/4] arm64: dts: qcom: x1: Fix swapped USB MP repeaters for boards with 2 ports Stephan Gerhold
` (3 preceding siblings ...)
2025-08-19 10:45 ` [PATCH 4/4] arm64: dts: qcom: x1e80100-qcp: " Stephan Gerhold
@ 2025-08-24 2:55 ` Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2025-08-24 2:55 UTC (permalink / raw)
To: Konrad Dybcio, Stephan Gerhold
Cc: Abel Vesa, Dmitry Baryshkov, Maud Spierings, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
On Tue, 19 Aug 2025 12:45:19 +0200, Stephan Gerhold wrote:
> The &eusb3_repeater belongs to the first port of the USB MP controller and
> the &eusb6_repeater belongs to the second. This is obvious if one looks at
> e.g. the CRD or the Dell XPS where only the second port of the USB MP is
> used: They only have the &eusb6_repeater and already specify it for the
> &usb_mp_hsphy1.
>
> Swap them for the affected boards with 2 ports to set the correct repeater
> for each of the USB ports. Boards with just a single port used (CRD, Dell
> XPS) are already correct.
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: x1e001de-devkit: Fix swapped USB MP repeaters
commit: 59a4b94a8c46c71f6c7aac00c21dc781b525fd6d
[2/4] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix swapped USB MP repeaters
commit: c3994b495111bd0ae663c63fc96a869678d03e6c
[3/4] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix swapped USB MP repeaters
commit: d5d72e326762c24f2fbc48e5f223cb674cecad1a
[4/4] arm64: dts: qcom: x1e80100-qcp: Fix swapped USB MP repeaters
commit: 6dcc44fc695b11bf4e654774a7c865abf96a2af3
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread