From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 594C12E62B4 for ; Wed, 20 Aug 2025 16:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755705767; cv=none; b=NLNU1AliXcP2rURV6tEbjcDTHdgsRZMqsJCUiR4RWdb9AiDrx9JofITHvZKONdzaEIdToD6YowB/J8tUuNi0aOBvX8nGfw20rcccw/Kfv7qFe8F/jLxPbbqs5QaJiieKH2LulkHlLhr1IsF5S7/PS5NW/6jcqiYPJYgThScV+xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755705767; c=relaxed/simple; bh=ceYKT3vSfgejeLJSxkGS10wrJuDMf2QLAgi1+YybTuo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nAPKVvEsOghZn/Bvp+pVN47gsS4z7oH4gvVXg5PwAeL1xgy4bWqf0+mVa8ukBbrRv7r8UOzSrlP239i78oiuUBmWlnANxGNvtkI/rvlnLNCrxu9Tk2+lZDj0Eb/h7SXSmYsBzBmcGl0Cfl1ChHeo3e+BB7ot6hmcgsh9Jj7mLTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AXICg8kl; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AXICg8kl" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3b9d41c1963so74023f8f.0 for ; Wed, 20 Aug 2025 09:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755705764; x=1756310564; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tjfVhv9eLkbIqBEE7fXFjARPFm2eJB57FpMUozSdD4M=; b=AXICg8klDQtptdu2WXQUS6lLMhl+jfNMcldtF2JtnPfZM1OCRCFGgQJRJCh+AnlqGP demvMr8uOMpO0nQklbriS+DltyQ0d6iVFIj3TKp072qU1aeKy5C51UwL71nSjALFs7Ts noJXVVraYsEnwo++CDDyAr1urdle8Mb1QxQPzBIMqTkNxhdURCrCL9+epjFYVpSx2iHa mQKwS9ujO9ujFf8+pE5yuR1I3R8L0/ZdJ0BqP0kKBzfpLCAvrM64nMu34J1V2dJhYTYX CKt5DtIpk2PNUru/IrrEsfzu8YQNYPiKZhgsKfMcVOstiwpKhOhJGnliVDLXHaXGHRU5 AAVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755705764; x=1756310564; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tjfVhv9eLkbIqBEE7fXFjARPFm2eJB57FpMUozSdD4M=; b=vLN1pexTGatj4qK9dYQbCdiaPIWonMep1vv1/1tRrVO15Vc5m1ZkG5h8B5o3MZEYnq s4cfe/qCiG/wZek23lCXlLxFH71zIVQ9ArXt4xeDQcM3BGuAxQbdO4IQ4Ydlw2YBNQpx 3Eu8a6TwLJ9Sfv9s0XftkU2K4XRHnjH0zu88NCtFvQ7+DYSgG++VIAYadKmphUka7tRG /h8s83QVF8jOtMr2DgsmpbeQwWGnmPkQd1PxQ/UHkTbL3qOQxglJVOlQOhBOktkdBgjS ai1ZtpKKidNL8NONj4T66/n6WWNgY/u1kUnBTsMzNsIABc8+wDgZ4bLcBlOGITN/sVPE wZ9w== X-Forwarded-Encrypted: i=1; AJvYcCWMOLE8mv/5Hd5KAXtzZ+MS9JJ9Vjb2w4vJmyuBbooOxL1G1VI8HK5qaKuARZaDpTToZK9t6S11L/MPcIzc@vger.kernel.org X-Gm-Message-State: AOJu0YzCXOGAEp+A1PtG0/MM53CHc/ktX5odrBdBbSnmxkVOzyN+lD0u Hvi4NOtK4vfEzE2XwccxRK6twLJBi0/+1n8hU5wAZmDTJrdYqSMCkhs8MI4M7mb17Js= X-Gm-Gg: ASbGncsRO8TL7iDskThhBNLEyExFHNl2W+YoSPFZ9mH1rihlm8N+S3YK6JUYH/iUaJA jXXc7jHbI2awLGcGlLU3Y1r3Yd3IFUhTObNyslRF6g5w5So8eGt7fCGa/AbsuIaeRTVp7yqmYkW e0H0gIl0bvgH31+tPm5LpdgkGZzcWdmDfcQOxcmKUgibh3n4AIFMJCX3BnZdOpVF1IF+EexfkU9 30sqvXY9QDJFXFrgm79va/omFk3w23DFiXczh9pAQxHL6O7qli/kApXFP/mY0D4Y+8qeoodw0Lt 50E2atgvNycm5OicysZ0CGbcUHAWGrGDAjKZpkCf1J+mrmQ4kjyRd0AFL99Teeqkn/wMmwObGli sXWLzyWw4FutKhVuqPSF8JNFfPuUVOH7l1JzW X-Google-Smtp-Source: AGHT+IFhMcKbAMu0PvVDiGeVBMEhgCK2n9Gg7XUc2NrwrVFxoYM9mheSAsCoD/kyMWNfHdDuo2ptCA== X-Received: by 2002:a05:6000:4313:b0:3b7:8fcd:d145 with SMTP id ffacd0b85a97d-3c32be67bdbmr2961716f8f.5.1755705763407; Wed, 20 Aug 2025 09:02:43 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:f5f2:96b:fcb7:af4b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c074d43956sm8364628f8f.19.2025.08.20.09.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 09:02:43 -0700 (PDT) From: Stephan Gerhold Date: Wed, 20 Aug 2025 18:02:36 +0200 Subject: [PATCH v2 4/4] remoteproc: qcom_q6v5_pas: Drop redundant assignment to ret Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250820-rproc-qcom-q6v5-fixes-v2-4-910b1a3aff71@linaro.org> References: <20250820-rproc-qcom-q6v5-fixes-v2-0-910b1a3aff71@linaro.org> In-Reply-To: <20250820-rproc-qcom-q6v5-fixes-v2-0-910b1a3aff71@linaro.org> To: Bjorn Andersson , Mathieu Poirier Cc: Sibi Sankar , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.14.2 We don't have a way to detect if the lite firmware is actually running yet, so we should ignore the return status of qcom_scm_pas_shutdown() for now. The assignment to "ret" is not used anywhere, so just drop it. Signed-off-by: Stephan Gerhold --- drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index f3ec5b06261e8bafe8a8d2378b60285d0855674a..6faedae8d32ef6c3c2071975f2f1e37a9ffd8abe 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -227,7 +227,7 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) pas->firmware = fw; if (pas->lite_pas_id) - ret = qcom_scm_pas_shutdown(pas->lite_pas_id); + qcom_scm_pas_shutdown(pas->lite_pas_id); if (pas->lite_dtb_pas_id) qcom_scm_pas_shutdown(pas->lite_dtb_pas_id); -- 2.50.1