[PATCH 0/6] ASoC: qcom: add support for Glymur

[PATCH 0/6] ASoC: qcom: add support for Glymur

[Srinivas Kandagatla]

This patchset adds basic support for Glymur sound card,
- by reusing x1e80100 snd card machine
- reusing lpass wsa and va codec macro which are identical to v2.9 codec version.

For now only tested WSA and VA, which is why tx and rx codec macros are
not added as part of this series.

Tested this on Glymur reference platform.

thanks,
Srini

Srinivas Kandagatla (6):
  ASoC: qcom: x1e80100: set card driver name from match data
  ASoC: dt-bindings: qcom,sm8250: Add glymur sound card
  ASoC: qcom: x1e80100: add compatible for glymur SoC
  ASoC: dt-bindings: qcom: Add Glymur LPASS wsa and va macro codecs
  ASoC: codecs: lpass-macro: add Codec version 2.9
  ASoC: codecs: lpass-wsa-macro: add Codev version 2.9

 .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml       | 1 +
 .../devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml      | 1 +
 Documentation/devicetree/bindings/sound/qcom,sm8250.yaml     | 1 +
 sound/soc/codecs/lpass-macro-common.h                        | 1 +
 sound/soc/codecs/lpass-va-macro.c                            | 2 ++
 sound/soc/codecs/lpass-wsa-macro.c                           | 2 ++
 sound/soc/qcom/x1e80100.c                                    | 5 +++--
 7 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.50.0

[PATCH 1/6] ASoC: qcom: x1e80100: set card driver name from match data

[Srinivas Kandagatla]

Sound machine drivers for Qualcomm SoCs can be reused across multiple
SoCs. But user space ALSA UCM files depend on the card driver name which
should be set per board/SoC.

Allow such customization by using driver match data as sound card driver
name.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 sound/soc/qcom/x1e80100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/qcom/x1e80100.c b/sound/soc/qcom/x1e80100.c
index 8eb57fc12f0d..322010d54af6 100644
--- a/sound/soc/qcom/x1e80100.c
+++ b/sound/soc/qcom/x1e80100.c
@@ -210,14 +210,14 @@ static int x1e80100_platform_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	card->driver_name = "x1e80100";
+	card->driver_name = of_device_get_match_data(dev);
 	x1e80100_add_be_ops(card);
 
 	return devm_snd_soc_register_card(dev, card);
 }
 
 static const struct of_device_id snd_x1e80100_dt_match[] = {
-	{ .compatible = "qcom,x1e80100-sndcard", },
+	{ .compatible = "qcom,x1e80100-sndcard", .data = "x1e80100" },
 	{}
 };
 MODULE_DEVICE_TABLE(of, snd_x1e80100_dt_match);
-- 
2.50.0

[PATCH 2/6] ASoC: dt-bindings: qcom,sm8250: Add glymur sound card

[Srinivas Kandagatla]

Document the bindings for the glymur sound card which is
audioreach based architecture.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 5d3dbb6cb1ae..8ac91625dce5 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -31,6 +31,7 @@ properties:
           - fairphone,fp4-sndcard
           - fairphone,fp5-sndcard
           - qcom,apq8096-sndcard
+          - qcom,glymur-sndcard
           - qcom,qcm6490-idp-sndcard
           - qcom,qcs6490-rb3gen2-sndcard
           - qcom,qcs8275-sndcard
-- 
2.50.0

[PATCH 3/6] ASoC: qcom: x1e80100: add compatible for glymur SoC

[Srinivas Kandagatla]

Add support for glymur SoC based sound card support.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 sound/soc/qcom/x1e80100.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/qcom/x1e80100.c b/sound/soc/qcom/x1e80100.c
index 322010d54af6..444f2162889f 100644
--- a/sound/soc/qcom/x1e80100.c
+++ b/sound/soc/qcom/x1e80100.c
@@ -218,6 +218,7 @@ static int x1e80100_platform_probe(struct platform_device *pdev)
 
 static const struct of_device_id snd_x1e80100_dt_match[] = {
 	{ .compatible = "qcom,x1e80100-sndcard", .data = "x1e80100" },
+	{ .compatible = "qcom,glymur-sndcard", .data = "glymur" },
 	{}
 };
 MODULE_DEVICE_TABLE(of, snd_x1e80100_dt_match);
-- 
2.50.0

[PATCH 4/6] ASoC: dt-bindings: qcom: Add Glymur LPASS wsa and va macro codecs

[Srinivas Kandagatla]

Document compatibles for Qualcomm Glymur SoC macro digital codecs
(VA and WSA), compatible with previous generation (SM8550 and SM8650).

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
 .../devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml          | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index dd549db6c841..2e8c26d89b00 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -20,6 +20,7 @@ properties:
           - qcom,sc8280xp-lpass-va-macro
       - items:
           - enum:
+              - qcom,glymur-lpass-va-macro
               - qcom,sm8650-lpass-va-macro
               - qcom,sm8750-lpass-va-macro
               - qcom,x1e80100-lpass-va-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
index 9082e363c709..b6f5ba5d1320 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
@@ -20,6 +20,7 @@ properties:
           - qcom,sc8280xp-lpass-wsa-macro
       - items:
           - enum:
+              - qcom,glymur-lpass-wsa-macro
               - qcom,sm8650-lpass-wsa-macro
               - qcom,sm8750-lpass-wsa-macro
               - qcom,x1e80100-lpass-wsa-macro
-- 
2.50.0

[PATCH 5/6] ASoC: codecs: lpass-macro: add Codec version 2.9

[Srinivas Kandagatla]

Add support for lpass codec macro version 2.9, which is available in
Qualcomm Glymur SoCs.

Its compatible with 2.8 w.r.t register layouts.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 sound/soc/codecs/lpass-macro-common.h | 1 +
 sound/soc/codecs/lpass-va-macro.c     | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h
index fb4b96cb2b23..10ad682019fa 100644
--- a/sound/soc/codecs/lpass-macro-common.h
+++ b/sound/soc/codecs/lpass-macro-common.h
@@ -29,6 +29,7 @@ enum lpass_codec_version {
 	LPASS_CODEC_VERSION_2_6,
 	LPASS_CODEC_VERSION_2_7,
 	LPASS_CODEC_VERSION_2_8,
+	LPASS_CODEC_VERSION_2_9,
 };
 
 struct lpass_macro {
diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
index a49551f3fb29..2e1b77973a3e 100644
--- a/sound/soc/codecs/lpass-va-macro.c
+++ b/sound/soc/codecs/lpass-va-macro.c
@@ -1485,6 +1485,8 @@ static void va_macro_set_lpass_codec_version(struct va_macro *va)
 		version = LPASS_CODEC_VERSION_2_7;
 	if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x80 || core_id_2 == 0x81))
 		version = LPASS_CODEC_VERSION_2_8;
+	if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x90 || core_id_2 == 0x91))
+		version = LPASS_CODEC_VERSION_2_9;
 
 	if (version == LPASS_CODEC_VERSION_UNKNOWN)
 		dev_warn(va->dev, "Unknown Codec version, ID: %02x / %02x / %02x\n",
-- 
2.50.0

[PATCH 6/6] ASoC: codecs: lpass-wsa-macro: add Codev version 2.9

[Srinivas Kandagatla]

Add support for lpass wsa codec macro version 2.9, which is available in
Qualcomm Glymur SoCs.

Its compatible with 2.8 w.r.t register layouts

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
---
 sound/soc/codecs/lpass-wsa-macro.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c
index da6adb3de21d..187805b39264 100644
--- a/sound/soc/codecs/lpass-wsa-macro.c
+++ b/sound/soc/codecs/lpass-wsa-macro.c
@@ -2690,6 +2690,7 @@ static int wsa_macro_component_probe(struct snd_soc_component *comp)
 	case LPASS_CODEC_VERSION_2_6:
 	case LPASS_CODEC_VERSION_2_7:
 	case LPASS_CODEC_VERSION_2_8:
+	case LPASS_CODEC_VERSION_2_9:
 		widgets = wsa_macro_dapm_widgets_v2_5;
 		num_widgets = ARRAY_SIZE(wsa_macro_dapm_widgets_v2_5);
 		break;
@@ -2838,6 +2839,7 @@ static int wsa_macro_probe(struct platform_device *pdev)
 	case LPASS_CODEC_VERSION_2_6:
 	case LPASS_CODEC_VERSION_2_7:
 	case LPASS_CODEC_VERSION_2_8:
+	case LPASS_CODEC_VERSION_2_9:
 		wsa->reg_layout = &wsa_codec_v2_5;
 		def_count = ARRAY_SIZE(wsa_defaults) + ARRAY_SIZE(wsa_defaults_v2_5);
 		reg_defaults = kmalloc_array(def_count, sizeof(*reg_defaults),
-- 
2.50.0

Re: [PATCH 2/6] ASoC: dt-bindings: qcom,sm8250: Add glymur sound card

[Krzysztof Kozlowski]

On Tue, Sep 02, 2025 at 03:00:40PM +0100, Srinivas Kandagatla wrote:
> Document the bindings for the glymur sound card which is
> audioreach based architecture.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 4/6] ASoC: dt-bindings: qcom: Add Glymur LPASS wsa and va macro codecs

[Krzysztof Kozlowski]

On Tue, Sep 02, 2025 at 03:00:42PM +0100, Srinivas Kandagatla wrote:
> Document compatibles for Qualcomm Glymur SoC macro digital codecs
> (VA and WSA), compatible with previous generation (SM8550 and SM8650).
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
>  .../devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml          | 1 +
>  2 files changed, 2 insertions(+)
>

What about tx and rx? Not yet ready?


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 5/6] ASoC: codecs: lpass-macro: add Codec version 2.9

[Krzysztof Kozlowski]

On Tue, Sep 02, 2025 at 03:00:43PM +0100, Srinivas Kandagatla wrote:
> Add support for lpass codec macro version 2.9, which is available in
> Qualcomm Glymur SoCs.
> 
> Its compatible with 2.8 w.r.t register layouts.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  sound/soc/codecs/lpass-macro-common.h | 1 +
>  sound/soc/codecs/lpass-va-macro.c     | 2 ++
>  2 files changed, 3 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 6/6] ASoC: codecs: lpass-wsa-macro: add Codev version 2.9

[Krzysztof Kozlowski]

On Tue, Sep 02, 2025 at 03:00:44PM +0100, Srinivas Kandagatla wrote:
> Add support for lpass wsa codec macro version 2.9, which is available in
> Qualcomm Glymur SoCs.
> 
> Its compatible with 2.8 w.r.t register layouts
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  sound/soc/codecs/lpass-wsa-macro.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 4/6] ASoC: dt-bindings: qcom: Add Glymur LPASS wsa and va macro codecs

[Srinivas Kandagatla]

On 9/3/25 8:57 AM, Krzysztof Kozlowski wrote:
> On Tue, Sep 02, 2025 at 03:00:42PM +0100, Srinivas Kandagatla wrote:
>> Document compatibles for Qualcomm Glymur SoC macro digital codecs
>> (VA and WSA), compatible with previous generation (SM8550 and SM8650).
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
>>  .../devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml          | 1 +
>>  2 files changed, 2 insertions(+)
>>
> 
> What about tx and rx? Not yet ready?

Correct, I have not verified tx and rx yet on this platform which is why
I did not set the bindings for it yet.

TX and RX codecs are using SDCA so its possible that there might be some
delta here.


--srini
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 0/6] ASoC: qcom: add support for Glymur

[Mark Brown]

On Tue, 02 Sep 2025 15:00:38 +0100, Srinivas Kandagatla wrote:
> This patchset adds basic support for Glymur sound card,
> - by reusing x1e80100 snd card machine
> - reusing lpass wsa and va codec macro which are identical to v2.9 codec version.
> 
> For now only tested WSA and VA, which is why tx and rx codec macros are
> not added as part of this series.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: qcom: x1e80100: set card driver name from match data
      commit: 5ab26b8ca5649e4a16e4b48efe5a0b92299c8f51
[2/6] ASoC: dt-bindings: qcom,sm8250: Add glymur sound card
      commit: 8f48b160e1b8f0c959e25df63994e6204b3794a8
[3/6] ASoC: qcom: x1e80100: add compatible for glymur SoC
      commit: 8c7ea98650e644ff61d3774085f732b40d8f7788
[4/6] ASoC: dt-bindings: qcom: Add Glymur LPASS wsa and va macro codecs
      commit: 25436580f025d42bd7ccf3b960f4c405f3c91512
[5/6] ASoC: codecs: lpass-macro: add Codec version 2.9
      commit: c73e2c5672dae4f6711cab99cabff9e72cd0591a
[6/6] ASoC: codecs: lpass-wsa-macro: add Codev version 2.9
      commit: ce1a46b2d6a8465a86f7a6f71beb4c6de83bce5c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark