Re: [PATCH v3 10/12] remoteproc: pas: Extend parse_fw callback to fetch resources via SMC call

kernel test robot
2025-09-21T18:08:15Z

Hi Mukesh,

kernel test robot noticed the following build errors:

[auto build test ERROR on 846bd2225ec3cfa8be046655e02b9457ed41973e]

url: https://github.com/intel-lab-lkp/linux/commits/Mukesh-Ojha/dt-bindings-remoteproc-qcom-pas-Add-iommus-property/20250921-041055
base: 846bd2225ec3cfa8be046655e02b9457ed41973e
patch link: https://lore.kernel.org/r/20250921-kvm_rproc_pas-v3-10-458f09647920%40oss.qualcomm.com
patch subject: [PATCH v3 10/12] remoteproc: pas: Extend parse_fw callback to fetch resources via SMC call
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20250922/202509220147.nsw5xumc-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250922/202509220147.nsw5xumc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509220147.nsw5xumc-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/remoteproc/qcom_q6v5_pas.c: In function 'qcom_pas_parse_firmware':
>> drivers/remoteproc/qcom_q6v5_pas.c:452:45: error: passing argument 1 of 'qcom_scm_pas_get_rsc_table' makes pointer from integer without a cast [-Wint-conversion]
452 | ret = qcom_scm_pas_get_rsc_table(pas->pas_id, table, table_sz, &output_rt,
| ~~~^~~~~~~~
| |
| int
In file included from drivers/remoteproc/qcom_q6v5_pas.c:22:
include/linux/firmware/qcom/qcom_scm.h:97:57: note: expected 'struct qcom_scm_pas_ctx *' but argument is of type 'int'
97 | int qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_ctx *ctx, void *input_rt,
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~

vim +/qcom_scm_pas_get_rsc_table +452 drivers/remoteproc/qcom_q6v5_pas.c

411
412 static int qcom_pas_parse_firmware(struct rproc *rproc, const struct firmware *fw)
413 {
414 size_t output_rt_size = MAX_RSCTABLE_SIZE;
415 struct qcom_pas *pas = rproc->priv;
416 struct resource_table *table = NULL;
417 void *output_rt;
418 size_t table_sz;
419 int ret;
420
421 ret = qcom_register_dump_segments(rproc, fw);
422 if (ret) {
423 dev_err(pas->dev, "Error in registering dump segments\n");
424 return ret;
425 }
426
427 if (!rproc->has_iommu)
428 return ret;
429
430 ret = rproc_elf_load_rsc_table(rproc, fw);
431 if (ret)
432 dev_info(&rproc->dev, "Error in loading resource table from firmware\n");
433
434 table = rproc->table_ptr;
435 table_sz = rproc->table_sz;
436
437 /*
438 * Qualcomm remote processor may rely on static and dynamic resources for
439 * it to be functional. For most of the Qualcomm SoCs, when run with Gunyah
440 * or older QHEE hypervisor, all the resources whether it is static or dynamic,
441 * is managed by present hypervisor. Dynamic resources if it is present for
442 * a remote processor will always be coming from secure world via SMC call
443 * while static resources may be present in remote processor firmware binary
444 * or it may be coming from SMC call along with dynamic resources.
445 *
446 * Here, we call rproc_elf_load_rsc_table() to check firmware binary has resources
447 * or not and if it is not having then we pass NULL and zero as input resource
448 * table pointer and size respectively to the argument of qcom_scm_pas_get_rsc_table()
449 * and this is even true for Qualcomm remote processor who does follow remoteproc
450 * framework.
451 */
> 452 ret = qcom_scm_pas_get_rsc_table(pas->pas_id, table, table_sz, &output_rt,
453 &output_rt_size);
454 if (ret) {
455 dev_err(pas->dev, "error %d getting resource_table\n", ret);
456 return ret;
457 }
458
459 kfree(rproc->cached_table);
460 rproc->cached_table = output_rt;
461 rproc->table_ptr = rproc->cached_table;
462 rproc->table_sz = output_rt_size;
463
464 return ret;
465 }
466

--
0-DAY CI Kernel Test Service