From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Abraham I" <kishon@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Subject: [PATCH 3/3] PCI: qcom: Treat PHY and PERST# as optional for the new binding
Date: Fri, 10 Oct 2025 11:25:49 -0700 [thread overview]
Message-ID: <20251010-pci-binding-v1-3-947c004b5699@oss.qualcomm.com> (raw)
In-Reply-To: <20251010-pci-binding-v1-0-947c004b5699@oss.qualcomm.com>
Even for the new DT binding where the PHY and PERST# properties are
specified in the Root Port, both are optional. Hence, treat them as
optional in the driver too.
If both properties are not specified, then fall back to parsing the legacy
binding for backwards compatibility.
Fixes: a2fbecdbbb9d ("PCI: qcom: Add support for parsing the new Root Port binding")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
drivers/pci/controller/dwc/pcie-qcom.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 805edbbfe7eba496bc99ca82051dee43d240f359..d380981cf3ad78f549de3dc06bd2f626f8f53920 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1720,13 +1720,20 @@ static int qcom_pcie_parse_port(struct qcom_pcie *pcie, struct device_node *node
reset = devm_fwnode_gpiod_get(dev, of_fwnode_handle(node),
"reset", GPIOD_OUT_HIGH, "PERST#");
- if (IS_ERR(reset))
+ if (IS_ERR(reset) && PTR_ERR(reset) != -ENOENT)
return PTR_ERR(reset);
- phy = devm_of_phy_get(dev, node, NULL);
+ phy = devm_of_phy_optional_get(dev, node, NULL);
if (IS_ERR(phy))
return PTR_ERR(phy);
+ /*
+ * If both PHY and PERST# properties are not specified, then try the
+ * legacy binding.
+ */
+ if (PTR_ERR(reset) == -ENOENT && !phy)
+ return -ENOENT;
+
port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
if (!port)
return -ENOMEM;
--
2.48.1
next prev parent reply other threads:[~2025-10-10 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 18:25 [PATCH 0/3] PCI: qcom: Binding fix Manivannan Sadhasivam
2025-10-10 18:25 ` [PATCH 1/3] dt-bindings: PCI: Update the email address for Manivannan Sadhasivam Manivannan Sadhasivam
2025-10-15 12:43 ` Rob Herring (Arm)
2025-10-10 18:25 ` [PATCH 2/3] dt-bindings: PCI: qcom: Enforce check for PHY, PERST# and WAKE# properties Manivannan Sadhasivam
2025-10-10 18:28 ` Konrad Dybcio
2025-10-10 19:33 ` Rob Herring (Arm)
2025-10-11 4:10 ` Manivannan Sadhasivam
2025-10-10 18:25 ` Manivannan Sadhasivam [this message]
2025-10-10 18:32 ` [PATCH 3/3] PCI: qcom: Treat PHY and PERST# as optional for the new binding Konrad Dybcio
2025-10-11 4:09 ` Manivannan Sadhasivam
2025-10-13 9:43 ` Bartosz Golaszewski
2025-10-13 14:40 ` Krishna Chaitanya Chundru
2025-10-26 15:57 ` (subset) [PATCH 0/3] PCI: qcom: Binding fix Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010-pci-binding-v1-3-947c004b5699@oss.qualcomm.com \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).