From: Vladimir Lypak <vladimir.lypak@gmail.com>
To: "Rob Clark" <robin.clark@oss.qualcomm.com>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	"Abhinav Kumar" <abhinav.kumar@linux.dev>,
	"Jessica Zhang" <jessica.zhang@oss.qualcomm.com>,
	"Sean Paul" <sean@poorly.run>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Kalyan Thota" <quic_kalyant@quicinc.com>,
	"Vinod Polimera" <quic_vpolimer@quicinc.com>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Barnabás Czémán" <barnabas.czeman@mainlining.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Vladimir Lypak <vladimir.lypak@gmail.com>
Subject: [PATCH 1/6] drm/msm/dpu: Fix allocation of RGB SSPPs without scaling
Date: Fri, 17 Oct 2025 19:58:35 +0000	[thread overview]
Message-ID: <20251017-b4-dpu-fixes-v1-1-40ce5993eeb6@gmail.com> (raw)
In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com>
Due to condition in dpu_rm_reserve_sspp, RGB SSPPs are only tried when
scaling is requested, which prevents those SSPPs from being reserved if
we don't need scaling at all. Instead we should check if YUV support is
requested, since scaling on RGB SSPPs is optional and is not implemented
in driver yet.
Fixes: 774bcfb73176 ("drm/msm/dpu: add support for virtual planes")
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
index 2c77c74fac0fda649da8ce19b7b3c6cb32b9535c..d9c3b0a1d0914a47f86ac9a854fbcede021e73cb 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
@@ -842,7 +842,7 @@ struct dpu_hw_sspp *dpu_rm_reserve_sspp(struct dpu_rm *rm,
 
 	if (!reqs->scale && !reqs->yuv)
 		hw_sspp = dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_DMA);
-	if (!hw_sspp && reqs->scale)
+	if (!hw_sspp && !reqs->yuv)
 		hw_sspp = dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_RGB);
 	if (!hw_sspp)
 		hw_sspp = dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_VIG);
-- 
2.51.0
next prev parent reply	other threads:[~2025-10-17 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 19:58 [PATCH 0/6] drm/msm/dpu: Fixes for virtual planes and 1.x features Vladimir Lypak
2025-10-17 19:58 ` Vladimir Lypak [this message]
2025-10-28 21:24   ` [PATCH 1/6] drm/msm/dpu: Fix allocation of RGB SSPPs without scaling Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 2/6] drm/msm/dpu: Propagate error from dpu_assign_plane_resources Vladimir Lypak
2025-10-28 21:24   ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 3/6] drm/msm/dpu: Disable scaling for unsupported scaler types Vladimir Lypak
2025-10-28 21:25   ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 4/6] drm/msm/dpu: Fix pixel extension sub-sampling Vladimir Lypak
2025-10-28 21:26   ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 5/6] drm/msm/dpu: Require linear modifier for writeback framebuffers Vladimir Lypak
2025-10-28 21:26   ` Dmitry Baryshkov
2025-10-18 14:33 ` [PATCH 6/6] drm/msm/dpu: Disable broken YUV on QSEED2 hardware Vladimir Lypak
2025-10-28 21:27   ` Dmitry Baryshkov
2025-10-28 22:14   ` Dmitry Baryshkov
2025-10-29  0:30 ` [PATCH 0/6] drm/msm/dpu: Fixes for virtual planes and 1.x features Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20251017-b4-dpu-fixes-v1-1-40ce5993eeb6@gmail.com \
    --to=vladimir.lypak@gmail.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=barnabas.czeman@mainlining.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_vpolimer@quicinc.com \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).