From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACDFF33F8C9 for ; Fri, 17 Oct 2025 20:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731244; cv=none; b=LyDdXReU+QhMMNUCD597Gv6bTArv0iN3HfEtOjSH94u9FKyb666EzGf20/agxoqd0xC8ymh/8MCPepyb3Og4038WirrKpyiq6fVdubA+SvCxpXq7E4jm9RZko5PS79PAqjFZ6ARR4AJP3F7HsX2CpeMnyZTt9cZiAuHmkMCg9w8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731244; c=relaxed/simple; bh=F2zDecP6+oFfoSg8W+FxJSa/s3jTLYNPTNsWj2Zuph0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X/Mxe9vX9RLcqtPQkBykYSkKCb2OugckJe7qXOsfqawp6rp7PC1V/i+tg8RYUf3zvXUI5xrE86QZ3t5teUV2ws7IAKgILKe42TeOEp0iXEOneAAGylnVhtws3e3sm/GmXxWYMnMdGdf4pkM8z+zPr4b6kGGpSGmLFPmv+mJSGmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CoDgKL6q; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CoDgKL6q" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-3612c38b902so21586811fa.2 for ; Fri, 17 Oct 2025 13:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731241; x=1761336041; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xQNJSxr8t/BdOOWVzHAAqI48NQwvfIqpyN0Al86/+Ik=; b=CoDgKL6qeSpEtOdkltiQdM6lKq8SKshtM0o1TwwAIBBTknGFxW593YMFj0VIcdfLoG xRB1VUhpRIB/AmGKtTTd0F0gFWoODULuI6hrDBkrjINmugpZpGPuMXooBsgpVdvIH6r+ KHiLC8BKbySk7nolP/XlhQpJaco+zt0lMMAHfsWv3XtzG61l718SD4RWv2w9Qudq+peY aPmVIoCE4O4WA4jC0UOxRGt3zlP/JMWgJO7jRKdrr6Cn7w3WqmJ+JcLtSSdD/xPaOcqS QwvmZxFffVRb0zTvw8+OsBRpqTGeo+pE57cgkck3wPBzaCpLdkEoC6CwmoA5giT/wroH F3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731241; x=1761336041; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xQNJSxr8t/BdOOWVzHAAqI48NQwvfIqpyN0Al86/+Ik=; b=RPH1ZPoQHlGSOUkqsKpzTzX1spaTcdIsdbHuv8jkckFdguHwTlRqV/ycPkflR3dvEd fH2bz9x3Tus86O+dADrp0ITXq8dFESneSjXkUyki/Ilm5ZRagkFtNVgN/MsDxknlm1KF kYtfQXFUxP/oa8cP9sS+VVTKKCbdoEHh/Zyypf99xiNxo7cco6G295tyrn4GQgx+Gmnc DyIPkj8dn2lfvc0BM2kGXViabds2v9TiLKOPt+g1sZUQB4f2H8D5MbPN+4vYPVS2iBe3 w4trE7fzrA12xebYzCdsxwbbfbUKeTWu42opuTbFg1fP2BBXI0WgvHe/tHUuoCxkqV+F tDpQ== X-Gm-Message-State: AOJu0YxVY57rTYMftttYRGdyvu4A5fc/MeX9KKj2v9+/tuid6CWlzjpI WWLP7/YpKpryc2SKRI4r+7vNapwxSWkRkKPm/6kgiDko34dl2WpvaeSx2ZfkqsSa X-Gm-Gg: ASbGncth15K5VtdoIfgn84RHRwQM71Gh2dkoi05nX4xzUfwuq3Vs1t7VKxvgVZJpaIR ZzJ10T8Wgsia4pHFUm/6TojN6gE8Un8eyXj/VjpNsbpaB3b2BF/kQVE6tToVBquC9rJVZdeDx7l 7nKzLhFSEP0yaJIkguE+jWzBgrD7B5NQFnNH6dcnv3wPtaxN3dgMKPz+Nw+lLqGjGPgB4Ar0/c3 jDsOPAT8yOJI71N6MatUMeTK8IVKjpZvxZ9K8aDs1PN9fQEyYjlFYV5ZudlU/5od5jPfouQoV91 2BKm1ykmZJKKTXJc69kpd4EvnTfsFg+OpwntXMT2LtQZZJrhr1dyERIfh4iDUtu/8mbGES2YgD3 bQWm2l/afZcf3YoXBta62aylLD+YmLHp/WuJv5FdFecNvycKfRdclDz1YZqztu8PFinacUISlI+ JdwIpJtpwN//JdnqR9d6S1vL5NIYTw1Fqr7FUe2bOIN4fvyC8SoElICBq8IU5qSw== X-Google-Smtp-Source: AGHT+IGNU4fQjBz2jSA6DBrpEqZEn5tDNBRAgHPtQC9tAm1M2lku7pLWWHwNUw5re71jbQvu9jXrmA== X-Received: by 2002:a2e:bd03:0:b0:333:e590:1bc9 with SMTP id 38308e7fff4ca-37797a0e735mr14647271fa.24.1760731240714; Fri, 17 Oct 2025 13:00:40 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:00:40 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:37 +0000 Subject: [PATCH 3/6] drm/msm/dpu: Disable scaling for unsupported scaler types Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251017-b4-dpu-fixes-v1-3-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 Scaling is not implemented for some type of scalers (QSEED2 and RGB) but it was unintentionally re-enabled with change below. The remaining condition in dpu_plane_atomic_check_pipe is not enough because it only checks for length of scaler block (which is present). This patch adds a additional check for setup_scaler operation. Fixes: 8f15005783b8 ("drm/msm/dpu: move scaling limitations out of the hw_catalog") Signed-off-by: Vladimir Lypak --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index d198a65a2c5fef5fbdebc9c383a4b08bc71b8bf3..6effe0fa4837284a1f038e4907c4c91d239aeb8b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -740,7 +740,7 @@ static int dpu_plane_atomic_check_pipe(struct dpu_plane *pdpu, * We already have verified scaling against platform limitations. * Now check if the SSPP supports scaling at all. */ - if (!sblk->scaler_blk.len && + if (!(sblk->scaler_blk.len && pipe->sspp->ops.setup_scaler) && ((drm_rect_width(&new_plane_state->src) >> 16 != drm_rect_width(&new_plane_state->dst)) || (drm_rect_height(&new_plane_state->src) >> 16 != -- 2.51.0