From: Vladimir Lypak <vladimir.lypak@gmail.com>
To: "Rob Clark" <robin.clark@oss.qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
"Jessica Zhang" <jessica.zhang@oss.qualcomm.com>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Kalyan Thota" <quic_kalyant@quicinc.com>,
"Vinod Polimera" <quic_vpolimer@quicinc.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Vladimir Lypak <vladimir.lypak@gmail.com>
Subject: [PATCH 5/6] drm/msm/dpu: Require linear modifier for writeback framebuffers
Date: Fri, 17 Oct 2025 19:58:39 +0000 [thread overview]
Message-ID: <20251017-b4-dpu-fixes-v1-5-40ce5993eeb6@gmail.com> (raw)
In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com>
UBWC-related register configuration for writeback is not implemented in
the driver yet but there aren't any checks for non-linear modifiers in
atomic_check. Thus when compressed framebuffer is attached to writeback
connector it will be filled with linear image data. This patch forbids
non-linear modifiers for writeback framebuffers until UBWC support for
writeback is properly implemented.
Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c")
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
index cd73468e369a93c50303db2a7d4499bcb17be5d1..7545c0293efbd8f7eb34a4ac56f616b7cadae1c0 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
@@ -72,6 +72,9 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector,
DPU_ERROR("invalid fb w=%d, maxlinewidth=%u\n",
fb->width, dpu_wb_conn->maxlinewidth);
return -EINVAL;
+ } else if (fb->modifier != DRM_FORMAT_MOD_LINEAR) {
+ DPU_ERROR("unsupported fb modifier:%#llx\n", fb->modifier);
+ return -EINVAL;
}
return drm_atomic_helper_check_wb_connector_state(conn_state->connector, conn_state->state);
--
2.51.0
next prev parent reply other threads:[~2025-10-17 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 19:58 [PATCH 0/6] drm/msm/dpu: Fixes for virtual planes and 1.x features Vladimir Lypak
2025-10-17 19:58 ` [PATCH 1/6] drm/msm/dpu: Fix allocation of RGB SSPPs without scaling Vladimir Lypak
2025-10-28 21:24 ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 2/6] drm/msm/dpu: Propagate error from dpu_assign_plane_resources Vladimir Lypak
2025-10-28 21:24 ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 3/6] drm/msm/dpu: Disable scaling for unsupported scaler types Vladimir Lypak
2025-10-28 21:25 ` Dmitry Baryshkov
2025-10-17 19:58 ` [PATCH 4/6] drm/msm/dpu: Fix pixel extension sub-sampling Vladimir Lypak
2025-10-28 21:26 ` Dmitry Baryshkov
2025-10-17 19:58 ` Vladimir Lypak [this message]
2025-10-28 21:26 ` [PATCH 5/6] drm/msm/dpu: Require linear modifier for writeback framebuffers Dmitry Baryshkov
2025-10-18 14:33 ` [PATCH 6/6] drm/msm/dpu: Disable broken YUV on QSEED2 hardware Vladimir Lypak
2025-10-28 21:27 ` Dmitry Baryshkov
2025-10-28 22:14 ` Dmitry Baryshkov
2025-10-29 0:30 ` [PATCH 0/6] drm/msm/dpu: Fixes for virtual planes and 1.x features Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017-b4-dpu-fixes-v1-5-40ce5993eeb6@gmail.com \
--to=vladimir.lypak@gmail.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=barnabas.czeman@mainlining.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_kalyant@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).